All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Thierry <julien.thierry@arm.com>
To: "Alex Bennée" <alex.bennee@linaro.org>,
	kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	kvmarm@lists.cs.columbia.edu, christoffer.dall@linaro.org,
	marc.zyngier@arm.com
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/2] KVM: arm64: handle single-stepping trapped instructions
Date: Fri, 6 Oct 2017 14:15:21 +0100	[thread overview]
Message-ID: <ec903fcc-6e73-40c6-69b0-b37d7d53d431@arm.com> (raw)
In-Reply-To: <20171006113921.24880-2-alex.bennee@linaro.org>



On 06/10/17 12:39, Alex Bennée wrote:
> If we are using guest debug to single-step the guest we need to ensure
> we exit after emulating the instruction. This only affects
> instructions completely emulated by the kernel. For userspace emulated
> instructions we need to exit and return to complete the emulation.
> 
> We fake debug.arch.hsr to contain ESR_ELx_EC_SOFTSTP_LOW so QEMU knows
> it was a single-step event (and without altering the userspace ABI).
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Reviewed-by: Julien Thierry <julien.thierry@arm.com>

Thanks,

-- 
Julien Thierry

WARNING: multiple messages have this Message-ID (diff)
From: julien.thierry@arm.com (Julien Thierry)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1 1/2] KVM: arm64: handle single-stepping trapped instructions
Date: Fri, 6 Oct 2017 14:15:21 +0100	[thread overview]
Message-ID: <ec903fcc-6e73-40c6-69b0-b37d7d53d431@arm.com> (raw)
In-Reply-To: <20171006113921.24880-2-alex.bennee@linaro.org>



On 06/10/17 12:39, Alex Benn?e wrote:
> If we are using guest debug to single-step the guest we need to ensure
> we exit after emulating the instruction. This only affects
> instructions completely emulated by the kernel. For userspace emulated
> instructions we need to exit and return to complete the emulation.
> 
> We fake debug.arch.hsr to contain ESR_ELx_EC_SOFTSTP_LOW so QEMU knows
> it was a single-step event (and without altering the userspace ABI).
> 
> Signed-off-by: Alex Benn?e <alex.bennee@linaro.org>

Reviewed-by: Julien Thierry <julien.thierry@arm.com>

Thanks,

-- 
Julien Thierry

  parent reply	other threads:[~2017-10-06 13:15 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-06 11:39 [PATCH v1 0/2] KVM: arm64: single step emulation instructions Alex Bennée
2017-10-06 11:39 ` Alex Bennée
2017-10-06 11:39 ` [PATCH v1 1/2] KVM: arm64: handle single-stepping trapped instructions Alex Bennée
2017-10-06 11:39   ` Alex Bennée
2017-10-06 11:39   ` Alex Bennée
2017-10-06 12:27   ` Marc Zyngier
2017-10-06 12:27     ` Marc Zyngier
2017-10-06 12:34     ` Julien Thierry
2017-10-06 12:34       ` Julien Thierry
2017-10-06 12:46       ` Marc Zyngier
2017-10-06 12:46         ` Marc Zyngier
2017-10-06 13:15   ` Julien Thierry [this message]
2017-10-06 13:15     ` Julien Thierry
2017-10-13  8:26   ` Christoffer Dall
2017-10-13  8:26     ` Christoffer Dall
2017-10-13  8:26     ` Christoffer Dall
2017-10-13  9:15     ` Alex Bennée
2017-10-13  9:15       ` Alex Bennée
2017-10-13  9:15       ` Alex Bennée
2017-10-14 14:16       ` Christoffer Dall
2017-10-14 14:16         ` Christoffer Dall
2017-10-14 14:16         ` Christoffer Dall
2017-10-06 11:39 ` [PATCH v1 2/2] kvm: arm64: handle single-step of userspace mmio instructions Alex Bennée
2017-10-06 11:39   ` Alex Bennée
2017-10-06 11:39   ` Alex Bennée
2017-10-06 12:37   ` Marc Zyngier
2017-10-06 12:37     ` Marc Zyngier
2017-10-06 12:44     ` Marc Zyngier
2017-10-06 12:44       ` Marc Zyngier
2017-10-06 13:47       ` Alex Bennée
2017-10-06 13:47         ` Alex Bennée
2017-10-06 13:47         ` Alex Bennée
2017-10-06 14:00         ` Marc Zyngier
2017-10-06 14:00           ` Marc Zyngier
2017-10-06 14:26           ` Julien Thierry
2017-10-06 14:26             ` Julien Thierry
2017-10-06 14:43             ` Marc Zyngier
2017-10-06 14:43               ` Marc Zyngier
2017-10-06 14:43               ` Marc Zyngier
2017-10-06 13:13   ` Julien Thierry
2017-10-06 13:13     ` Julien Thierry
2017-10-06 13:13     ` Julien Thierry
2017-10-06 13:45     ` Alex Bennée
2017-10-06 13:45       ` Alex Bennée
2017-10-06 14:27       ` Julien Thierry
2017-10-06 14:27         ` Julien Thierry
2017-10-06 14:27         ` Julien Thierry
2017-10-13  8:59       ` Christoffer Dall
2017-10-13  8:59         ` Christoffer Dall
2017-10-13  8:59         ` Christoffer Dall
2017-10-13  9:23         ` Alex Bennée
2017-10-13  9:23           ` Alex Bennée
2017-10-14 14:18           ` Christoffer Dall
2017-10-14 14:18             ` Christoffer Dall
2017-10-13  8:56   ` Christoffer Dall
2017-10-13  8:56     ` Christoffer Dall
2017-10-13  9:27     ` Alex Bennée
2017-10-13  9:27       ` Alex Bennée
2017-10-14 14:20       ` Christoffer Dall
2017-10-14 14:20         ` Christoffer Dall
2017-10-14 14:20         ` Christoffer Dall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ec903fcc-6e73-40c6-69b0-b37d7d53d431@arm.com \
    --to=julien.thierry@arm.com \
    --cc=alex.bennee@linaro.org \
    --cc=catalin.marinas@arm.com \
    --cc=christoffer.dall@linaro.org \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.