From: "Linux regression tracking (Thorsten Leemhuis)" <regressions@leemhuis.info> To: Dave Ertman <david.m.ertman@intel.com>, intel-wired-lan@lists.osuosl.org Cc: Jaroslav Pulchart <jaroslav.pulchart@gooddata.com>, Linux kernel regressions list <regressions@lists.linux.dev> Subject: Re: [Intel-wired-lan] [PATCH net v2] ice: avoid bonding causing auxiliary plug/unplug under RTNL lock Date: Thu, 16 Feb 2023 11:33:40 +0100 [thread overview] Message-ID: <eca2d453-5b0b-b012-dcf8-be6e197536db@leemhuis.info> (raw) In-Reply-To: <20230215191757.1826508-1-david.m.ertman@intel.com> On 15.02.23 20:17, Dave Ertman wrote: > RDMA is not supported in ice on a PF that has been added to a bonded > interface. To enforce this, when an interface enters a bond, we unplug > the auxiliary device that supports RDMA functionality. This unplug > currently happens in the context of handling the netdev bonding event. > This event is sent to the ice driver under RTNL context. This is causing > a deadlock where the RDMA driver is waiting for the RTNL lock to complete > the removal. > > Defer the unplugging/re-plugging of the auxiliary device to the service > task so that it is not performed under the RTNL lock context. Thanks for taking care of this. > Reported-by: Jaroslav Pulchart <jaroslav.pulchart@gooddata.com> > Link: https://lore.kernel.org/linux-rdma/68b14b11-d0c7-65c9-4eeb-0487c95e395d@leemhuis.info/ FWIW, that should be Link: https://lore.kernel.org/netdev/CAK8fFZ6A_Gphw_3-QMGKEFQk=sfCw1Qmq0TVZK3rtAi7vb621A@mail.gmail.com/ instead, as that's Jaroslav's report > Fixes: 5cb1ebdbc434 ("ice: Fix race condition during interface enslave") > Fixes: 425c9bd06b7a ("RDMA/irdma: Report the correct link speed") > Signed-off-by: Dave Ertman <david.m.ertman@intel.com> > [...] Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) -- Everything you wanna know about Linux kernel regression tracking: https://linux-regtracking.leemhuis.info/about/#tldr If I did something stupid, please tell me, as explained on that page. _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
WARNING: multiple messages have this Message-ID (diff)
From: "Linux regression tracking (Thorsten Leemhuis)" <regressions@leemhuis.info> To: Dave Ertman <david.m.ertman@intel.com>, intel-wired-lan@lists.osuosl.org Cc: Jaroslav Pulchart <jaroslav.pulchart@gooddata.com>, Linux kernel regressions list <regressions@lists.linux.dev> Subject: Re: [Intel-wired-lan] [PATCH net v2] ice: avoid bonding causing auxiliary plug/unplug under RTNL lock Date: Thu, 16 Feb 2023 11:33:40 +0100 [thread overview] Message-ID: <eca2d453-5b0b-b012-dcf8-be6e197536db@leemhuis.info> (raw) In-Reply-To: <20230215191757.1826508-1-david.m.ertman@intel.com> On 15.02.23 20:17, Dave Ertman wrote: > RDMA is not supported in ice on a PF that has been added to a bonded > interface. To enforce this, when an interface enters a bond, we unplug > the auxiliary device that supports RDMA functionality. This unplug > currently happens in the context of handling the netdev bonding event. > This event is sent to the ice driver under RTNL context. This is causing > a deadlock where the RDMA driver is waiting for the RTNL lock to complete > the removal. > > Defer the unplugging/re-plugging of the auxiliary device to the service > task so that it is not performed under the RTNL lock context. Thanks for taking care of this. > Reported-by: Jaroslav Pulchart <jaroslav.pulchart@gooddata.com> > Link: https://lore.kernel.org/linux-rdma/68b14b11-d0c7-65c9-4eeb-0487c95e395d@leemhuis.info/ FWIW, that should be Link: https://lore.kernel.org/netdev/CAK8fFZ6A_Gphw_3-QMGKEFQk=sfCw1Qmq0TVZK3rtAi7vb621A@mail.gmail.com/ instead, as that's Jaroslav's report > Fixes: 5cb1ebdbc434 ("ice: Fix race condition during interface enslave") > Fixes: 425c9bd06b7a ("RDMA/irdma: Report the correct link speed") > Signed-off-by: Dave Ertman <david.m.ertman@intel.com> > [...] Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) -- Everything you wanna know about Linux kernel regression tracking: https://linux-regtracking.leemhuis.info/about/#tldr If I did something stupid, please tell me, as explained on that page.
next prev parent reply other threads:[~2023-02-16 10:33 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-02-15 19:17 [Intel-wired-lan] [PATCH net v2] ice: avoid bonding causing auxiliary plug/unplug under RTNL lock Dave Ertman 2023-02-16 8:54 ` Petr Oros 2023-02-16 10:33 ` Linux regression tracking (Thorsten Leemhuis) [this message] 2023-02-16 10:33 ` Linux regression tracking (Thorsten Leemhuis) 2023-02-16 10:36 ` Linux regression tracking (Thorsten Leemhuis) 2023-02-16 10:36 ` Linux regression tracking (Thorsten Leemhuis) 2023-02-16 17:24 ` Linus Heckemann 2023-02-24 18:33 ` Ertman, David M 2023-03-01 13:12 ` Petr Oros 2023-03-02 12:38 ` Linus Heckemann 2023-03-10 19:03 ` Tony Nguyen 2023-03-06 11:03 ` Arland, ArpanaX
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=eca2d453-5b0b-b012-dcf8-be6e197536db@leemhuis.info \ --to=regressions@leemhuis.info \ --cc=david.m.ertman@intel.com \ --cc=intel-wired-lan@lists.osuosl.org \ --cc=jaroslav.pulchart@gooddata.com \ --cc=regressions@lists.linux.dev \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.