* [PATCH net] net: mdio: fix the wrong parameters
@ 2023-06-19 9:49 Jiawen Wu
2023-06-19 14:17 ` Andrew Lunn
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jiawen Wu @ 2023-06-19 9:49 UTC (permalink / raw)
To: andrew, hkallweit1, linux, davem, edumazet, kuba, pabeni, netdev
Cc: Jiawen Wu
PHY address and device address are passed in the wrong order.
Fixes: 4e4aafcddbbf ("net: mdio: Add dedicated C45 API to MDIO bus drivers")
Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
---
drivers/net/phy/mdio_bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
index 389f33a12534..8b3618d3da4a 100644
--- a/drivers/net/phy/mdio_bus.c
+++ b/drivers/net/phy/mdio_bus.c
@@ -1287,7 +1287,7 @@ EXPORT_SYMBOL_GPL(mdiobus_modify_changed);
* @mask: bit mask of bits to clear
* @set: bit mask of bits to set
*/
-int mdiobus_c45_modify_changed(struct mii_bus *bus, int devad, int addr,
+int mdiobus_c45_modify_changed(struct mii_bus *bus, int addr, int devad,
u32 regnum, u16 mask, u16 set)
{
int err;
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net] net: mdio: fix the wrong parameters
2023-06-19 9:49 [PATCH net] net: mdio: fix the wrong parameters Jiawen Wu
@ 2023-06-19 14:17 ` Andrew Lunn
2023-06-19 15:57 ` Russell King (Oracle)
2023-06-21 3:40 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Andrew Lunn @ 2023-06-19 14:17 UTC (permalink / raw)
To: Jiawen Wu; +Cc: hkallweit1, linux, davem, edumazet, kuba, pabeni, netdev
On Mon, Jun 19, 2023 at 05:49:48PM +0800, Jiawen Wu wrote:
> PHY address and device address are passed in the wrong order.
>
> Fixes: 4e4aafcddbbf ("net: mdio: Add dedicated C45 API to MDIO bus drivers")
> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
Thanks. I checked all the other c45 functions in this file. This
appears to be the only one i got wrong.
Cc: stable@vger.kernel.org
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] net: mdio: fix the wrong parameters
2023-06-19 9:49 [PATCH net] net: mdio: fix the wrong parameters Jiawen Wu
2023-06-19 14:17 ` Andrew Lunn
@ 2023-06-19 15:57 ` Russell King (Oracle)
2023-06-21 3:40 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Russell King (Oracle) @ 2023-06-19 15:57 UTC (permalink / raw)
To: Jiawen Wu; +Cc: andrew, hkallweit1, davem, edumazet, kuba, pabeni, netdev
On Mon, Jun 19, 2023 at 05:49:48PM +0800, Jiawen Wu wrote:
> PHY address and device address are passed in the wrong order.
>
> Fixes: 4e4aafcddbbf ("net: mdio: Add dedicated C45 API to MDIO bus drivers")
> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Thanks!
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] net: mdio: fix the wrong parameters
2023-06-19 9:49 [PATCH net] net: mdio: fix the wrong parameters Jiawen Wu
2023-06-19 14:17 ` Andrew Lunn
2023-06-19 15:57 ` Russell King (Oracle)
@ 2023-06-21 3:40 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-06-21 3:40 UTC (permalink / raw)
To: Jiawen Wu
Cc: andrew, hkallweit1, linux, davem, edumazet, kuba, pabeni, netdev
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 19 Jun 2023 17:49:48 +0800 you wrote:
> PHY address and device address are passed in the wrong order.
>
> Fixes: 4e4aafcddbbf ("net: mdio: Add dedicated C45 API to MDIO bus drivers")
> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
> ---
> drivers/net/phy/mdio_bus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- [net] net: mdio: fix the wrong parameters
https://git.kernel.org/netdev/net/c/408c090002c8
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-21 3:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-19 9:49 [PATCH net] net: mdio: fix the wrong parameters Jiawen Wu
2023-06-19 14:17 ` Andrew Lunn
2023-06-19 15:57 ` Russell King (Oracle)
2023-06-21 3:40 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.