All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Garry <john.garry@huawei.com>
To: Rob Herring <robh@kernel.org>, Will Deacon <will@kernel.org>,
	"Peter Zijlstra" <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	"Arnaldo Carvalho de Melo" <acme@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>
Cc: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>,
	<linux-perf-users@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v9] libperf: Add arm64 support to perf_mmap__read_self()
Date: Wed, 2 Feb 2022 10:33:13 +0000	[thread overview]
Message-ID: <ecbca50c-775b-e460-a6dd-488069c3f390@huawei.com> (raw)
In-Reply-To: <20220201214056.702854-1-robh@kernel.org>

On 01/02/2022 21:40, Rob Herring wrote:
> Add the arm64 variants for read_perf_counter() and read_timestamp().
> Unfortunately the counter number is encoded into the instruction, so the
> code is a bit verbose to enumerate all possible counters.
> 
> Tested-by: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
> Signed-off-by: Rob Herring <robh@kernel.org>

Ha, I was just looking at this same topic yesterday from an old patchset 
[0] and wasn't aware of this separate change.

Tested-by: John Garry <john.garry@huawei.com>

[0] https://lore.kernel.org/all/20210311000837.3630499-1-robh@kernel.org/

BTW, Documentation/arm64/perf.rst has a reference to a file which does 
not seem to exit:

.. _tools/perf/arch/arm64/tests/user-events.c:
 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/perf/arch/arm64/tests/user-events.c

Thanks,
john

  parent reply	other threads:[~2022-02-02 10:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-01 21:40 [PATCH v9] libperf: Add arm64 support to perf_mmap__read_self() Rob Herring
2022-02-01 23:59 ` Arnaldo Carvalho de Melo
2022-02-02 10:33 ` John Garry [this message]
2022-02-02 16:48 ` Jiri Olsa
2022-02-06 12:14   ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ecbca50c-775b-e460-a6dd-488069c3f390@huawei.com \
    --to=john.garry@huawei.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=m.mizuma@jp.fujitsu.com \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=robh@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.