Re: [Qemu-devel] [PATCH v14 09/21] qapi: permit auto-creating single element lists

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1044 bytes --]

On 09/30/2016 09:45 AM, Daniel P. Berrange wrote:
> When converting QemuOpts to a QObject, there is no information
> about compound types available, so when visiting a list, the
> corresponding QObject is not guaranteed to be a QList. We
> therefore need to be able to auto-create a single element QList
> from whatever type we find.
> 
> This mode should only be enabled if you have compatibility
> requirements for
> 
>    -arg foo=hello,foo=world
> 
> to be treated as equivalent to the preferred syntax:
> 
>    -arg foo.0=hello,foo.1=world
> 
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
>  include/qapi/qobject-input-visitor.h | 20 +++++++-
>  qapi/qobject-input-visitor.c         | 27 +++++++++--
>  tests/test-qobject-input-visitor.c   | 88 +++++++++++++++++++++++++++++++-----
>  3 files changed, 117 insertions(+), 18 deletions(-)
> 

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]