* [PATCH] skd: Uninitialized variable in skd_isr_completion_posted()
@ 2017-08-23 10:44 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2017-08-23 10:44 UTC (permalink / raw)
To: Bart Van Assche; +Cc: linux-block, kernel-janitors
Someone got too agressive about removing initializations and
accidentally removed the "rc = 0;" which is required.
Fixes: c830da8cbc7b ("skd: Remove superfluous initializations from skd_isr_completion_posted()")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c
index 9b99081a623c..35938ee0651a 100644
--- a/drivers/block/skd_main.c
+++ b/drivers/block/skd_main.c
@@ -1499,7 +1499,7 @@ static int skd_isr_completion_posted(struct skd_device *skdev,
u8 cmp_status;
u8 cmp_cycle;
u32 cmp_bytes;
- int rc;
+ int rc = 0;
int processed = 0;
lockdep_assert_held(&skdev->lock);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] skd: Uninitialized variable in skd_isr_completion_posted()
@ 2017-08-23 10:44 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2017-08-23 10:44 UTC (permalink / raw)
To: Bart Van Assche; +Cc: linux-block, kernel-janitors
Someone got too agressive about removing initializations and
accidentally removed the "rc = 0;" which is required.
Fixes: c830da8cbc7b ("skd: Remove superfluous initializations from skd_isr_completion_posted()")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c
index 9b99081a623c..35938ee0651a 100644
--- a/drivers/block/skd_main.c
+++ b/drivers/block/skd_main.c
@@ -1499,7 +1499,7 @@ static int skd_isr_completion_posted(struct skd_device *skdev,
u8 cmp_status;
u8 cmp_cycle;
u32 cmp_bytes;
- int rc;
+ int rc = 0;
int processed = 0;
lockdep_assert_held(&skdev->lock);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] skd: Uninitialized variable in skd_isr_completion_posted()
2017-08-23 10:44 ` Dan Carpenter
@ 2017-08-23 14:36 ` Jens Axboe
-1 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2017-08-23 14:36 UTC (permalink / raw)
To: Dan Carpenter, Bart Van Assche; +Cc: linux-block, kernel-janitors
On 08/23/2017 04:44 AM, Dan Carpenter wrote:
> Someone got too agressive about removing initializations and
> accidentally removed the "rc = 0;" which is required.
Thanks Dan, applied.
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] skd: Uninitialized variable in skd_isr_completion_posted()
@ 2017-08-23 14:36 ` Jens Axboe
0 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2017-08-23 14:36 UTC (permalink / raw)
To: Dan Carpenter, Bart Van Assche; +Cc: linux-block, kernel-janitors
On 08/23/2017 04:44 AM, Dan Carpenter wrote:
> Someone got too agressive about removing initializations and
> accidentally removed the "rc = 0;" which is required.
Thanks Dan, applied.
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-08-23 14:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-23 10:44 [PATCH] skd: Uninitialized variable in skd_isr_completion_posted() Dan Carpenter
2017-08-23 10:44 ` Dan Carpenter
2017-08-23 14:36 ` Jens Axboe
2017-08-23 14:36 ` Jens Axboe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.