* [Xen-devel] [PATCH] x86/p2m: p2m_flags_to_type() deals only with "unsigned int"
@ 2020-02-06 15:19 Jan Beulich
2020-02-06 15:53 ` Roger Pau Monné
2020-02-21 14:06 ` Andrew Cooper
0 siblings, 2 replies; 3+ messages in thread
From: Jan Beulich @ 2020-02-06 15:19 UTC (permalink / raw)
To: xen-devel; +Cc: George Dunlap, Andrew Cooper, Wei Liu, Roger Pau Monné
PTE flags, for now at least, get stored in "unsigned int". Hence there's
no need to widen the values to "unsigned long" before processing them.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/include/asm-x86/p2m.h
+++ b/xen/include/asm-x86/p2m.h
@@ -796,7 +796,7 @@ extern void audit_p2m(struct domain *d,
*/
/* Extract the type from the PTE flags that store it */
-static inline p2m_type_t p2m_flags_to_type(unsigned long flags)
+static inline p2m_type_t p2m_flags_to_type(unsigned int flags)
{
/* For AMD IOMMUs we need to use type 0 for plain RAM, but we need
* to make sure that an entirely empty PTE doesn't have RAM type */
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Xen-devel] [PATCH] x86/p2m: p2m_flags_to_type() deals only with "unsigned int"
2020-02-06 15:19 [Xen-devel] [PATCH] x86/p2m: p2m_flags_to_type() deals only with "unsigned int" Jan Beulich
@ 2020-02-06 15:53 ` Roger Pau Monné
2020-02-21 14:06 ` Andrew Cooper
1 sibling, 0 replies; 3+ messages in thread
From: Roger Pau Monné @ 2020-02-06 15:53 UTC (permalink / raw)
To: Jan Beulich; +Cc: George Dunlap, xen-devel, Wei Liu, Andrew Cooper
On Thu, Feb 06, 2020 at 04:19:14PM +0100, Jan Beulich wrote:
> PTE flags, for now at least, get stored in "unsigned int". Hence there's
> no need to widen the values to "unsigned long" before processing them.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
Thanks.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Xen-devel] [PATCH] x86/p2m: p2m_flags_to_type() deals only with "unsigned int"
2020-02-06 15:19 [Xen-devel] [PATCH] x86/p2m: p2m_flags_to_type() deals only with "unsigned int" Jan Beulich
2020-02-06 15:53 ` Roger Pau Monné
@ 2020-02-21 14:06 ` Andrew Cooper
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Cooper @ 2020-02-21 14:06 UTC (permalink / raw)
To: Jan Beulich, xen-devel; +Cc: George Dunlap, Wei Liu, Roger Pau Monné
On 06/02/2020 15:19, Jan Beulich wrote:
> PTE flags, for now at least, get stored in "unsigned int". Hence there's
> no need to widen the values to "unsigned long" before processing them.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-21 14:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-06 15:19 [Xen-devel] [PATCH] x86/p2m: p2m_flags_to_type() deals only with "unsigned int" Jan Beulich
2020-02-06 15:53 ` Roger Pau Monné
2020-02-21 14:06 ` Andrew Cooper
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.