* [PATCH] fs: Fix missing 'bit' in comment
@ 2020-03-12 7:40 Chucheng Luo
2020-03-12 10:40 ` Hans de Goede
0 siblings, 1 reply; 7+ messages in thread
From: Chucheng Luo @ 2020-03-12 7:40 UTC (permalink / raw)
To: Hans de Goede, linux-fsdevel, linux-kernel
Cc: wenhu.wang, trivial, Chucheng Luo
The missing word may make it hard for other developers to
understand it.
Signed-off-by: Chucheng Luo <luochucheng@vivo.com>
---
fs/vboxsf/dir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/vboxsf/dir.c b/fs/vboxsf/dir.c
index dd147b490982..be4f72625d36 100644
--- a/fs/vboxsf/dir.c
+++ b/fs/vboxsf/dir.c
@@ -134,7 +134,7 @@ static bool vboxsf_dir_emit(struct file *dir, struct dir_context *ctx)
d_type = vboxsf_get_d_type(info->info.attr.mode);
/*
- * On 32 bit systems pos is 64 signed, while ino is 32 bit
+ * On 32 bit systems pos is 64 bit signed, while ino is 32 bit
* unsigned so fake_ino may overflow, check for this.
*/
if ((ino_t)(ctx->pos + 1) != (u64)(ctx->pos + 1)) {
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] fs: Fix missing 'bit' in comment
2020-03-12 7:40 [PATCH] fs: Fix missing 'bit' in comment Chucheng Luo
@ 2020-03-12 10:40 ` Hans de Goede
2020-03-12 21:27 ` [PATCH] " Andreas Dilger
0 siblings, 1 reply; 7+ messages in thread
From: Hans de Goede @ 2020-03-12 10:40 UTC (permalink / raw)
To: Chucheng Luo, linux-fsdevel, linux-kernel; +Cc: wenhu.wang, trivial
Hi,
On 3/12/20 8:40 AM, Chucheng Luo wrote:
> The missing word may make it hard for other developers to
> understand it.
>
> Signed-off-by: Chucheng Luo <luochucheng@vivo.com>
Thanks for catching this:
Acked-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> fs/vboxsf/dir.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/vboxsf/dir.c b/fs/vboxsf/dir.c
> index dd147b490982..be4f72625d36 100644
> --- a/fs/vboxsf/dir.c
> +++ b/fs/vboxsf/dir.c
> @@ -134,7 +134,7 @@ static bool vboxsf_dir_emit(struct file *dir, struct dir_context *ctx)
> d_type = vboxsf_get_d_type(info->info.attr.mode);
>
> /*
> - * On 32 bit systems pos is 64 signed, while ino is 32 bit
> + * On 32 bit systems pos is 64 bit signed, while ino is 32 bit
> * unsigned so fake_ino may overflow, check for this.
> */
> if ((ino_t)(ctx->pos + 1) != (u64)(ctx->pos + 1)) {
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] Fix missing 'bit' in comment
2020-03-12 10:40 ` Hans de Goede
@ 2020-03-12 21:27 ` Andreas Dilger
2020-03-13 1:35 ` 罗楚成
0 siblings, 1 reply; 7+ messages in thread
From: Andreas Dilger @ 2020-03-12 21:27 UTC (permalink / raw)
To: Hans de Goede
Cc: Chucheng Luo, Linux FS Devel, linux-kernel, wenhu.wang, trivial
[-- Attachment #1: Type: text/plain, Size: 1256 bytes --]
On Mar 12, 2020, at 4:40 AM, Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi,
>
> On 3/12/20 8:40 AM, Chucheng Luo wrote:
>> The missing word may make it hard for other developers to
>> understand it.
>> Signed-off-by: Chucheng Luo <luochucheng@vivo.com>
>
> Thanks for catching this:
>
> Acked-by: Hans de Goede <hdegoede@redhat.com>
Not to nit-pick, but these should properly be written as "32-bit" and "64-bit".
That can be easily fixed in the patch before upstream submission.
Cheers, Andreas
> Regards,
>
> Hans
>
>
>> ---
>> fs/vboxsf/dir.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> diff --git a/fs/vboxsf/dir.c b/fs/vboxsf/dir.c
>> index dd147b490982..be4f72625d36 100644
>> --- a/fs/vboxsf/dir.c
>> +++ b/fs/vboxsf/dir.c
>> @@ -134,7 +134,7 @@ static bool vboxsf_dir_emit(struct file *dir, struct dir_context *ctx)
>> d_type = vboxsf_get_d_type(info->info.attr.mode);
>> /*
>> - * On 32 bit systems pos is 64 signed, while ino is 32 bit
>> + * On 32 bit systems pos is 64 bit signed, while ino is 32 bit
>> * unsigned so fake_ino may overflow, check for this.
>> */
>> if ((ino_t)(ctx->pos + 1) != (u64)(ctx->pos + 1)) {
>
Cheers, Andreas
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 873 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread* Re:Re: [PATCH] Fix missing 'bit' in comment
2020-03-12 21:27 ` [PATCH] " Andreas Dilger
@ 2020-03-13 1:35 ` 罗楚成
0 siblings, 0 replies; 7+ messages in thread
From: 罗楚成 @ 2020-03-13 1:35 UTC (permalink / raw)
To: Andreas Dilger
Cc: Hans de Goede, Linux FS Devel, linux-kernel, wenhu.wang, trivial
That sounds reasonable. I will submit a new patch based on '32-bit' and '64-bit'
From: Andreas Dilger <adilger@dilger.ca>
Date: 2020-03-13 05:27:48
To: Hans de Goede <hdegoede@redhat.com>
Cc: Chucheng Luo <luochucheng@vivo.com>,Linux FS Devel <linux-fsdevel@vger.kernel.org>,linux-kernel@vger.kernel.org,wenhu.wang@vivo.com,trivial@kernel.org
Subject: Re: [PATCH] Fix missing 'bit' in comment>On Mar 12, 2020, at 4:40 AM, Hans de Goede <hdegoede@redhat.com> wrote:
>>
>> Hi,
>>
>> On 3/12/20 8:40 AM, Chucheng Luo wrote:
>>> The missing word may make it hard for other developers to
>>> understand it.
>>> Signed-off-by: Chucheng Luo <luochucheng@vivo.com>
>>
>> Thanks for catching this:
>>
>> Acked-by: Hans de Goede <hdegoede@redhat.com>
>
>Not to nit-pick, but these should properly be written as "32-bit" and "64-bit".
>That can be easily fixed in the patch before upstream submission.
>
>Cheers, Andreas
>
>> Regards,
>>
>> Hans
>>
>>
>>> ---
>>> fs/vboxsf/dir.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>> diff --git a/fs/vboxsf/dir.c b/fs/vboxsf/dir.c
>>> index dd147b490982..be4f72625d36 100644
>>> --- a/fs/vboxsf/dir.c
>>> +++ b/fs/vboxsf/dir.c
>>> @@ -134,7 +134,7 @@ static bool vboxsf_dir_emit(struct file *dir, struct dir_context *ctx)
>>> d_type = vboxsf_get_d_type(info->info.attr.mode);
>>> /*
>>> - * On 32 bit systems pos is 64 signed, while ino is 32 bit
>>> + * On 32 bit systems pos is 64 bit signed, while ino is 32 bit
>>> * unsigned so fake_ino may overflow, check for this.
>>> */
>>> if ((ino_t)(ctx->pos + 1) != (u64)(ctx->pos + 1)) {
>>
>
>
>Cheers, Andreas
>
>
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] fs: Fix missing 'bit' in comment
@ 2020-03-13 1:46 Chucheng Luo
2020-03-13 10:45 ` Hans de Goede
0 siblings, 1 reply; 7+ messages in thread
From: Chucheng Luo @ 2020-03-13 1:46 UTC (permalink / raw)
To: Hans de Goede, linux-fsdevel, linux-kernel
Cc: wenhu.wang, trivial, Chucheng Luo
The missing word may make it hard for other developers to
understand it.
Signed-off-by: Chucheng Luo <luochucheng@vivo.com>
---
fs/vboxsf/dir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/vboxsf/dir.c b/fs/vboxsf/dir.c
index dd147b490982..4d569f14a8d8 100644
--- a/fs/vboxsf/dir.c
+++ b/fs/vboxsf/dir.c
@@ -134,7 +134,7 @@ static bool vboxsf_dir_emit(struct file *dir, struct dir_context *ctx)
d_type = vboxsf_get_d_type(info->info.attr.mode);
/*
- * On 32 bit systems pos is 64 signed, while ino is 32 bit
+ * On 32-bit systems pos is 64-bit signed, while ino is 32-bit
* unsigned so fake_ino may overflow, check for this.
*/
if ((ino_t)(ctx->pos + 1) != (u64)(ctx->pos + 1)) {
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] fs: Fix missing 'bit' in comment
2020-03-13 1:46 [PATCH] fs: " Chucheng Luo
@ 2020-03-13 10:45 ` Hans de Goede
0 siblings, 0 replies; 7+ messages in thread
From: Hans de Goede @ 2020-03-13 10:45 UTC (permalink / raw)
To: Chucheng Luo, linux-fsdevel, linux-kernel; +Cc: wenhu.wang, trivial
Hi,
On 3/13/20 2:46 AM, Chucheng Luo wrote:
> The missing word may make it hard for other developers to
> understand it.
>
> Signed-off-by: Chucheng Luo <luochucheng@vivo.com>
This new version also looks good to me:
Acked-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
p.s.
In the future please mark new versions as such by using e.g.:
git send-email --subject-prefix="PATCH v2" ...
Actually, it would be good to resend this patch (with my
Acked-by added to the commit msg) this way because now there
is no way for the fs maintainers to figure out which one
of the 2 patches you've send out to apply.
> ---
> fs/vboxsf/dir.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/vboxsf/dir.c b/fs/vboxsf/dir.c
> index dd147b490982..4d569f14a8d8 100644
> --- a/fs/vboxsf/dir.c
> +++ b/fs/vboxsf/dir.c
> @@ -134,7 +134,7 @@ static bool vboxsf_dir_emit(struct file *dir, struct dir_context *ctx)
> d_type = vboxsf_get_d_type(info->info.attr.mode);
>
> /*
> - * On 32 bit systems pos is 64 signed, while ino is 32 bit
> + * On 32-bit systems pos is 64-bit signed, while ino is 32-bit
> * unsigned so fake_ino may overflow, check for this.
> */
> if ((ino_t)(ctx->pos + 1) != (u64)(ctx->pos + 1)) {
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] fs: Fix missing 'bit' in comment
@ 2020-03-14 1:34 Chucheng Luo
0 siblings, 0 replies; 7+ messages in thread
From: Chucheng Luo @ 2020-03-14 1:34 UTC (permalink / raw)
To: Hans de Goede, linux-fsdevel, linux-kernel; +Cc: kernel, trivial, Chucheng Luo
The missing word may make it hard for other developers to
understand it.
Signed-off-by: Chucheng Luo <luochucheng@vivo.com>
Acked-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Andreas Dilger <adilger@dilger.ca>
---
fs/vboxsf/dir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/vboxsf/dir.c b/fs/vboxsf/dir.c
index dd147b490982..be4f72625d36 100644
--- a/fs/vboxsf/dir.c
+++ b/fs/vboxsf/dir.c
@@ -134,7 +134,7 @@ static bool vboxsf_dir_emit(struct file *dir, struct dir_context *ctx)
d_type = vboxsf_get_d_type(info->info.attr.mode);
/*
- * On 32 bit systems pos is 64 signed, while ino is 32 bit
+ * On 32 bit systems pos is 64 bit signed, while ino is 32 bit
* unsigned so fake_ino may overflow, check for this.
*/
if ((ino_t)(ctx->pos + 1) != (u64)(ctx->pos + 1)) {
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-03-14 1:34 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-12 7:40 [PATCH] fs: Fix missing 'bit' in comment Chucheng Luo
2020-03-12 10:40 ` Hans de Goede
2020-03-12 21:27 ` [PATCH] " Andreas Dilger
2020-03-13 1:35 ` 罗楚成
2020-03-13 1:46 [PATCH] fs: " Chucheng Luo
2020-03-13 10:45 ` Hans de Goede
2020-03-14 1:34 Chucheng Luo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.