* [PATCH] ARM: mvebu: kirkwood: remove error message when retrieving mac address
@ 2019-02-18 2:46 ` Chris Packham
0 siblings, 0 replies; 8+ messages in thread
From: Chris Packham @ 2019-02-18 2:46 UTC (permalink / raw)
To: andrew, jason, gregory.clement
Cc: linux-arm-kernel, linux-kernel, Chris Packham,
Sebastian Hesselbarth, Russell King
Kirkwood has always had the ability to retrieve the local-mac-address
from the hardware (usually this was configured by the bootloader). This
is particularly useful when dealing with a legacy non-DT aware
bootloader.
The "error" message just indicated that the board used an old bootloader
and in many cases users can't do anything about this. The message
probably should have been pr_info() to inform the user that the kernel
has been helpful but rather than than let's remove it entirely to make
the kernel less noisy.
Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---
arch/arm/mach-mvebu/kirkwood.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm/mach-mvebu/kirkwood.c b/arch/arm/mach-mvebu/kirkwood.c
index 0aa88105d46e..bf3ff0f580c2 100644
--- a/arch/arm/mach-mvebu/kirkwood.c
+++ b/arch/arm/mach-mvebu/kirkwood.c
@@ -107,8 +107,6 @@ static void __init kirkwood_dt_eth_fixup(void)
clk_prepare_enable(clk);
/* store MAC address register contents in local-mac-address */
- pr_err(FW_INFO "%pOF: local-mac-address is not set\n", np);
-
pmac = kzalloc(sizeof(*pmac) + 6, GFP_KERNEL);
if (!pmac)
goto eth_fixup_no_mem;
--
2.20.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] ARM: mvebu: kirkwood: remove error message when retrieving mac address
@ 2019-02-18 2:46 ` Chris Packham
0 siblings, 0 replies; 8+ messages in thread
From: Chris Packham @ 2019-02-18 2:46 UTC (permalink / raw)
To: andrew, jason, gregory.clement
Cc: Russell King, Chris Packham, linux-kernel, linux-arm-kernel,
Sebastian Hesselbarth
Kirkwood has always had the ability to retrieve the local-mac-address
from the hardware (usually this was configured by the bootloader). This
is particularly useful when dealing with a legacy non-DT aware
bootloader.
The "error" message just indicated that the board used an old bootloader
and in many cases users can't do anything about this. The message
probably should have been pr_info() to inform the user that the kernel
has been helpful but rather than than let's remove it entirely to make
the kernel less noisy.
Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---
arch/arm/mach-mvebu/kirkwood.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm/mach-mvebu/kirkwood.c b/arch/arm/mach-mvebu/kirkwood.c
index 0aa88105d46e..bf3ff0f580c2 100644
--- a/arch/arm/mach-mvebu/kirkwood.c
+++ b/arch/arm/mach-mvebu/kirkwood.c
@@ -107,8 +107,6 @@ static void __init kirkwood_dt_eth_fixup(void)
clk_prepare_enable(clk);
/* store MAC address register contents in local-mac-address */
- pr_err(FW_INFO "%pOF: local-mac-address is not set\n", np);
-
pmac = kzalloc(sizeof(*pmac) + 6, GFP_KERNEL);
if (!pmac)
goto eth_fixup_no_mem;
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: mvebu: kirkwood: remove error message when retrieving mac address
2019-02-18 2:46 ` Chris Packham
@ 2019-02-19 15:03 ` Gregory CLEMENT
-1 siblings, 0 replies; 8+ messages in thread
From: Gregory CLEMENT @ 2019-02-19 15:03 UTC (permalink / raw)
To: Chris Packham, andrew, jason
Cc: linux-arm-kernel, linux-kernel, Chris Packham,
Sebastian Hesselbarth, Russell King
Hi Chris,
On lun., févr. 18 2019, Chris Packham <chris.packham@alliedtelesis.co.nz> wrote:
> Kirkwood has always had the ability to retrieve the local-mac-address
> from the hardware (usually this was configured by the bootloader). This
> is particularly useful when dealing with a legacy non-DT aware
> bootloader.
>
> The "error" message just indicated that the board used an old bootloader
> and in many cases users can't do anything about this. The message
> probably should have been pr_info() to inform the user that the kernel
> has been helpful but rather than than let's remove it entirely to make
> the kernel less noisy.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
I'm OK with this patch, however as it is not a fix, it's too late for
5.1. I will apply it on mvebu/arm for 5.2 once 5.1-rc1 will be released.
Thanks,
gregory
> ---
> arch/arm/mach-mvebu/kirkwood.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm/mach-mvebu/kirkwood.c b/arch/arm/mach-mvebu/kirkwood.c
> index 0aa88105d46e..bf3ff0f580c2 100644
> --- a/arch/arm/mach-mvebu/kirkwood.c
> +++ b/arch/arm/mach-mvebu/kirkwood.c
> @@ -107,8 +107,6 @@ static void __init kirkwood_dt_eth_fixup(void)
> clk_prepare_enable(clk);
>
> /* store MAC address register contents in local-mac-address */
> - pr_err(FW_INFO "%pOF: local-mac-address is not set\n", np);
> -
> pmac = kzalloc(sizeof(*pmac) + 6, GFP_KERNEL);
> if (!pmac)
> goto eth_fixup_no_mem;
> --
> 2.20.1
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: mvebu: kirkwood: remove error message when retrieving mac address
@ 2019-02-19 15:03 ` Gregory CLEMENT
0 siblings, 0 replies; 8+ messages in thread
From: Gregory CLEMENT @ 2019-02-19 15:03 UTC (permalink / raw)
To: Chris Packham, andrew, jason
Cc: Russell King, Chris Packham, linux-kernel, linux-arm-kernel,
Sebastian Hesselbarth
Hi Chris,
On lun., févr. 18 2019, Chris Packham <chris.packham@alliedtelesis.co.nz> wrote:
> Kirkwood has always had the ability to retrieve the local-mac-address
> from the hardware (usually this was configured by the bootloader). This
> is particularly useful when dealing with a legacy non-DT aware
> bootloader.
>
> The "error" message just indicated that the board used an old bootloader
> and in many cases users can't do anything about this. The message
> probably should have been pr_info() to inform the user that the kernel
> has been helpful but rather than than let's remove it entirely to make
> the kernel less noisy.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
I'm OK with this patch, however as it is not a fix, it's too late for
5.1. I will apply it on mvebu/arm for 5.2 once 5.1-rc1 will be released.
Thanks,
gregory
> ---
> arch/arm/mach-mvebu/kirkwood.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm/mach-mvebu/kirkwood.c b/arch/arm/mach-mvebu/kirkwood.c
> index 0aa88105d46e..bf3ff0f580c2 100644
> --- a/arch/arm/mach-mvebu/kirkwood.c
> +++ b/arch/arm/mach-mvebu/kirkwood.c
> @@ -107,8 +107,6 @@ static void __init kirkwood_dt_eth_fixup(void)
> clk_prepare_enable(clk);
>
> /* store MAC address register contents in local-mac-address */
> - pr_err(FW_INFO "%pOF: local-mac-address is not set\n", np);
> -
> pmac = kzalloc(sizeof(*pmac) + 6, GFP_KERNEL);
> if (!pmac)
> goto eth_fixup_no_mem;
> --
> 2.20.1
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: mvebu: kirkwood: remove error message when retrieving mac address
2019-02-19 15:03 ` Gregory CLEMENT
@ 2019-02-19 20:00 ` Chris Packham
-1 siblings, 0 replies; 8+ messages in thread
From: Chris Packham @ 2019-02-19 20:00 UTC (permalink / raw)
To: Gregory CLEMENT, andrew, jason
Cc: linux-arm-kernel, linux-kernel, Sebastian Hesselbarth, Russell King
On 20/02/19 4:14 AM, Gregory CLEMENT wrote:
> Hi Chris,
>
> On lun., févr. 18 2019, Chris Packham <chris.packham@alliedtelesis.co.nz> wrote:
>
>> Kirkwood has always had the ability to retrieve the local-mac-address
>> from the hardware (usually this was configured by the bootloader). This
>> is particularly useful when dealing with a legacy non-DT aware
>> bootloader.
>>
>> The "error" message just indicated that the board used an old bootloader
>> and in many cases users can't do anything about this. The message
>> probably should have been pr_info() to inform the user that the kernel
>> has been helpful but rather than than let's remove it entirely to make
>> the kernel less noisy.
>>
>> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
>
> I'm OK with this patch, however as it is not a fix, it's too late for
> 5.1. I will apply it on mvebu/arm for 5.2 once 5.1-rc1 will be released.
>
No problem with that. We have a local fork I'll cherry pick it into once
it hits linux-mvebu.
> Thanks,
>
> gregory
>
>> ---
>> arch/arm/mach-mvebu/kirkwood.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/arch/arm/mach-mvebu/kirkwood.c b/arch/arm/mach-mvebu/kirkwood.c
>> index 0aa88105d46e..bf3ff0f580c2 100644
>> --- a/arch/arm/mach-mvebu/kirkwood.c
>> +++ b/arch/arm/mach-mvebu/kirkwood.c
>> @@ -107,8 +107,6 @@ static void __init kirkwood_dt_eth_fixup(void)
>> clk_prepare_enable(clk);
>>
>> /* store MAC address register contents in local-mac-address */
>> - pr_err(FW_INFO "%pOF: local-mac-address is not set\n", np);
>> -
>> pmac = kzalloc(sizeof(*pmac) + 6, GFP_KERNEL);
>> if (!pmac)
>> goto eth_fixup_no_mem;
>> --
>> 2.20.1
>>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: mvebu: kirkwood: remove error message when retrieving mac address
@ 2019-02-19 20:00 ` Chris Packham
0 siblings, 0 replies; 8+ messages in thread
From: Chris Packham @ 2019-02-19 20:00 UTC (permalink / raw)
To: Gregory CLEMENT, andrew, jason
Cc: Russell King, linux-kernel, linux-arm-kernel, Sebastian Hesselbarth
On 20/02/19 4:14 AM, Gregory CLEMENT wrote:
> Hi Chris,
>
> On lun., févr. 18 2019, Chris Packham <chris.packham@alliedtelesis.co.nz> wrote:
>
>> Kirkwood has always had the ability to retrieve the local-mac-address
>> from the hardware (usually this was configured by the bootloader). This
>> is particularly useful when dealing with a legacy non-DT aware
>> bootloader.
>>
>> The "error" message just indicated that the board used an old bootloader
>> and in many cases users can't do anything about this. The message
>> probably should have been pr_info() to inform the user that the kernel
>> has been helpful but rather than than let's remove it entirely to make
>> the kernel less noisy.
>>
>> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
>
> I'm OK with this patch, however as it is not a fix, it's too late for
> 5.1. I will apply it on mvebu/arm for 5.2 once 5.1-rc1 will be released.
>
No problem with that. We have a local fork I'll cherry pick it into once
it hits linux-mvebu.
> Thanks,
>
> gregory
>
>> ---
>> arch/arm/mach-mvebu/kirkwood.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/arch/arm/mach-mvebu/kirkwood.c b/arch/arm/mach-mvebu/kirkwood.c
>> index 0aa88105d46e..bf3ff0f580c2 100644
>> --- a/arch/arm/mach-mvebu/kirkwood.c
>> +++ b/arch/arm/mach-mvebu/kirkwood.c
>> @@ -107,8 +107,6 @@ static void __init kirkwood_dt_eth_fixup(void)
>> clk_prepare_enable(clk);
>>
>> /* store MAC address register contents in local-mac-address */
>> - pr_err(FW_INFO "%pOF: local-mac-address is not set\n", np);
>> -
>> pmac = kzalloc(sizeof(*pmac) + 6, GFP_KERNEL);
>> if (!pmac)
>> goto eth_fixup_no_mem;
>> --
>> 2.20.1
>>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: mvebu: kirkwood: remove error message when retrieving mac address
2019-02-19 20:00 ` Chris Packham
@ 2019-04-21 17:24 ` Gregory CLEMENT
-1 siblings, 0 replies; 8+ messages in thread
From: Gregory CLEMENT @ 2019-04-21 17:24 UTC (permalink / raw)
To: Chris Packham, andrew, jason
Cc: linux-arm-kernel, linux-kernel, Sebastian Hesselbarth, Russell King
Hi Chris,
> On 20/02/19 4:14 AM, Gregory CLEMENT wrote:
>> Hi Chris,
>>
>> On lun., févr. 18 2019, Chris Packham <chris.packham@alliedtelesis.co.nz> wrote:
>>
>>> Kirkwood has always had the ability to retrieve the local-mac-address
>>> from the hardware (usually this was configured by the bootloader). This
>>> is particularly useful when dealing with a legacy non-DT aware
>>> bootloader.
>>>
>>> The "error" message just indicated that the board used an old bootloader
>>> and in many cases users can't do anything about this. The message
>>> probably should have been pr_info() to inform the user that the kernel
>>> has been helpful but rather than than let's remove it entirely to make
>>> the kernel less noisy.
>>>
>>> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
>>
>> I'm OK with this patch, however as it is not a fix, it's too late for
>> 5.1. I will apply it on mvebu/arm for 5.2 once 5.1-rc1 will be released.
>>
>
> No problem with that. We have a local fork I'll cherry pick it into once
> it hits linux-mvebu.
>
Applied on mvebu/arm
Thanks,
Gregory
>> Thanks,
>>
>> gregory
>>
>>> ---
>>> arch/arm/mach-mvebu/kirkwood.c | 2 --
>>> 1 file changed, 2 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-mvebu/kirkwood.c b/arch/arm/mach-mvebu/kirkwood.c
>>> index 0aa88105d46e..bf3ff0f580c2 100644
>>> --- a/arch/arm/mach-mvebu/kirkwood.c
>>> +++ b/arch/arm/mach-mvebu/kirkwood.c
>>> @@ -107,8 +107,6 @@ static void __init kirkwood_dt_eth_fixup(void)
>>> clk_prepare_enable(clk);
>>>
>>> /* store MAC address register contents in local-mac-address */
>>> - pr_err(FW_INFO "%pOF: local-mac-address is not set\n", np);
>>> -
>>> pmac = kzalloc(sizeof(*pmac) + 6, GFP_KERNEL);
>>> if (!pmac)
>>> goto eth_fixup_no_mem;
>>> --
>>> 2.20.1
>>>
>>
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: mvebu: kirkwood: remove error message when retrieving mac address
@ 2019-04-21 17:24 ` Gregory CLEMENT
0 siblings, 0 replies; 8+ messages in thread
From: Gregory CLEMENT @ 2019-04-21 17:24 UTC (permalink / raw)
To: Chris Packham, andrew, jason
Cc: Russell King, linux-kernel, linux-arm-kernel, Sebastian Hesselbarth
Hi Chris,
> On 20/02/19 4:14 AM, Gregory CLEMENT wrote:
>> Hi Chris,
>>
>> On lun., févr. 18 2019, Chris Packham <chris.packham@alliedtelesis.co.nz> wrote:
>>
>>> Kirkwood has always had the ability to retrieve the local-mac-address
>>> from the hardware (usually this was configured by the bootloader). This
>>> is particularly useful when dealing with a legacy non-DT aware
>>> bootloader.
>>>
>>> The "error" message just indicated that the board used an old bootloader
>>> and in many cases users can't do anything about this. The message
>>> probably should have been pr_info() to inform the user that the kernel
>>> has been helpful but rather than than let's remove it entirely to make
>>> the kernel less noisy.
>>>
>>> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
>>
>> I'm OK with this patch, however as it is not a fix, it's too late for
>> 5.1. I will apply it on mvebu/arm for 5.2 once 5.1-rc1 will be released.
>>
>
> No problem with that. We have a local fork I'll cherry pick it into once
> it hits linux-mvebu.
>
Applied on mvebu/arm
Thanks,
Gregory
>> Thanks,
>>
>> gregory
>>
>>> ---
>>> arch/arm/mach-mvebu/kirkwood.c | 2 --
>>> 1 file changed, 2 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-mvebu/kirkwood.c b/arch/arm/mach-mvebu/kirkwood.c
>>> index 0aa88105d46e..bf3ff0f580c2 100644
>>> --- a/arch/arm/mach-mvebu/kirkwood.c
>>> +++ b/arch/arm/mach-mvebu/kirkwood.c
>>> @@ -107,8 +107,6 @@ static void __init kirkwood_dt_eth_fixup(void)
>>> clk_prepare_enable(clk);
>>>
>>> /* store MAC address register contents in local-mac-address */
>>> - pr_err(FW_INFO "%pOF: local-mac-address is not set\n", np);
>>> -
>>> pmac = kzalloc(sizeof(*pmac) + 6, GFP_KERNEL);
>>> if (!pmac)
>>> goto eth_fixup_no_mem;
>>> --
>>> 2.20.1
>>>
>>
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-04-21 17:25 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-18 2:46 [PATCH] ARM: mvebu: kirkwood: remove error message when retrieving mac address Chris Packham
2019-02-18 2:46 ` Chris Packham
2019-02-19 15:03 ` Gregory CLEMENT
2019-02-19 15:03 ` Gregory CLEMENT
2019-02-19 20:00 ` Chris Packham
2019-02-19 20:00 ` Chris Packham
2019-04-21 17:24 ` Gregory CLEMENT
2019-04-21 17:24 ` Gregory CLEMENT
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.