From: Ravi Gunasekaran <r-gunasekaran@ti.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <linux-omap@vger.kernel.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <kishon@ti.com>,
<vigneshr@ti.com>
Subject: Re: [PATCH v2 net-next] net: ethernet: ti: davinci_mdio: Add workaround for errata i2329
Date: Fri, 12 Aug 2022 10:06:05 +0530 [thread overview]
Message-ID: <ed3554bc-af62-78ce-a3eb-ff5f27ade6a2@ti.com> (raw)
In-Reply-To: <YvT8ovgHz2j7yOQP@lunn.ch>
>> There is atleast one device sh_eth, which is not configured for autosuspend
>> but uses the bit bang core in sh_mdiobb_read() and invokes regular runtime
>> PM functions.
>
> And that is the point of moving it into the core. It would of just
> worked for you.
>
> If you don't feel comfortable with making this unconditional, please
> put runtime pm enabled version of mdiobb_read/mdiobb_write() in the
> core and swap sh_eth and any other drivers to using them.
>
sh_eth is not configured for autosuspend and uses only pm_runtime_put().
davinci_mdio is configured for autosuspend and it must invoke
pm_runtime_mark_last_busy() before calling pm_runtime_put_autosuspend().
So it looks like, there needs to be a runtime PM version of
mdiobb_read/mdiobb_write() for each pm_runtime_put_*(). As of now, it's
only sh_eth which is currently using runtime PM and davinci_mdio would
be the next one. So at least in this case, two variants of
mdiobb_read/mdiobb_write() could be added at the moment. By checking
against the dev->power.use_autosuspend flag, it is possible to support
both via a single version.
That being said, I'm quite inclined towards the existing implementation,
where drivers can have wrappers written around
mdiobb_read/mdiobb_write(). But I might be failing to see the broader
picture. If having multiple runtime PM versions of
mdiobb_read/mdiobb_write() benefits many other future drivers, then I
will go ahead and add the variant(s) in the bitbang core.
Please provide your views on this. Your inputs on the next course of
action would be helpful.
--
Regards,
Ravi
WARNING: multiple messages have this Message-ID (diff)
From: Ravi Gunasekaran <r-gunasekaran@ti.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <linux-omap@vger.kernel.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <kishon@ti.com>,
<vigneshr@ti.com>
Subject: Re: [PATCH v2 net-next] net: ethernet: ti: davinci_mdio: Add workaround for errata i2329
Date: Fri, 12 Aug 2022 10:06:05 +0530 [thread overview]
Message-ID: <ed3554bc-af62-78ce-a3eb-ff5f27ade6a2@ti.com> (raw)
In-Reply-To: <YvT8ovgHz2j7yOQP@lunn.ch>
>> There is atleast one device sh_eth, which is not configured for autosuspend
>> but uses the bit bang core in sh_mdiobb_read() and invokes regular runtime
>> PM functions.
>
> And that is the point of moving it into the core. It would of just
> worked for you.
>
> If you don't feel comfortable with making this unconditional, please
> put runtime pm enabled version of mdiobb_read/mdiobb_write() in the
> core and swap sh_eth and any other drivers to using them.
>
sh_eth is not configured for autosuspend and uses only pm_runtime_put().
davinci_mdio is configured for autosuspend and it must invoke
pm_runtime_mark_last_busy() before calling pm_runtime_put_autosuspend().
So it looks like, there needs to be a runtime PM version of
mdiobb_read/mdiobb_write() for each pm_runtime_put_*(). As of now, it's
only sh_eth which is currently using runtime PM and davinci_mdio would
be the next one. So at least in this case, two variants of
mdiobb_read/mdiobb_write() could be added at the moment. By checking
against the dev->power.use_autosuspend flag, it is possible to support
both via a single version.
That being said, I'm quite inclined towards the existing implementation,
where drivers can have wrappers written around
mdiobb_read/mdiobb_write(). But I might be failing to see the broader
picture. If having multiple runtime PM versions of
mdiobb_read/mdiobb_write() benefits many other future drivers, then I
will go ahead and add the variant(s) in the bitbang core.
Please provide your views on this. Your inputs on the next course of
action would be helpful.
--
Regards,
Ravi
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-08-12 4:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 11:13 [PATCH v2 net-next] net: ethernet: ti: davinci_mdio: Add workaround for errata i2329 Ravi Gunasekaran
2022-08-10 11:13 ` Ravi Gunasekaran
2022-08-11 0:30 ` Andrew Lunn
2022-08-11 0:30 ` Andrew Lunn
2022-08-11 7:00 ` Ravi Gunasekaran
2022-08-11 7:00 ` Ravi Gunasekaran
2022-08-11 12:57 ` Andrew Lunn
2022-08-11 12:57 ` Andrew Lunn
2022-08-12 4:36 ` Ravi Gunasekaran [this message]
2022-08-12 4:36 ` Ravi Gunasekaran
2022-08-12 15:54 ` Andrew Lunn
2022-08-12 15:54 ` Andrew Lunn
2022-08-16 4:26 ` Ravi Gunasekaran
2022-08-16 4:26 ` Ravi Gunasekaran
2022-08-13 0:57 ` kernel test robot
2022-08-13 0:57 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed3554bc-af62-78ce-a3eb-ff5f27ade6a2@ti.com \
--to=r-gunasekaran@ti.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kishon@ti.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.