* [PATCH] Headset fixup for System76 Gazelle (gaze14)
@ 2019-05-03 16:00 Jeremy Soller
2019-05-07 21:11 ` Jeremy Soller
0 siblings, 1 reply; 6+ messages in thread
From: Jeremy Soller @ 2019-05-03 16:00 UTC (permalink / raw)
To: alsa-devel
On the System76 Gazelle (gaze14), there is a headset microphone input attached to 0x1a that does not have a jack detect. In order to get it working, the pin configuration needs to be set correctly, and the ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC fixup needs to be applied. This is identical to the patch already applied for the System76 Darter Pro (darp5).
Signed-off-by: Jeremy Soller <jeremy@system76.com>
---
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index f5b510f119ed..4ea3affad617 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6931,6 +6931,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x1462, 0xb120, "MSI Cubi MS-B120", ALC283_FIXUP_HEADSET_MIC),
SND_PCI_QUIRK(0x1462, 0xb171, "Cubi N 8GL (MS-B171)", ALC283_FIXUP_HEADSET_MIC),
SND_PCI_QUIRK(0x1558, 0x1325, "System76 Darter Pro (darp5)", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
+ SND_PCI_QUIRK(0x1558, 0x8550, "System76 Gazelle (gaze14)", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x17aa, 0x1036, "Lenovo P520", ALC233_FIXUP_LENOVO_MULTI_CODECS),
SND_PCI_QUIRK(0x17aa, 0x20f2, "Thinkpad SL410/510", ALC269_FIXUP_SKU_IGNORE),
SND_PCI_QUIRK(0x17aa, 0x215e, "Thinkpad L512", ALC269_FIXUP_SKU_IGNORE),
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Headset fixup for System76 Gazelle (gaze14)
2019-05-03 16:00 [PATCH] Headset fixup for System76 Gazelle (gaze14) Jeremy Soller
@ 2019-05-07 21:11 ` Jeremy Soller
2019-05-08 5:34 ` Takashi Iwai
0 siblings, 1 reply; 6+ messages in thread
From: Jeremy Soller @ 2019-05-07 21:11 UTC (permalink / raw)
To: alsa-devel
Updated patch, adding second PCI ID:
On the System76 Gazelle (gaze14), there is a headset microphone input attached to 0x1a that does not have a jack detect. In order to get it working, the pin configuration needs to be set correctly, and the ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC fixup needs to be applied. This is identical to the patch already applied for the System76 Darter Pro (darp5).
Signed-off-by: Jeremy Soller <jeremy@system76.com>
---
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index f5b510f119ed..4ea3affad617 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6931,6 +6931,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x1462, 0xb120, "MSI Cubi MS-B120", ALC283_FIXUP_HEADSET_MIC),
SND_PCI_QUIRK(0x1462, 0xb171, "Cubi N 8GL (MS-B171)", ALC283_FIXUP_HEADSET_MIC),
SND_PCI_QUIRK(0x1558, 0x1325, "System76 Darter Pro (darp5)", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
+ SND_PCI_QUIRK(0x1558, 0x8550, "System76 Gazelle (gaze14)", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
+ SND_PCI_QUIRK(0x1558, 0x8560, "System76 Gazelle (gaze14)", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x17aa, 0x1036, "Lenovo P520", ALC233_FIXUP_LENOVO_MULTI_CODECS),
SND_PCI_QUIRK(0x17aa, 0x20f2, "Thinkpad SL410/510", ALC269_FIXUP_SKU_IGNORE),
SND_PCI_QUIRK(0x17aa, 0x215e, "Thinkpad L512", ALC269_FIXUP_SKU_IGNORE),
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Headset fixup for System76 Gazelle (gaze14)
2019-05-07 21:11 ` Jeremy Soller
@ 2019-05-08 5:34 ` Takashi Iwai
0 siblings, 0 replies; 6+ messages in thread
From: Takashi Iwai @ 2019-05-08 5:34 UTC (permalink / raw)
To: Jeremy Soller; +Cc: alsa-devel
On Tue, 07 May 2019 23:11:08 +0200,
Jeremy Soller wrote:
>
> Updated patch, adding second PCI ID:
>
> On the System76 Gazelle (gaze14), there is a headset microphone input attached to 0x1a that does not have a jack detect. In order to get it working, the pin configuration needs to be set correctly, and the ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC fixup needs to be applied. This is identical to the patch already applied for the System76 Darter Pro (darp5).
>
> Signed-off-by: Jeremy Soller <jeremy@system76.com>
Applied now, thanks.
Takashi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Headset fixup for System76 Gazelle (gaze14)
2019-05-10 14:51 ` Takashi Iwai
@ 2019-05-10 16:21 ` Jeremy Soller
0 siblings, 0 replies; 6+ messages in thread
From: Jeremy Soller @ 2019-05-10 16:21 UTC (permalink / raw)
To: Takashi Iwai; +Cc: alsa-devel
Thanks for the quick merge!
--
Jeremy Soller
System76
Engineering Manager
jeremy@system76.com
On Fri, May 10, 2019, at 8:51 AM, Takashi Iwai wrote:
> On Fri, 10 May 2019 16:15:07 +0200,
> Jeremy Soller wrote:
> >
> > A mistake was made in the identification of the four variants of the System76
> > Gazelle (gaze14). This patch corrects the PCI ID of the 17-inch, GTX 1660 Ti
> > variant from 0x8560 to 0x8551. This patch also adds the correct fixups for the
> > 15-inch and 17-inch GTX 1650 variants with PCI IDs 0x8560 and 0x8561.
> >
> > Tests were done on all four variants ensuring full audio capability.
> >
> > Signed-off-by: Jeremy Soller <jeremy@system76.com>
>
> Applied now (with proper Fixes tag). Thanks.
>
>
> Takashi
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Headset fixup for System76 Gazelle (gaze14)
2019-05-10 14:15 Jeremy Soller
@ 2019-05-10 14:51 ` Takashi Iwai
2019-05-10 16:21 ` Jeremy Soller
0 siblings, 1 reply; 6+ messages in thread
From: Takashi Iwai @ 2019-05-10 14:51 UTC (permalink / raw)
To: Jeremy Soller; +Cc: alsa-devel
On Fri, 10 May 2019 16:15:07 +0200,
Jeremy Soller wrote:
>
> A mistake was made in the identification of the four variants of the System76
> Gazelle (gaze14). This patch corrects the PCI ID of the 17-inch, GTX 1660 Ti
> variant from 0x8560 to 0x8551. This patch also adds the correct fixups for the
> 15-inch and 17-inch GTX 1650 variants with PCI IDs 0x8560 and 0x8561.
>
> Tests were done on all four variants ensuring full audio capability.
>
> Signed-off-by: Jeremy Soller <jeremy@system76.com>
Applied now (with proper Fixes tag). Thanks.
Takashi
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] Headset fixup for System76 Gazelle (gaze14)
@ 2019-05-10 14:15 Jeremy Soller
2019-05-10 14:51 ` Takashi Iwai
0 siblings, 1 reply; 6+ messages in thread
From: Jeremy Soller @ 2019-05-10 14:15 UTC (permalink / raw)
To: alsa-devel
A mistake was made in the identification of the four variants of the System76
Gazelle (gaze14). This patch corrects the PCI ID of the 17-inch, GTX 1660 Ti
variant from 0x8560 to 0x8551. This patch also adds the correct fixups for the
15-inch and 17-inch GTX 1650 variants with PCI IDs 0x8560 and 0x8561.
Tests were done on all four variants ensuring full audio capability.
Signed-off-by: Jeremy Soller <jeremy@system76.com>
---
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index b3712d87e98b..3e790b49c1c0 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6901,7 +6901,9 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x1462, 0xb171, "Cubi N 8GL (MS-B171)", ALC283_FIXUP_HEADSET_MIC),
SND_PCI_QUIRK(0x1558, 0x1325, "System76 Darter Pro (darp5)", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x1558, 0x8550, "System76 Gazelle (gaze14)", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
- SND_PCI_QUIRK(0x1558, 0x8560, "System76 Gazelle (gaze14)", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
+ SND_PCI_QUIRK(0x1558, 0x8551, "System76 Gazelle (gaze14)", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
+ SND_PCI_QUIRK(0x1558, 0x8560, "System76 Gazelle (gaze14)", ALC269_FIXUP_HEADSET_MIC),
+ SND_PCI_QUIRK(0x1558, 0x8561, "System76 Gazelle (gaze14)", ALC269_FIXUP_HEADSET_MIC),
SND_PCI_QUIRK(0x17aa, 0x1036, "Lenovo P520", ALC233_FIXUP_LENOVO_MULTI_CODECS),
SND_PCI_QUIRK(0x17aa, 0x20f2, "Thinkpad SL410/510", ALC269_FIXUP_SKU_IGNORE),
SND_PCI_QUIRK(0x17aa, 0x215e, "Thinkpad L512", ALC269_FIXUP_SKU_IGNORE),
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-05-10 16:21 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-03 16:00 [PATCH] Headset fixup for System76 Gazelle (gaze14) Jeremy Soller
2019-05-07 21:11 ` Jeremy Soller
2019-05-08 5:34 ` Takashi Iwai
2019-05-10 14:15 Jeremy Soller
2019-05-10 14:51 ` Takashi Iwai
2019-05-10 16:21 ` Jeremy Soller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.