All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Mike Rapoport <rppt@kernel.org>, linux-arm-kernel@lists.infradead.org
Cc: Anshuman Khandual <anshuman.khandual@arm.com>,
	Ard Biesheuvel <ardb@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Marc Zyngier <maz@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Mike Rapoport <rppt@linux.ibm.com>, Will Deacon <will@kernel.org>,
	kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Subject: Re: [PATCH v1 2/4] memblock: update initialization of reserved pages
Date: Tue, 20 Apr 2021 15:56:28 +0200	[thread overview]
Message-ID: <ed8f10a0-9b68-1d12-0305-90fd378af6b9@redhat.com> (raw)
In-Reply-To: <20210420090925.7457-3-rppt@kernel.org>

On 20.04.21 11:09, Mike Rapoport wrote:
> From: Mike Rapoport <rppt@linux.ibm.com>
> 
> The struct pages representing a reserved memory region are initialized
> using reserve_bootmem_range() function. This function is called for each
> reserved region just before the memory is freed from memblock to the buddy
> page allocator.
> 
> The struct pages for MEMBLOCK_NOMAP regions are kept with the default
> values set by the memory map initialization which makes it necessary to
> have a special treatment for such pages in pfn_valid() and
> pfn_valid_within().

Just a general question while thinking about it:

Would we right now initialize the memmap of these pages already via 
memmap_init_zone()->memmap_init_range()? (IOW, not marking the 
PageReserved?)

-- 
Thanks,

David / dhildenb


WARNING: multiple messages have this Message-ID (diff)
From: David Hildenbrand <david@redhat.com>
To: Mike Rapoport <rppt@kernel.org>, linux-arm-kernel@lists.infradead.org
Cc: Anshuman Khandual <anshuman.khandual@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	linux-kernel@vger.kernel.org, Mike Rapoport <rppt@linux.ibm.com>,
	linux-mm@kvack.org, kvmarm@lists.cs.columbia.edu,
	Marc Zyngier <maz@kernel.org>, Will Deacon <will@kernel.org>
Subject: Re: [PATCH v1 2/4] memblock: update initialization of reserved pages
Date: Tue, 20 Apr 2021 15:56:28 +0200	[thread overview]
Message-ID: <ed8f10a0-9b68-1d12-0305-90fd378af6b9@redhat.com> (raw)
In-Reply-To: <20210420090925.7457-3-rppt@kernel.org>

On 20.04.21 11:09, Mike Rapoport wrote:
> From: Mike Rapoport <rppt@linux.ibm.com>
> 
> The struct pages representing a reserved memory region are initialized
> using reserve_bootmem_range() function. This function is called for each
> reserved region just before the memory is freed from memblock to the buddy
> page allocator.
> 
> The struct pages for MEMBLOCK_NOMAP regions are kept with the default
> values set by the memory map initialization which makes it necessary to
> have a special treatment for such pages in pfn_valid() and
> pfn_valid_within().

Just a general question while thinking about it:

Would we right now initialize the memmap of these pages already via 
memmap_init_zone()->memmap_init_range()? (IOW, not marking the 
PageReserved?)

-- 
Thanks,

David / dhildenb

_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

WARNING: multiple messages have this Message-ID (diff)
From: David Hildenbrand <david@redhat.com>
To: Mike Rapoport <rppt@kernel.org>, linux-arm-kernel@lists.infradead.org
Cc: Anshuman Khandual <anshuman.khandual@arm.com>,
	Ard Biesheuvel <ardb@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Marc Zyngier <maz@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Mike Rapoport <rppt@linux.ibm.com>, Will Deacon <will@kernel.org>,
	kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Subject: Re: [PATCH v1 2/4] memblock: update initialization of reserved pages
Date: Tue, 20 Apr 2021 15:56:28 +0200	[thread overview]
Message-ID: <ed8f10a0-9b68-1d12-0305-90fd378af6b9@redhat.com> (raw)
In-Reply-To: <20210420090925.7457-3-rppt@kernel.org>

On 20.04.21 11:09, Mike Rapoport wrote:
> From: Mike Rapoport <rppt@linux.ibm.com>
> 
> The struct pages representing a reserved memory region are initialized
> using reserve_bootmem_range() function. This function is called for each
> reserved region just before the memory is freed from memblock to the buddy
> page allocator.
> 
> The struct pages for MEMBLOCK_NOMAP regions are kept with the default
> values set by the memory map initialization which makes it necessary to
> have a special treatment for such pages in pfn_valid() and
> pfn_valid_within().

Just a general question while thinking about it:

Would we right now initialize the memmap of these pages already via 
memmap_init_zone()->memmap_init_range()? (IOW, not marking the 
PageReserved?)

-- 
Thanks,

David / dhildenb


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-04-20 13:56 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-20  9:09 [PATCH v1 0/4] arm64: drop pfn_valid_within() and simplify pfn_valid() Mike Rapoport
2021-04-20  9:09 ` Mike Rapoport
2021-04-20  9:09 ` Mike Rapoport
2021-04-20  9:09 ` [PATCH v1 1/4] include/linux/mmzone.h: add documentation for pfn_valid() Mike Rapoport
2021-04-20  9:09   ` Mike Rapoport
2021-04-20  9:09   ` Mike Rapoport
2021-04-20  9:22   ` David Hildenbrand
2021-04-20  9:22     ` David Hildenbrand
2021-04-20  9:22     ` David Hildenbrand
2021-04-20 12:57     ` Mike Rapoport
2021-04-20 12:57       ` Mike Rapoport
2021-04-20 12:57       ` Mike Rapoport
2021-04-20 12:58       ` David Hildenbrand
2021-04-20 12:58         ` David Hildenbrand
2021-04-20 12:58         ` David Hildenbrand
2021-04-20  9:09 ` [PATCH v1 2/4] memblock: update initialization of reserved pages Mike Rapoport
2021-04-20  9:09   ` Mike Rapoport
2021-04-20  9:09   ` Mike Rapoport
2021-04-20 13:56   ` David Hildenbrand [this message]
2021-04-20 13:56     ` David Hildenbrand
2021-04-20 13:56     ` David Hildenbrand
2021-04-20 15:03     ` Mike Rapoport
2021-04-20 15:03       ` Mike Rapoport
2021-04-20 15:03       ` Mike Rapoport
2021-04-20 15:18       ` David Hildenbrand
2021-04-20 15:18         ` David Hildenbrand
2021-04-20 15:18         ` David Hildenbrand
2021-04-20 15:25         ` Mike Rapoport
2021-04-20 15:25           ` Mike Rapoport
2021-04-20 15:25           ` Mike Rapoport
2021-04-20  9:09 ` [PATCH v1 3/4] arm64: decouple check whether pfn is in linear map from pfn_valid() Mike Rapoport
2021-04-20  9:09   ` Mike Rapoport
2021-04-20  9:09   ` Mike Rapoport
2021-04-20 15:57   ` David Hildenbrand
2021-04-20 15:57     ` David Hildenbrand
2021-04-20 15:57     ` David Hildenbrand
2021-04-21  5:32     ` Mike Rapoport
2021-04-21  5:32       ` Mike Rapoport
2021-04-21  5:32       ` Mike Rapoport
2021-04-20  9:09 ` [PATCH v1 4/4] arm64: drop pfn_valid_within() and simplify pfn_valid() Mike Rapoport
2021-04-20  9:09   ` Mike Rapoport
2021-04-20  9:09   ` Mike Rapoport
2021-04-20 16:00   ` David Hildenbrand
2021-04-20 16:00     ` David Hildenbrand
2021-04-20 16:00     ` David Hildenbrand
2021-04-21  5:52     ` Mike Rapoport
2021-04-21  5:52       ` Mike Rapoport
2021-04-21  5:52       ` Mike Rapoport

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ed8f10a0-9b68-1d12-0305-90fd378af6b9@redhat.com \
    --to=david@redhat.com \
    --cc=anshuman.khandual@arm.com \
    --cc=ardb@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mark.rutland@arm.com \
    --cc=maz@kernel.org \
    --cc=rppt@kernel.org \
    --cc=rppt@linux.ibm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.