All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jesse Taube <mr.bossman075@gmail.com>, linux-imx@nxp.com
Cc: robh+dt@kernel.org, mturquette@baylibre.com, sboyd@kernel.org,
	shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, festevam@gmail.com, aisheng.dong@nxp.com,
	stefan@agner.ch, linus.walleij@linaro.org,
	daniel.lezcano@linaro.org, tglx@linutronix.de, arnd@arndb.de,
	olof@lixom.net, soc@kernel.org, linux@armlinux.org.uk,
	abel.vesa@nxp.com, dev@lynxeye.de, marcel.ziswiler@toradex.com,
	tharvey@gateworks.com, leoyang.li@nxp.com,
	sebastian.reichel@collabora.com, cniedermaier@dh-electronics.com,
	clin@suse.com, giulio.benetti@benettiengineering.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-gpio@vger.kernel.org
Subject: Re: [PATCH v1 02/12] dt-bindings: timer: gpt: Add i.MXRT compatible Documentation
Date: Sun, 27 Mar 2022 21:06:29 +0200	[thread overview]
Message-ID: <edc4011d-5bfe-8ec5-e76b-61952cb3b9eb@kernel.org> (raw)
In-Reply-To: <20220326144313.673549-3-Mr.Bossman075@gmail.com>

On 26/03/2022 15:43, Jesse Taube wrote:
> Both the i.MXRT1170 and 1050 have the same GPT timer as "fsl,imx6dl-gpt"
> Add i.MXRT to the compatible list.
> 
> Signed-off-by: Jesse Taube <Mr.Bossman075@gmail.com>
> ---
>  Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> index a4f51f46b7a1..716c6afcca1f 100644
> --- a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> +++ b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> @@ -31,6 +31,8 @@ properties:
>            - enum:
>                - fsl,imx6sl-gpt
>                - fsl,imx6sx-gpt
> +              - fsl,imxrt1050-gpt
> +              - fsl,imxrt1170-gpt
>            - const: fsl,imx6dl-gpt

This looks ok, but your usage looks wrong. Did you test your DTS with
dtbs_check?

For the bindings only change:
Acked-by: Krzysztof Kozlowski <krzk@kernel.org>


Best regards,
Krzysztof

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jesse Taube <mr.bossman075@gmail.com>, linux-imx@nxp.com
Cc: robh+dt@kernel.org, mturquette@baylibre.com, sboyd@kernel.org,
	shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, festevam@gmail.com, aisheng.dong@nxp.com,
	stefan@agner.ch, linus.walleij@linaro.org,
	daniel.lezcano@linaro.org, tglx@linutronix.de, arnd@arndb.de,
	olof@lixom.net, soc@kernel.org, linux@armlinux.org.uk,
	abel.vesa@nxp.com, dev@lynxeye.de, marcel.ziswiler@toradex.com,
	tharvey@gateworks.com, leoyang.li@nxp.com,
	sebastian.reichel@collabora.com, cniedermaier@dh-electronics.com,
	clin@suse.com, giulio.benetti@benettiengineering.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-gpio@vger.kernel.org
Subject: Re: [PATCH v1 02/12] dt-bindings: timer: gpt: Add i.MXRT compatible Documentation
Date: Sun, 27 Mar 2022 21:06:29 +0200	[thread overview]
Message-ID: <edc4011d-5bfe-8ec5-e76b-61952cb3b9eb@kernel.org> (raw)
In-Reply-To: <20220326144313.673549-3-Mr.Bossman075@gmail.com>

On 26/03/2022 15:43, Jesse Taube wrote:
> Both the i.MXRT1170 and 1050 have the same GPT timer as "fsl,imx6dl-gpt"
> Add i.MXRT to the compatible list.
> 
> Signed-off-by: Jesse Taube <Mr.Bossman075@gmail.com>
> ---
>  Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> index a4f51f46b7a1..716c6afcca1f 100644
> --- a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> +++ b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> @@ -31,6 +31,8 @@ properties:
>            - enum:
>                - fsl,imx6sl-gpt
>                - fsl,imx6sx-gpt
> +              - fsl,imxrt1050-gpt
> +              - fsl,imxrt1170-gpt
>            - const: fsl,imx6dl-gpt

This looks ok, but your usage looks wrong. Did you test your DTS with
dtbs_check?

For the bindings only change:
Acked-by: Krzysztof Kozlowski <krzk@kernel.org>


Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-03-27 19:06 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-26 14:43 [PATCH v1 00/12] Add support for the i.MXRT1170-evk Jesse Taube
2022-03-26 14:43 ` Jesse Taube
2022-03-26 14:43 ` [PATCH v1 01/12] dt-bindings: arm: imx: Add i.MXRT compatible Documentation Jesse Taube
2022-03-26 14:43   ` Jesse Taube
2022-03-27 19:04   ` Krzysztof Kozlowski
2022-03-27 19:04     ` Krzysztof Kozlowski
2022-03-26 14:43 ` [PATCH v1 02/12] dt-bindings: timer: gpt: " Jesse Taube
2022-03-26 14:43   ` Jesse Taube
2022-03-27 19:06   ` Krzysztof Kozlowski [this message]
2022-03-27 19:06     ` Krzysztof Kozlowski
2022-03-26 14:43 ` [PATCH v1 03/12] dt-bindings: pinctrl: add i.MXRT1170 pinctrl Documentation Jesse Taube
2022-03-26 14:43   ` Jesse Taube
2022-03-27 19:08   ` Krzysztof Kozlowski
2022-03-27 19:08     ` Krzysztof Kozlowski
2022-03-27 19:14     ` Jesse Taube
2022-03-27 19:14       ` Jesse Taube
2022-03-27 19:30       ` Krzysztof Kozlowski
2022-03-27 19:30         ` Krzysztof Kozlowski
2022-03-26 14:43 ` [PATCH v1 04/12] dt-bindings: clock: imx: Add documentation for i.MXRT1170 clock Jesse Taube
2022-03-26 14:43   ` Jesse Taube
2022-03-27 19:12   ` Krzysztof Kozlowski
2022-03-27 19:12     ` Krzysztof Kozlowski
2022-03-26 14:43 ` [PATCH v1 05/12] ARM: mach-imx: Add support for i.MXRT1170 Jesse Taube
2022-03-26 14:43   ` Jesse Taube
2022-03-26 14:43 ` [PATCH v1 06/12] ARM: clk: imx: Update pllv3 to support i.MXRT1170 Jesse Taube
2022-03-26 14:43   ` Jesse Taube
2022-04-10  8:10   ` Shawn Guo
2022-04-10  8:10     ` Shawn Guo
2022-03-26 14:43 ` [PATCH v1 07/12] dt-bindings: imx: Add clock binding for i.MXRT1170 Jesse Taube
2022-03-26 14:43   ` Jesse Taube
2022-03-27 19:13   ` Krzysztof Kozlowski
2022-03-27 19:13     ` Krzysztof Kozlowski
2022-03-26 14:43 ` [PATCH v1 08/12] clk: imx: Add initial support for i.MXRT1170 clock driver Jesse Taube
2022-03-26 14:43   ` Jesse Taube
2022-04-23  3:03   ` Stephen Boyd
2022-04-23  3:03     ` Stephen Boyd
2022-04-23 16:11     ` Jesse Taube
2022-04-23 16:11       ` Jesse Taube
2022-04-24  3:53     ` Jesse Taube
2022-04-24  3:53       ` Jesse Taube
2022-04-23 17:46   ` Abel Vesa
2022-04-23 17:46     ` Abel Vesa
2022-03-26 14:43 ` [PATCH v1 09/12] pinctrl: freescale: Add i.MXRT1170 pinctrl driver support Jesse Taube
2022-03-26 14:43   ` Jesse Taube
2022-03-26 14:43 ` [PATCH v1 10/12] ARM: dts: imxrt1170-pinfunc: Add pinctrl binding header Jesse Taube
2022-03-26 14:43   ` Jesse Taube
2022-03-26 14:43 ` [PATCH v1 11/12] ARM: dts: imx: Add i.MXRT1170-EVK support Jesse Taube
2022-03-26 14:43   ` Jesse Taube
2022-03-27 19:17   ` Krzysztof Kozlowski
2022-03-27 19:17     ` Krzysztof Kozlowski
2022-03-26 14:43 ` [PATCH v1 12/12] ARM: imxrt_defconfig: Add i.MXRT1170 Jesse Taube
2022-03-26 14:43   ` Jesse Taube
2022-03-27 19:23   ` Krzysztof Kozlowski
2022-03-27 19:23     ` Krzysztof Kozlowski
2022-03-27 19:37     ` Jesse Taube
2022-03-27 19:37       ` Jesse Taube
2022-04-10  2:39 ` [PATCH v1 00/12] Add support for the i.MXRT1170-evk Jesse Taube
2022-04-10  2:39   ` Jesse Taube

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=edc4011d-5bfe-8ec5-e76b-61952cb3b9eb@kernel.org \
    --to=krzk@kernel.org \
    --cc=abel.vesa@nxp.com \
    --cc=aisheng.dong@nxp.com \
    --cc=arnd@arndb.de \
    --cc=clin@suse.com \
    --cc=cniedermaier@dh-electronics.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=dev@lynxeye.de \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=giulio.benetti@benettiengineering.com \
    --cc=kernel@pengutronix.de \
    --cc=leoyang.li@nxp.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=marcel.ziswiler@toradex.com \
    --cc=mr.bossman075@gmail.com \
    --cc=mturquette@baylibre.com \
    --cc=olof@lixom.net \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=sboyd@kernel.org \
    --cc=sebastian.reichel@collabora.com \
    --cc=shawnguo@kernel.org \
    --cc=soc@kernel.org \
    --cc=stefan@agner.ch \
    --cc=tglx@linutronix.de \
    --cc=tharvey@gateworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.