From: Jason Wang <jasowang@redhat.com> To: Stefano Garzarella <sgarzare@redhat.com>, netdev@vger.kernel.org Cc: "David S. Miller" <davem@davemloft.net>, "Michael S. Tsirkin" <mst@redhat.com>, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Stefan Hajnoczi <stefanha@redhat.com> Subject: Re: [PATCH v2 8/8] vsock/virtio: make the RX buffer size tunable Date: Mon, 13 May 2019 18:05:02 +0800 [thread overview] Message-ID: <eddb5a89-ed44-3a65-0181-84f7f27dd2cb@redhat.com> (raw) In-Reply-To: <20190510125843.95587-9-sgarzare@redhat.com> On 2019/5/10 下午8:58, Stefano Garzarella wrote: > The RX buffer size determines the memory consumption of the > vsock/virtio guest driver, so we make it tunable through > a module parameter. > > The size allowed are between 4 KB and 64 KB in order to be > compatible with old host drivers. > > Suggested-by: Stefan Hajnoczi <stefanha@redhat.com> > Signed-off-by: Stefano Garzarella <sgarzare@redhat.com> I don't see much value of doing this through kernel command line. We should deal with them automatically like what virtio-net did. Or even a module parameter is better. Thanks > --- > include/linux/virtio_vsock.h | 1 + > net/vmw_vsock/virtio_transport.c | 27 ++++++++++++++++++++++++++- > 2 files changed, 27 insertions(+), 1 deletion(-) > > diff --git a/include/linux/virtio_vsock.h b/include/linux/virtio_vsock.h > index 5a9d25be72df..b9f8c3d91f80 100644 > --- a/include/linux/virtio_vsock.h > +++ b/include/linux/virtio_vsock.h > @@ -13,6 +13,7 @@ > #define VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE (1024 * 64) > #define VIRTIO_VSOCK_MAX_BUF_SIZE 0xFFFFFFFFUL > #define VIRTIO_VSOCK_MAX_PKT_BUF_SIZE (1024 * 64) > +#define VIRTIO_VSOCK_MIN_PKT_BUF_SIZE (1024 * 4) > > enum { > VSOCK_VQ_RX = 0, /* for host to guest data */ > diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c > index af1d2ce12f54..732398b4e28f 100644 > --- a/net/vmw_vsock/virtio_transport.c > +++ b/net/vmw_vsock/virtio_transport.c > @@ -66,6 +66,31 @@ struct virtio_vsock { > u32 guest_cid; > }; > > +static unsigned int rx_buf_size = VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE; > + > +static int param_set_rx_buf_size(const char *val, const struct kernel_param *kp) > +{ > + unsigned int size; > + int ret; > + > + ret = kstrtouint(val, 0, &size); > + if (ret) > + return ret; > + > + if (size < VIRTIO_VSOCK_MIN_PKT_BUF_SIZE || > + size > VIRTIO_VSOCK_MAX_PKT_BUF_SIZE) > + return -EINVAL; > + > + return param_set_uint(val, kp); > +}; > + > +static const struct kernel_param_ops param_ops_rx_buf_size = { > + .set = param_set_rx_buf_size, > + .get = param_get_uint, > +}; > + > +module_param_cb(rx_buf_size, ¶m_ops_rx_buf_size, &rx_buf_size, 0644); > + > static struct virtio_vsock *virtio_vsock_get(void) > { > return the_virtio_vsock; > @@ -261,7 +286,7 @@ virtio_transport_cancel_pkt(struct vsock_sock *vsk) > > static void virtio_vsock_rx_fill(struct virtio_vsock *vsock) > { > - int buf_len = VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE; > + int buf_len = rx_buf_size; > struct virtio_vsock_pkt *pkt; > struct scatterlist hdr, buf, *sgs[2]; > struct virtqueue *vq;
WARNING: multiple messages have this Message-ID (diff)
From: Jason Wang <jasowang@redhat.com> To: Stefano Garzarella <sgarzare@redhat.com>, netdev@vger.kernel.org Cc: kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Stefan Hajnoczi <stefanha@redhat.com>, "David S. Miller" <davem@davemloft.net> Subject: Re: [PATCH v2 8/8] vsock/virtio: make the RX buffer size tunable Date: Mon, 13 May 2019 18:05:02 +0800 [thread overview] Message-ID: <eddb5a89-ed44-3a65-0181-84f7f27dd2cb@redhat.com> (raw) In-Reply-To: <20190510125843.95587-9-sgarzare@redhat.com> On 2019/5/10 下午8:58, Stefano Garzarella wrote: > The RX buffer size determines the memory consumption of the > vsock/virtio guest driver, so we make it tunable through > a module parameter. > > The size allowed are between 4 KB and 64 KB in order to be > compatible with old host drivers. > > Suggested-by: Stefan Hajnoczi <stefanha@redhat.com> > Signed-off-by: Stefano Garzarella <sgarzare@redhat.com> I don't see much value of doing this through kernel command line. We should deal with them automatically like what virtio-net did. Or even a module parameter is better. Thanks > --- > include/linux/virtio_vsock.h | 1 + > net/vmw_vsock/virtio_transport.c | 27 ++++++++++++++++++++++++++- > 2 files changed, 27 insertions(+), 1 deletion(-) > > diff --git a/include/linux/virtio_vsock.h b/include/linux/virtio_vsock.h > index 5a9d25be72df..b9f8c3d91f80 100644 > --- a/include/linux/virtio_vsock.h > +++ b/include/linux/virtio_vsock.h > @@ -13,6 +13,7 @@ > #define VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE (1024 * 64) > #define VIRTIO_VSOCK_MAX_BUF_SIZE 0xFFFFFFFFUL > #define VIRTIO_VSOCK_MAX_PKT_BUF_SIZE (1024 * 64) > +#define VIRTIO_VSOCK_MIN_PKT_BUF_SIZE (1024 * 4) > > enum { > VSOCK_VQ_RX = 0, /* for host to guest data */ > diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c > index af1d2ce12f54..732398b4e28f 100644 > --- a/net/vmw_vsock/virtio_transport.c > +++ b/net/vmw_vsock/virtio_transport.c > @@ -66,6 +66,31 @@ struct virtio_vsock { > u32 guest_cid; > }; > > +static unsigned int rx_buf_size = VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE; > + > +static int param_set_rx_buf_size(const char *val, const struct kernel_param *kp) > +{ > + unsigned int size; > + int ret; > + > + ret = kstrtouint(val, 0, &size); > + if (ret) > + return ret; > + > + if (size < VIRTIO_VSOCK_MIN_PKT_BUF_SIZE || > + size > VIRTIO_VSOCK_MAX_PKT_BUF_SIZE) > + return -EINVAL; > + > + return param_set_uint(val, kp); > +}; > + > +static const struct kernel_param_ops param_ops_rx_buf_size = { > + .set = param_set_rx_buf_size, > + .get = param_get_uint, > +}; > + > +module_param_cb(rx_buf_size, ¶m_ops_rx_buf_size, &rx_buf_size, 0644); > + > static struct virtio_vsock *virtio_vsock_get(void) > { > return the_virtio_vsock; > @@ -261,7 +286,7 @@ virtio_transport_cancel_pkt(struct vsock_sock *vsk) > > static void virtio_vsock_rx_fill(struct virtio_vsock *vsock) > { > - int buf_len = VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE; > + int buf_len = rx_buf_size; > struct virtio_vsock_pkt *pkt; > struct scatterlist hdr, buf, *sgs[2]; > struct virtqueue *vq; _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2019-05-13 10:05 UTC|newest] Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-10 12:58 [PATCH v2 0/8] vsock/virtio: optimizations to increase the throughput Stefano Garzarella 2019-05-10 12:58 ` [PATCH v2 1/8] vsock/virtio: limit the memory used per-socket Stefano Garzarella 2019-05-10 12:58 ` Stefano Garzarella 2019-05-12 16:57 ` Michael S. Tsirkin 2019-05-12 16:57 ` Michael S. Tsirkin 2019-05-13 16:40 ` Stefano Garzarella 2019-05-13 16:40 ` Stefano Garzarella 2019-05-13 9:58 ` Jason Wang 2019-05-13 17:23 ` Stefano Garzarella 2019-05-14 3:25 ` Jason Wang 2019-05-14 3:25 ` Jason Wang 2019-05-14 3:40 ` Jason Wang 2019-05-14 3:40 ` Jason Wang 2019-05-14 16:35 ` Stefano Garzarella 2019-05-14 16:35 ` Stefano Garzarella 2019-05-15 2:48 ` Jason Wang 2019-05-15 2:48 ` Jason Wang 2019-05-28 16:45 ` Stefano Garzarella 2019-05-28 16:45 ` Stefano Garzarella 2019-05-29 0:59 ` Jason Wang 2019-05-29 0:59 ` Jason Wang 2019-05-13 17:23 ` Stefano Garzarella 2019-05-13 9:58 ` Jason Wang 2019-05-16 15:25 ` Stefan Hajnoczi 2019-05-17 8:25 ` Stefano Garzarella 2019-05-17 8:25 ` Stefano Garzarella 2019-05-20 8:57 ` Stefan Hajnoczi 2019-05-20 8:57 ` Stefan Hajnoczi 2019-05-16 15:25 ` Stefan Hajnoczi 2019-05-10 12:58 ` [PATCH v2 2/8] vsock/virtio: free packets during the socket release Stefano Garzarella 2019-05-10 22:20 ` David Miller 2019-05-10 22:20 ` David Miller 2019-05-11 8:27 ` Stefano Garzarella 2019-05-11 8:27 ` Stefano Garzarella 2019-05-16 15:32 ` Stefan Hajnoczi 2019-05-16 15:32 ` Stefan Hajnoczi 2019-05-17 8:26 ` Stefano Garzarella 2019-05-17 8:26 ` Stefano Garzarella 2019-05-10 12:58 ` Stefano Garzarella 2019-05-10 12:58 ` [PATCH v2 3/8] vsock/virtio: fix locking for fwd_cnt and buf_alloc Stefano Garzarella 2019-05-10 12:58 ` Stefano Garzarella 2019-05-10 12:58 ` [PATCH v2 4/8] vsock/virtio: reduce credit update messages Stefano Garzarella 2019-05-10 12:58 ` Stefano Garzarella 2019-05-10 12:58 ` [PATCH v2 5/8] vhost/vsock: split packets to send using multiple buffers Stefano Garzarella 2019-05-10 12:58 ` Stefano Garzarella 2019-05-10 12:58 ` [PATCH v2 6/8] vsock/virtio: change the maximum packet size allowed Stefano Garzarella 2019-05-10 12:58 ` Stefano Garzarella 2019-05-10 12:58 ` [PATCH v2 7/8] vsock/virtio: increase RX buffer size to 64 KiB Stefano Garzarella 2019-05-13 10:01 ` Jason Wang 2019-05-13 17:51 ` Stefano Garzarella 2019-05-13 17:51 ` Stefano Garzarella 2019-05-14 3:38 ` Jason Wang 2019-05-14 16:20 ` Stefano Garzarella 2019-05-14 16:20 ` Stefano Garzarella 2019-05-15 2:50 ` Jason Wang 2019-05-15 8:22 ` Stefano Garzarella 2019-05-15 8:22 ` Stefano Garzarella 2019-05-15 2:50 ` Jason Wang 2019-05-14 3:38 ` Jason Wang 2019-05-13 10:01 ` Jason Wang 2019-05-10 12:58 ` Stefano Garzarella 2019-05-10 12:58 ` [PATCH v2 8/8] vsock/virtio: make the RX buffer size tunable Stefano Garzarella 2019-05-10 12:58 ` Stefano Garzarella 2019-05-13 10:05 ` Jason Wang [this message] 2019-05-13 10:05 ` Jason Wang 2019-05-13 12:46 ` Jason Wang 2019-05-13 12:46 ` Jason Wang 2019-05-14 16:10 ` Stefano Garzarella 2019-05-14 16:10 ` Stefano Garzarella 2019-05-13 9:33 ` [PATCH v2 0/8] vsock/virtio: optimizations to increase the throughput Jason Wang 2019-05-13 16:49 ` Stefano Garzarella 2019-05-13 16:49 ` Stefano Garzarella 2019-05-20 14:09 ` Stefano Garzarella 2019-05-20 14:09 ` Stefano Garzarella 2019-05-13 9:33 ` Jason Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=eddb5a89-ed44-3a65-0181-84f7f27dd2cb@redhat.com \ --to=jasowang@redhat.com \ --cc=davem@davemloft.net \ --cc=kvm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mst@redhat.com \ --cc=netdev@vger.kernel.org \ --cc=sgarzare@redhat.com \ --cc=stefanha@redhat.com \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.