* [U-Boot] [PATCH v2] gpio: xilinx: Add support for using label property
@ 2018-08-06 6:42 Michal Simek
2018-08-06 15:58 ` Stefan Herbrechtsmeier
0 siblings, 1 reply; 2+ messages in thread
From: Michal Simek @ 2018-08-06 6:42 UTC (permalink / raw)
To: u-boot
Add support for reading label property from DT and set up bank name
based on that. If label property is not present full device node name is
used.
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
Changes in v2:
- Use strdup
drivers/gpio/xilinx_gpio.c | 10 +++++++++-
drivers/gpio/zynq_gpio.c | 10 +++++++++-
2 files changed, 18 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/xilinx_gpio.c b/drivers/gpio/xilinx_gpio.c
index fc460c343efe..2389abee3777 100644
--- a/drivers/gpio/xilinx_gpio.c
+++ b/drivers/gpio/xilinx_gpio.c
@@ -241,8 +241,16 @@ static int xilinx_gpio_probe(struct udevice *dev)
struct xilinx_gpio_platdata *platdata = dev_get_platdata(dev);
struct xilinx_gpio_privdata *priv = dev_get_priv(dev);
struct gpio_dev_priv *uc_priv = dev_get_uclass_priv(dev);
+ const void *label_ptr;
- uc_priv->bank_name = dev->name;
+ label_ptr = dev_read_prop(dev, "label", NULL);
+ if (label_ptr) {
+ uc_priv->bank_name = strdup(label_ptr);
+ if (!uc_priv->bank_name)
+ return -ENOMEM;
+ } else {
+ uc_priv->bank_name = dev->name;
+ }
uc_priv->gpio_count = platdata->bank_max[0] + platdata->bank_max[1];
diff --git a/drivers/gpio/zynq_gpio.c b/drivers/gpio/zynq_gpio.c
index 6fbaafb3fa3c..55a5cba0688e 100644
--- a/drivers/gpio/zynq_gpio.c
+++ b/drivers/gpio/zynq_gpio.c
@@ -336,8 +336,16 @@ static int zynq_gpio_probe(struct udevice *dev)
{
struct zynq_gpio_platdata *platdata = dev_get_platdata(dev);
struct gpio_dev_priv *uc_priv = dev_get_uclass_priv(dev);
+ const void *label_ptr;
- uc_priv->bank_name = dev->name;
+ label_ptr = dev_read_prop(dev, "label", NULL);
+ if (label_ptr) {
+ uc_priv->bank_name = strdup(label_ptr);
+ if (!uc_priv->bank_name)
+ return -ENOMEM;
+ } else {
+ uc_priv->bank_name = dev->name;
+ }
if (platdata->p_data)
uc_priv->gpio_count = platdata->p_data->ngpio;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] [PATCH v2] gpio: xilinx: Add support for using label property
2018-08-06 6:42 [U-Boot] [PATCH v2] gpio: xilinx: Add support for using label property Michal Simek
@ 2018-08-06 15:58 ` Stefan Herbrechtsmeier
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Herbrechtsmeier @ 2018-08-06 15:58 UTC (permalink / raw)
To: u-boot
Am 06.08.2018 um 08:42 schrieb Michal Simek:
> Add support for reading label property from DT and set up bank name
> based on that. If label property is not present full device node name is
> used.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> Changes in v2:
> - Use strdup
>
> drivers/gpio/xilinx_gpio.c | 10 +++++++++-
> drivers/gpio/zynq_gpio.c | 10 +++++++++-
> 2 files changed, 18 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/xilinx_gpio.c b/drivers/gpio/xilinx_gpio.c
> index fc460c343efe..2389abee3777 100644
> --- a/drivers/gpio/xilinx_gpio.c
> +++ b/drivers/gpio/xilinx_gpio.c
> @@ -241,8 +241,16 @@ static int xilinx_gpio_probe(struct udevice *dev)
> struct xilinx_gpio_platdata *platdata = dev_get_platdata(dev);
> struct xilinx_gpio_privdata *priv = dev_get_priv(dev);
> struct gpio_dev_priv *uc_priv = dev_get_uclass_priv(dev);
> + const void *label_ptr;
>
> - uc_priv->bank_name = dev->name;
> + label_ptr = dev_read_prop(dev, "label", NULL);
> + if (label_ptr) {
> + uc_priv->bank_name = strdup(label_ptr);
> + if (!uc_priv->bank_name)
> + return -ENOMEM;
> + } else {
> + uc_priv->bank_name = dev->name;
> + }
>
> uc_priv->gpio_count = platdata->bank_max[0] + platdata->bank_max[1];
>
> diff --git a/drivers/gpio/zynq_gpio.c b/drivers/gpio/zynq_gpio.c
> index 6fbaafb3fa3c..55a5cba0688e 100644
> --- a/drivers/gpio/zynq_gpio.c
> +++ b/drivers/gpio/zynq_gpio.c
> @@ -336,8 +336,16 @@ static int zynq_gpio_probe(struct udevice *dev)
> {
> struct zynq_gpio_platdata *platdata = dev_get_platdata(dev);
> struct gpio_dev_priv *uc_priv = dev_get_uclass_priv(dev);
> + const void *label_ptr;
>
> - uc_priv->bank_name = dev->name;
> + label_ptr = dev_read_prop(dev, "label", NULL);
> + if (label_ptr) {
> + uc_priv->bank_name = strdup(label_ptr);
> + if (!uc_priv->bank_name)
> + return -ENOMEM;
> + } else {
> + uc_priv->bank_name = dev->name;
> + }
>
> if (platdata->p_data)
> uc_priv->gpio_count = platdata->p_data->ngpio;
Reviewed-by: Stefan Herbrechtsmeier <stefan@herbrechtsmeier.net>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-06 15:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-06 6:42 [U-Boot] [PATCH v2] gpio: xilinx: Add support for using label property Michal Simek
2018-08-06 15:58 ` Stefan Herbrechtsmeier
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.