From: Richard Henderson <richard.henderson@linaro.org>
To: Yifei Jiang <jiangyifei@huawei.com>,
qemu-devel@nongnu.org, qemu-riscv@nongnu.org
Cc: zhang.zhanghailiang@huawei.com, sagark@eecs.berkeley.edu,
kbastian@mail.uni-paderborn.de, victor.zhangxiaofeng@huawei.com,
Alistair.Francis@wdc.com, yinyipeng1@huawei.com,
palmer@dabbelt.com, wu.wubin@huawei.com, dengkai1@huawei.com
Subject: Re: [PATCH V3] target/riscv: raise exception to HS-mode at get_physical_address
Date: Wed, 14 Oct 2020 13:21:46 -0700 [thread overview]
Message-ID: <ee4b99ec-5842-6638-ecff-54096ec0b0e8@linaro.org> (raw)
In-Reply-To: <20201014101728.848-1-jiangyifei@huawei.com>
On 10/14/20 3:17 AM, Yifei Jiang wrote:
> + if (fault_pte_addr) {
> + *fault_pte_addr = (base + idx * ptesize) >> 2;
The shift is wrong. It should be exactly like...
> + }
> + return TRANSLATE_G_STAGE_FAIL;
> }
>
> pte_addr = vbase + idx * ptesize;
... this.
r~
WARNING: multiple messages have this Message-ID (diff)
From: Richard Henderson <richard.henderson@linaro.org>
To: Yifei Jiang <jiangyifei@huawei.com>,
qemu-devel@nongnu.org, qemu-riscv@nongnu.org
Cc: palmer@dabbelt.com, Alistair.Francis@wdc.com,
sagark@eecs.berkeley.edu, kbastian@mail.uni-paderborn.de,
victor.zhangxiaofeng@huawei.com, wu.wubin@huawei.com,
zhang.zhanghailiang@huawei.com, dengkai1@huawei.com,
yinyipeng1@huawei.com
Subject: Re: [PATCH V3] target/riscv: raise exception to HS-mode at get_physical_address
Date: Wed, 14 Oct 2020 13:21:46 -0700 [thread overview]
Message-ID: <ee4b99ec-5842-6638-ecff-54096ec0b0e8@linaro.org> (raw)
In-Reply-To: <20201014101728.848-1-jiangyifei@huawei.com>
On 10/14/20 3:17 AM, Yifei Jiang wrote:
> + if (fault_pte_addr) {
> + *fault_pte_addr = (base + idx * ptesize) >> 2;
The shift is wrong. It should be exactly like...
> + }
> + return TRANSLATE_G_STAGE_FAIL;
> }
>
> pte_addr = vbase + idx * ptesize;
... this.
r~
next prev parent reply other threads:[~2020-10-14 20:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 10:17 [PATCH V3] target/riscv: raise exception to HS-mode at get_physical_address Yifei Jiang
2020-10-14 10:17 ` Yifei Jiang
2020-10-14 20:06 ` Alistair Francis
2020-10-14 20:06 ` Alistair Francis
2020-10-14 20:21 ` Richard Henderson [this message]
2020-10-14 20:21 ` Richard Henderson
2020-10-15 1:59 ` Jiangyifei
2020-10-15 1:59 ` Jiangyifei
2020-10-21 19:59 ` Alistair Francis
2020-10-21 19:59 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee4b99ec-5842-6638-ecff-54096ec0b0e8@linaro.org \
--to=richard.henderson@linaro.org \
--cc=Alistair.Francis@wdc.com \
--cc=dengkai1@huawei.com \
--cc=jiangyifei@huawei.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=sagark@eecs.berkeley.edu \
--cc=victor.zhangxiaofeng@huawei.com \
--cc=wu.wubin@huawei.com \
--cc=yinyipeng1@huawei.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.