From: Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Sowjanya Komatineni
<skomatineni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
frankc-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
hverkuil-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org,
sakari.ailus-X3B1VOXEql0@public.gmane.org,
helen.koike-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org
Cc: sboyd-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [RFC PATCH v6 6/9] media: tegra: Add Tegra210 Video input driver
Date: Wed, 8 Apr 2020 01:14:05 +0300 [thread overview]
Message-ID: <ee4cce05-2c60-6de1-2639-fe54abbf8345@gmail.com> (raw)
In-Reply-To: <15a879b3-8fb9-6821-3cdc-104ba583ac12-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
08.04.2020 01:08, Dmitry Osipenko пишет:
> 08.04.2020 00:08, Sowjanya Komatineni пишет:
> ...
>>>> I think you need a semaphore with resource count = 2.
>>> we hold on to issuing capture if more than 2 buffers are queued and it
>>> continues only after fifo has min 1 slot empty
>>
>>
>> Just want to close on this part of feedback. Hope above explanation is
>> clear regarding triggering/issuing at max 2 frame capture to VI HW and
>> also regarding capture threads where they use wait_event_interruptible
>> to prevent blocking waiting for buffers to be available for captures.
>>
>> So no changes related to this part are needed in v7.
> From what I see in the code, you "hold on" by making kthread to spin in
> a busy-loop while caps_inflight >= SYNCPT_FIFO_DEPTH. So some change
> should be needed to prevent this.
Looks like some other media drivers do:
schedule_timeout_uninterruptible(1);
to avoid CPU hogging when contention is detected.
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Osipenko <digetx@gmail.com>
To: Sowjanya Komatineni <skomatineni@nvidia.com>,
thierry.reding@gmail.com, jonathanh@nvidia.com,
frankc@nvidia.com, hverkuil@xs4all.nl, sakari.ailus@iki.fi,
helen.koike@collabora.com
Cc: sboyd@kernel.org, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v6 6/9] media: tegra: Add Tegra210 Video input driver
Date: Wed, 8 Apr 2020 01:14:05 +0300 [thread overview]
Message-ID: <ee4cce05-2c60-6de1-2639-fe54abbf8345@gmail.com> (raw)
In-Reply-To: <15a879b3-8fb9-6821-3cdc-104ba583ac12@gmail.com>
08.04.2020 01:08, Dmitry Osipenko пишет:
> 08.04.2020 00:08, Sowjanya Komatineni пишет:
> ...
>>>> I think you need a semaphore with resource count = 2.
>>> we hold on to issuing capture if more than 2 buffers are queued and it
>>> continues only after fifo has min 1 slot empty
>>
>>
>> Just want to close on this part of feedback. Hope above explanation is
>> clear regarding triggering/issuing at max 2 frame capture to VI HW and
>> also regarding capture threads where they use wait_event_interruptible
>> to prevent blocking waiting for buffers to be available for captures.
>>
>> So no changes related to this part are needed in v7.
> From what I see in the code, you "hold on" by making kthread to spin in
> a busy-loop while caps_inflight >= SYNCPT_FIFO_DEPTH. So some change
> should be needed to prevent this.
Looks like some other media drivers do:
schedule_timeout_uninterruptible(1);
to avoid CPU hogging when contention is detected.
next prev parent reply other threads:[~2020-04-07 22:14 UTC|newest]
Thread overview: 148+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-04 1:24 [RFC PATCH v6 0/9] Add Tegra driver for video capture Sowjanya Komatineni
2020-04-04 1:24 ` Sowjanya Komatineni
2020-04-04 1:25 ` [RFC PATCH v6 2/9] arm64: tegra: Add reset-cells to mc Sowjanya Komatineni
2020-04-04 1:25 ` Sowjanya Komatineni
2020-04-04 1:25 ` [RFC PATCH v6 3/9] dt-bindings: clock: tegra: Add clk id for CSI TPG clock Sowjanya Komatineni
2020-04-04 1:25 ` Sowjanya Komatineni
[not found] ` <1585963507-12610-4-git-send-email-skomatineni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-04-14 18:12 ` Rob Herring
2020-04-14 18:12 ` Rob Herring
2020-04-04 1:25 ` [RFC PATCH v6 4/9] clk: tegra: Add Tegra210 CSI TPG clock gate Sowjanya Komatineni
2020-04-04 1:25 ` Sowjanya Komatineni
2020-04-04 1:25 ` [RFC PATCH v6 5/9] dt-binding: tegra: Add VI and CSI bindings Sowjanya Komatineni
2020-04-04 1:25 ` Sowjanya Komatineni
2020-04-14 18:14 ` Rob Herring
2020-04-14 18:14 ` Rob Herring
[not found] ` <1585963507-12610-1-git-send-email-skomatineni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-04-04 1:24 ` [RFC PATCH v6 1/9] arm64: tegra: Fix sor powergate clocks and reset Sowjanya Komatineni
2020-04-04 1:24 ` Sowjanya Komatineni
2020-04-04 1:25 ` [RFC PATCH v6 6/9] media: tegra: Add Tegra210 Video input driver Sowjanya Komatineni
2020-04-04 1:25 ` Sowjanya Komatineni
2020-04-05 19:45 ` Dmitry Osipenko
[not found] ` <3033ce67-fd77-f646-71b5-3a9671341a87-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-04-05 19:57 ` Dmitry Osipenko
2020-04-05 19:57 ` Dmitry Osipenko
[not found] ` <1585963507-12610-7-git-send-email-skomatineni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-04-05 19:37 ` Dmitry Osipenko
2020-04-05 19:37 ` Dmitry Osipenko
[not found] ` <ca9a792f-ff5e-c82b-c2bc-32c4875e558d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-04-06 18:58 ` Sowjanya Komatineni
2020-04-06 18:58 ` Sowjanya Komatineni
2020-04-05 19:51 ` Dmitry Osipenko
2020-04-05 19:51 ` Dmitry Osipenko
2020-04-05 20:35 ` Dmitry Osipenko
2020-04-05 20:35 ` Dmitry Osipenko
[not found] ` <38d921a7-5cdf-8d0a-2772-4399dd1a96a0-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-04-06 15:35 ` Sowjanya Komatineni
2020-04-06 15:35 ` Sowjanya Komatineni
[not found] ` <9b8cf37b-d2ad-9df2-aad8-216c2c954e69-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-04-06 16:05 ` Dmitry Osipenko
2020-04-06 16:05 ` Dmitry Osipenko
[not found] ` <1a12974a-7cc7-2c3a-3995-076b9956714d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-04-06 16:12 ` Sowjanya Komatineni
2020-04-06 16:12 ` Sowjanya Komatineni
2020-04-06 16:29 ` Dmitry Osipenko
[not found] ` <f000f6b9-0f05-b2a5-6dad-37b09803711d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-04-06 16:37 ` Sowjanya Komatineni
2020-04-06 16:37 ` Sowjanya Komatineni
[not found] ` <fe6a17c1-fae2-a365-4dd6-6d3a25d47d54-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-04-06 17:02 ` Sowjanya Komatineni
2020-04-06 17:02 ` Sowjanya Komatineni
[not found] ` <9038ce90-ac53-93e7-ce65-57f6ff1e9b30-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-04-06 19:53 ` Dmitry Osipenko
2020-04-06 19:53 ` Dmitry Osipenko
[not found] ` <abe82fd1-0464-0627-6c97-39c896e53dd0-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-04-06 20:05 ` Sowjanya Komatineni
2020-04-06 20:05 ` Sowjanya Komatineni
[not found] ` <36b5627a-8639-6244-8620-4f23828e0638-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-04-06 20:28 ` Dmitry Osipenko
2020-04-06 20:28 ` Dmitry Osipenko
2020-04-06 20:30 ` Sowjanya Komatineni
2020-04-06 20:30 ` Sowjanya Komatineni
2020-04-05 20:54 ` Dmitry Osipenko
2020-04-05 20:54 ` Dmitry Osipenko
2020-04-06 20:45 ` Dmitry Osipenko
2020-04-06 20:45 ` Dmitry Osipenko
[not found] ` <200bb96e-2d07-764f-9e14-55538dc742fd-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-04-06 20:50 ` Sowjanya Komatineni
2020-04-06 20:50 ` Sowjanya Komatineni
[not found] ` <23bfab09-b464-6e51-9843-06d13000e9b9-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-04-06 20:53 ` Dmitry Osipenko
2020-04-06 20:53 ` Dmitry Osipenko
2020-04-06 20:55 ` Sowjanya Komatineni
2020-04-06 20:55 ` Sowjanya Komatineni
[not found] ` <08cd31d5-e8b9-4d3a-fb0e-0e4462947d96-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-04-06 20:56 ` Dmitry Osipenko
2020-04-06 20:56 ` Dmitry Osipenko
2020-04-06 21:02 ` Sowjanya Komatineni
2020-04-06 21:02 ` Sowjanya Komatineni
2020-04-06 21:11 ` Dmitry Osipenko
[not found] ` <b1726d33-0d35-9323-a747-407148d0104e-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-04-06 21:15 ` Sowjanya Komatineni
2020-04-06 21:15 ` Sowjanya Komatineni
2020-04-06 21:39 ` Sowjanya Komatineni
2020-04-06 21:39 ` Sowjanya Komatineni
2020-04-06 22:00 ` Sowjanya Komatineni
2020-04-06 22:00 ` Sowjanya Komatineni
2020-04-06 22:07 ` Sowjanya Komatineni
2020-04-06 22:07 ` Sowjanya Komatineni
[not found] ` <760d071e-0cbc-b3eb-9231-fb9f9ecb44a6-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-04-06 23:18 ` Dmitry Osipenko
2020-04-06 23:18 ` Dmitry Osipenko
[not found] ` <9e317f65-8a02-3b15-cfec-8e0d8374130e-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-04-06 23:48 ` Sowjanya Komatineni
2020-04-06 23:48 ` Sowjanya Komatineni
[not found] ` <97b35910-4c93-123a-43a0-eb14476ed0f3-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-04-06 23:50 ` Sowjanya Komatineni
2020-04-06 23:50 ` Sowjanya Komatineni
2020-04-07 21:08 ` Sowjanya Komatineni
2020-04-07 21:08 ` Sowjanya Komatineni
[not found] ` <84ad4e2d-6ac1-e1f4-1c55-5edaae850631-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-04-07 22:08 ` Dmitry Osipenko
2020-04-07 22:08 ` Dmitry Osipenko
[not found] ` <15a879b3-8fb9-6821-3cdc-104ba583ac12-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-04-07 22:14 ` Dmitry Osipenko [this message]
2020-04-07 22:14 ` Dmitry Osipenko
2020-04-07 22:22 ` Sowjanya Komatineni
2020-04-07 22:22 ` Sowjanya Komatineni
[not found] ` <0c425505-347f-7418-af7e-d121fe0d06dc-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-04-07 23:12 ` Dmitry Osipenko
2020-04-07 23:12 ` Dmitry Osipenko
[not found] ` <1a31cd60-739f-0660-1c45-31487d2f2128@nvidia.com>
[not found] ` <1a31cd60-739f-0660-1c45-31487d2f2128-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-04-07 23:38 ` Sowjanya Komatineni
2020-04-07 23:38 ` Sowjanya Komatineni
[not found] ` <603084a5-249a-4fe2-3646-e9335ef9ab43-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-04-07 23:56 ` Sowjanya Komatineni
2020-04-07 23:56 ` Sowjanya Komatineni
2020-04-07 23:57 ` Sowjanya Komatineni
2020-04-07 23:57 ` Sowjanya Komatineni
2020-04-07 23:59 ` Sowjanya Komatineni
2020-04-07 23:59 ` Sowjanya Komatineni
[not found] ` <7895b9c6-f27d-8939-73d7-67d785e1a8b7-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-04-08 0:00 ` Sowjanya Komatineni
2020-04-08 0:00 ` Sowjanya Komatineni
2020-04-08 14:21 ` Dmitry Osipenko
[not found] ` <b2405c2a-73c0-ad69-ccea-0388caf8045c-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-04-08 17:45 ` Sowjanya Komatineni
2020-04-08 17:45 ` Sowjanya Komatineni
[not found] ` <15d8b525-67b5-b437-f7fd-89f80cd0d9f6-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-04-08 18:58 ` Sowjanya Komatineni
2020-04-08 18:58 ` Sowjanya Komatineni
2020-04-08 19:38 ` Sowjanya Komatineni
2020-04-08 19:38 ` Sowjanya Komatineni
[not found] ` <ced73258-6f4b-e970-4ca5-ecdf1808a4c3-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-04-09 3:38 ` Sowjanya Komatineni
2020-04-09 3:38 ` Sowjanya Komatineni
2020-04-09 14:50 ` Dmitry Osipenko
2020-04-09 18:28 ` Sowjanya Komatineni
2020-04-09 18:28 ` Sowjanya Komatineni
2020-04-10 18:47 ` Dmitry Osipenko
[not found] ` <00708f34-cf45-e248-c6b0-c3d2286671ca-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-04-10 18:59 ` Sowjanya Komatineni
2020-04-10 18:59 ` Sowjanya Komatineni
2020-04-10 19:45 ` Dmitry Osipenko
2020-04-07 19:39 ` Dmitry Osipenko
2020-04-07 19:39 ` Dmitry Osipenko
2020-04-07 19:42 ` Sowjanya Komatineni
2020-04-07 19:42 ` Sowjanya Komatineni
2020-04-05 21:11 ` Dmitry Osipenko
[not found] ` <40102767-ecdb-e958-66f4-45d11464069c-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-04-06 15:41 ` Sowjanya Komatineni
2020-04-06 15:41 ` Sowjanya Komatineni
[not found] ` <b7b77258-6309-7ed2-489d-337cf273ba1e-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-04-06 16:11 ` Dmitry Osipenko
2020-04-06 16:11 ` Dmitry Osipenko
[not found] ` <6014fee9-ce97-7ced-f2ba-82176b8b36db-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-04-07 19:05 ` Sowjanya Komatineni
2020-04-07 19:05 ` Sowjanya Komatineni
2020-04-06 19:48 ` Dmitry Osipenko
2020-04-06 20:00 ` Sowjanya Komatineni
2020-04-06 20:00 ` Sowjanya Komatineni
2020-04-06 20:02 ` Dmitry Osipenko
2020-04-06 20:20 ` Sowjanya Komatineni
2020-04-06 20:20 ` Sowjanya Komatineni
[not found] ` <ac225ff3-8de8-256c-7f81-0225b4153540-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-04-06 20:37 ` Dmitry Osipenko
2020-04-06 20:37 ` Dmitry Osipenko
[not found] ` <86bbcd55-fa13-5a35-e38b-c23745eafb87-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-04-06 20:38 ` Sowjanya Komatineni
2020-04-06 20:38 ` Sowjanya Komatineni
[not found] ` <2839b1ee-dedc-d0ee-e484-32729a82a6ea-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-04-06 20:43 ` Sowjanya Komatineni
2020-04-06 20:43 ` Sowjanya Komatineni
2020-04-06 20:54 ` Dmitry Osipenko
2020-04-06 21:18 ` Sowjanya Komatineni
2020-04-06 21:18 ` Sowjanya Komatineni
2020-04-10 19:47 ` Dmitry Osipenko
2020-04-04 1:25 ` [RFC PATCH v6 8/9] dt-bindings: reset: Add ID for Tegra210 VI reset Sowjanya Komatineni
2020-04-04 1:25 ` Sowjanya Komatineni
[not found] ` <1585963507-12610-9-git-send-email-skomatineni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-04-14 18:14 ` Rob Herring
2020-04-14 18:14 ` Rob Herring
2020-04-04 1:25 ` [RFC PATCH v6 7/9] MAINTAINERS: Add Tegra Video driver section Sowjanya Komatineni
2020-04-04 1:25 ` Sowjanya Komatineni
2020-04-04 1:25 ` [RFC PATCH v6 9/9] arm64: tegra: Add Tegra VI CSI support in device tree Sowjanya Komatineni
2020-04-04 1:25 ` Sowjanya Komatineni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee4cce05-2c60-6de1-2639-fe54abbf8345@gmail.com \
--to=digetx-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=frankc-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=helen.koike-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org \
--cc=hverkuil-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org \
--cc=jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sakari.ailus-X3B1VOXEql0@public.gmane.org \
--cc=sboyd-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=skomatineni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.