From: Markus Elfring <Markus.Elfring@web.de>
To: zhong jiang <zhongjiang@huawei.com>,
Anna Schumaker <anna.schumaker@netapp.com>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
linux-nfs@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: NFS: remove the redundant check when kfree an object in nfs_netns_client_release
Date: Wed, 4 Sep 2019 17:11:52 +0200 [thread overview]
Message-ID: <ee684073-bd3e-9a1c-4d38-702f55affba4@web.de> (raw)
In-Reply-To: <1567490688-17872-1-git-send-email-zhongjiang@huawei.com>
> kfree has taken the null check in account.
I suggest to take another look at a similar patch.
NFS: fix ifnullfree.cocci warnings
https://lkml.org/lkml/2019/7/7/73
https://lore.kernel.org/patchwork/patch/1098005/
https://lore.kernel.org/r/alpine.DEB.2.21.1907071844310.2521@hadrien/
Regards,
Markus
WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: zhong jiang <zhongjiang@huawei.com>,
Anna Schumaker <anna.schumaker@netapp.com>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
linux-nfs@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: NFS: remove the redundant check when kfree an object in nfs_netns_client_release
Date: Wed, 04 Sep 2019 15:11:52 +0000 [thread overview]
Message-ID: <ee684073-bd3e-9a1c-4d38-702f55affba4@web.de> (raw)
In-Reply-To: <1567490688-17872-1-git-send-email-zhongjiang@huawei.com>
> kfree has taken the null check in account.
I suggest to take another look at a similar patch.
NFS: fix ifnullfree.cocci warnings
https://lkml.org/lkml/2019/7/7/73
https://lore.kernel.org/patchwork/patch/1098005/
https://lore.kernel.org/r/alpine.DEB.2.21.1907071844310.2521@hadrien/
Regards,
Markus
next prev parent reply other threads:[~2019-09-04 15:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 6:04 [PATCH] NFS: remove the redundant check when kfree an object in nfs_netns_client_release zhong jiang
2019-09-04 15:11 ` Markus Elfring [this message]
2019-09-04 15:11 ` Markus Elfring
2019-09-05 2:40 ` zhong jiang
2019-09-05 2:40 ` zhong jiang
2019-09-05 9:00 ` NFS: Checking the handling of patch variations Markus Elfring
2019-09-05 9:00 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee684073-bd3e-9a1c-4d38-702f55affba4@web.de \
--to=markus.elfring@web.de \
--cc=anna.schumaker@netapp.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@hammerspace.com \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.