* [PATCH] smb: delete an unnecessary statement
@ 2023-05-26 12:01 Dan Carpenter
2023-05-26 15:36 ` Mukesh Ojha
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2023-05-26 12:01 UTC (permalink / raw)
To: Steve French
Cc: Paulo Alcantara, Ronnie Sahlberg, Shyam Prasad N, Tom Talpey,
linux-cifs, samba-technical, linux-kernel, kernel-janitors
We don't need to set the list iterators to NULL before a
list_for_each_entry() loop because they are assigned inside the
macro.
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
fs/smb/client/smb2ops.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/smb/client/smb2ops.c b/fs/smb/client/smb2ops.c
index 5065398665f1..6e3be58cfe49 100644
--- a/fs/smb/client/smb2ops.c
+++ b/fs/smb/client/smb2ops.c
@@ -618,7 +618,6 @@ parse_server_interfaces(struct network_interface_info_ioctl_rsp *buf,
* Add a new one instead
*/
spin_lock(&ses->iface_lock);
- iface = niface = NULL;
list_for_each_entry_safe(iface, niface, &ses->iface_list,
iface_head) {
ret = iface_cmp(iface, &tmp_iface);
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] smb: delete an unnecessary statement
2023-05-26 12:01 [PATCH] smb: delete an unnecessary statement Dan Carpenter
@ 2023-05-26 15:36 ` Mukesh Ojha
0 siblings, 0 replies; 2+ messages in thread
From: Mukesh Ojha @ 2023-05-26 15:36 UTC (permalink / raw)
To: Dan Carpenter, Steve French
Cc: Paulo Alcantara, Ronnie Sahlberg, Shyam Prasad N, Tom Talpey,
linux-cifs, samba-technical, linux-kernel, kernel-janitors
On 5/26/2023 5:31 PM, Dan Carpenter wrote:
> We don't need to set the list iterators to NULL before a
> list_for_each_entry() loop because they are assigned inside the
> macro.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com>
-Mukesh
> ---
> fs/smb/client/smb2ops.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/smb/client/smb2ops.c b/fs/smb/client/smb2ops.c
> index 5065398665f1..6e3be58cfe49 100644
> --- a/fs/smb/client/smb2ops.c
> +++ b/fs/smb/client/smb2ops.c
> @@ -618,7 +618,6 @@ parse_server_interfaces(struct network_interface_info_ioctl_rsp *buf,
> * Add a new one instead
> */
> spin_lock(&ses->iface_lock);
> - iface = niface = NULL;
> list_for_each_entry_safe(iface, niface, &ses->iface_list,
> iface_head) {
> ret = iface_cmp(iface, &tmp_iface);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-26 15:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-26 12:01 [PATCH] smb: delete an unnecessary statement Dan Carpenter
2023-05-26 15:36 ` Mukesh Ojha
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.