[U-Boot] [u-boot-imx/next] WaRP7 & Pico-Pi i.MX7 NOK

[U-Boot] [u-boot-imx/next] WaRP7 & Pico-Pi i.MX7 NOK

[Pierre-Jean Texier]

Stefano, Peng,

I just compiled a fresh U-Boot with u-boot-imx/next and It looks
like commit 34f2feb ("imx: mmc_env: update runtime SD/MMC boot env 
device") [1]
breaks my WaRP7 (but the same for the Pico-Pi i.MX7, tested by Joris in 
CC),
see logs after:

U-Boot 2019.10-rc4-00232-gd03193d (Oct 07 2019 - 18:44:25 +0200)

CPU:   Freescale i.MX7S rev1.2 800 MHz (running at 792 MHz)
CPU:   Extended Commercial temperature grade (-20C to 105C) at 33C
Reset cause: POR
Model: Warp i.MX7 Board
Board: WARP7 in secure mode OPTEE DRAM 0x9d000000-0xa0000000
DRAM:  464 MiB
MMC:   FSL_SDHC: 1, FSL_SDHC: 0
Loading Environment from MMC... MMC Device 2 not found
*** Warning - No MMC card found, using default environment
...
=> env default -f -a
## Resetting to default environment
=> env save
Saving Environment to MMC... MMC Device 2 not found
No MMC card found
Failed (1)

FYI, with a git revert -s 34f2feb92db6146831bafa696b7b46785c9f6b10,
all is working fine:

=> env default -f -a
## Resetting to default environment
=> env save
Saving Environment to MMC... Writing to MMC(0)... OK

So, can you consider this commit 'not applicable' for 2019.10 ?

BR

[1] - 
https://github.com/sbabic/u-boot-imx/commit/34f2feb92db6146831bafa696b7b46785c9f6b10
-- 
Pierre-Jean Texier
Embedded Linux Engineer
https://koncepto.io

[U-Boot] [u-boot-imx/next] WaRP7 & Pico-Pi i.MX7 NOK

[Stefano Babic]

Hi Pierre-Jen,

On 07/10/19 20:44, Pierre-Jean Texier wrote:
> Stefano, Peng,
> 
> I just compiled a fresh U-Boot with u-boot-imx/next and It looks
> like commit 34f2feb ("imx: mmc_env: update runtime SD/MMC boot env
> device") [1]
> breaks my WaRP7 (but the same for the Pico-Pi i.MX7, tested by Joris in
> CC),
> see logs after:
> 
> U-Boot 2019.10-rc4-00232-gd03193d (Oct 07 2019 - 18:44:25 +0200)
> 
> CPU:   Freescale i.MX7S rev1.2 800 MHz (running at 792 MHz)
> CPU:   Extended Commercial temperature grade (-20C to 105C) at 33C
> Reset cause: POR
> Model: Warp i.MX7 Board
> Board: WARP7 in secure mode OPTEE DRAM 0x9d000000-0xa0000000
> DRAM:  464 MiB
> MMC:   FSL_SDHC: 1, FSL_SDHC: 0
> Loading Environment from MMC... MMC Device 2 not found
> *** Warning - No MMC card found, using default environment
> ...
> => env default -f -a
> ## Resetting to default environment
> => env save
> Saving Environment to MMC... MMC Device 2 not found
> No MMC card found
> Failed (1)
> 
> FYI, with a git revert -s 34f2feb92db6146831bafa696b7b46785c9f6b10,
> all is working fine:
> 

Thanks for testing - at the moment, I will drop it from -next.

> => env default -f -a
> ## Resetting to default environment
> => env save
> Saving Environment to MMC... Writing to MMC(0)... OK
> 
> So, can you consider this commit 'not applicable' for 2019.10 ?
> 

None of what you see in -next is for 2019.10. My last PR had already too
many patches and it cannot flow into 2019.10. Currently, -next has ~130
new commit, it cannot flow into the release - I will send PR afterwards.

Best regards,
Stefano


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

[U-Boot] [u-boot-imx/next] WaRP7 & Pico-Pi i.MX7 NOK

[Pierre-Jean Texier]

Hi Stefano,

Le 07/10/2019 à 21:58, Stefano Babic a écrit :
> Hi Pierre-Jen,
> 
> On 07/10/19 20:44, Pierre-Jean Texier wrote:
>> Stefano, Peng,
>>
>> I just compiled a fresh U-Boot with u-boot-imx/next and It looks
>> like commit 34f2feb ("imx: mmc_env: update runtime SD/MMC boot env
>> device") [1]
>> breaks my WaRP7 (but the same for the Pico-Pi i.MX7, tested by Joris in
>> CC),
>> see logs after:
>>
>> U-Boot 2019.10-rc4-00232-gd03193d (Oct 07 2019 - 18:44:25 +0200)
>>
>> CPU:   Freescale i.MX7S rev1.2 800 MHz (running at 792 MHz)
>> CPU:   Extended Commercial temperature grade (-20C to 105C) at 33C
>> Reset cause: POR
>> Model: Warp i.MX7 Board
>> Board: WARP7 in secure mode OPTEE DRAM 0x9d000000-0xa0000000
>> DRAM:  464 MiB
>> MMC:   FSL_SDHC: 1, FSL_SDHC: 0
>> Loading Environment from MMC... MMC Device 2 not found
>> *** Warning - No MMC card found, using default environment
>> ...
>> => env default -f -a
>> ## Resetting to default environment
>> => env save
>> Saving Environment to MMC... MMC Device 2 not found
>> No MMC card found
>> Failed (1)
>>
>> FYI, with a git revert -s 34f2feb92db6146831bafa696b7b46785c9f6b10,
>> all is working fine:
>>
> 
> Thanks for testing - at the moment, I will drop it from -next.

No problem - thanks, I will update my repo after that.

> 
>> => env default -f -a
>> ## Resetting to default environment
>> => env save
>> Saving Environment to MMC... Writing to MMC(0)... OK
>>
>> So, can you consider this commit 'not applicable' for 2019.10 ?
>>
> 
> None of what you see in -next is for 2019.10. My last PR had already too
> many patches and it cannot flow into 2019.10. Currently, -next has ~130
> new commit, it cannot flow into the release - I will send PR afterwards.

Understood, thanks for the clarification :).

BR,

Pierre-Jean

> 
> Best regards,
> Stefano
> 
> 

-- 
Pierre-Jean Texier
Embedded Linux Engineer
https://koncepto.io

[U-Boot] [u-boot-imx/next] WaRP7 & Pico-Pi i.MX7 NOK

[Stefano Babic]

On 07/10/19 22:26, Pierre-Jean Texier wrote:
> Hi Stefano,
> 
> Le 07/10/2019 à 21:58, Stefano Babic a écrit :
>> Hi Pierre-Jen,
>>
>> On 07/10/19 20:44, Pierre-Jean Texier wrote:
>>> Stefano, Peng,
>>>
>>> I just compiled a fresh U-Boot with u-boot-imx/next and It looks
>>> like commit 34f2feb ("imx: mmc_env: update runtime SD/MMC boot env
>>> device") [1]
>>> breaks my WaRP7 (but the same for the Pico-Pi i.MX7, tested by Joris in
>>> CC),
>>> see logs after:
>>>
>>> U-Boot 2019.10-rc4-00232-gd03193d (Oct 07 2019 - 18:44:25 +0200)
>>>
>>> CPU:   Freescale i.MX7S rev1.2 800 MHz (running at 792 MHz)
>>> CPU:   Extended Commercial temperature grade (-20C to 105C) at 33C
>>> Reset cause: POR
>>> Model: Warp i.MX7 Board
>>> Board: WARP7 in secure mode OPTEE DRAM 0x9d000000-0xa0000000
>>> DRAM:  464 MiB
>>> MMC:   FSL_SDHC: 1, FSL_SDHC: 0
>>> Loading Environment from MMC... MMC Device 2 not found
>>> *** Warning - No MMC card found, using default environment
>>> ...
>>> => env default -f -a
>>> ## Resetting to default environment
>>> => env save
>>> Saving Environment to MMC... MMC Device 2 not found
>>> No MMC card found
>>> Failed (1)
>>>
>>> FYI, with a git revert -s 34f2feb92db6146831bafa696b7b46785c9f6b10,
>>> all is working fine:
>>>
>>
>> Thanks for testing - at the moment, I will drop it from -next.
> 
> No problem - thanks, I will update my repo after that.
> 
>>
>>> => env default -f -a
>>> ## Resetting to default environment
>>> => env save
>>> Saving Environment to MMC... Writing to MMC(0)... OK
>>>
>>> So, can you consider this commit 'not applicable' for 2019.10 ?
>>>
>>
>> None of what you see in -next is for 2019.10. My last PR had already too
>> many patches and it cannot flow into 2019.10. Currently, -next has ~130
>> new commit, it cannot flow into the release - I will send PR afterwards.
> 
> Understood, thanks for the clarification :).
> 


Anyway, Peng's patch is not wrong, he simply tried to avoid to add board
code. But I left this out to avoid further breakages - I guess Peng
should send a folow up patch to add board code to imx8m.

Regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================