From: Hans de Goede <hdegoede@redhat.com>
To: Coiby Xu <coiby.xu@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Nehal Shah <Nehal-bakulchandra.Shah@amd.com>,
Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: Any other ways to debug GPIO interrupt controller (pinctrl-amd) for broken touchpads of a new laptop model?
Date: Fri, 2 Oct 2020 21:44:54 +0200 [thread overview]
Message-ID: <eed704f5-4210-788c-37b7-06d65b58d3de@redhat.com> (raw)
In-Reply-To: <20201002145133.a43ypm2z7ofgtt7u@Rk>
Hi,
On 10/2/20 4:51 PM, Coiby Xu wrote:
> On Fri, Oct 02, 2020 at 03:36:29PM +0200, Hans de Goede wrote:
<snip>
>>>> So are you seeing these 7 interrupts / second for the touchpad irq or for
>>>> the GPIO controllers parent irq ?
>>>>
>>>> Also to these 7 interrupts/sec stop happening when you do not touch the
>>>> touchpad ?
>>>>
>>> I see these 7 interrupts / second for the GPIO controller's parent irq.
>>> And they stop happening when I don't touch the touchpad.
>>
>> Only from the parent irq, or also on the touchpad irq itself ?
>>
>> If this only happens on the parent irq, then I would start looking at the
>> amd-pinctrl code which determines which of its "child" irqs to fire.
>
> This only happens on the parent irq. The input's pin#130 of the GIPO
> chip is low most of the time and pin#130.
Right, but it is a low-level triggered IRQ, so when it is low it should
be executing the i2c-hid interrupt-handler. If it is not executing that
then it is time to look at amd-pinctrl's irq-handler and figure out why
that is not triggering the child irq handler for the touchpad.
Regards,
Hans
WARNING: multiple messages have this Message-ID (diff)
From: Hans de Goede <hdegoede@redhat.com>
To: Coiby Xu <coiby.xu@gmail.com>
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
Nehal Shah <Nehal-bakulchandra.Shah@amd.com>,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] Any other ways to debug GPIO interrupt controller (pinctrl-amd) for broken touchpads of a new laptop model?
Date: Fri, 2 Oct 2020 21:44:54 +0200 [thread overview]
Message-ID: <eed704f5-4210-788c-37b7-06d65b58d3de@redhat.com> (raw)
In-Reply-To: <20201002145133.a43ypm2z7ofgtt7u@Rk>
Hi,
On 10/2/20 4:51 PM, Coiby Xu wrote:
> On Fri, Oct 02, 2020 at 03:36:29PM +0200, Hans de Goede wrote:
<snip>
>>>> So are you seeing these 7 interrupts / second for the touchpad irq or for
>>>> the GPIO controllers parent irq ?
>>>>
>>>> Also to these 7 interrupts/sec stop happening when you do not touch the
>>>> touchpad ?
>>>>
>>> I see these 7 interrupts / second for the GPIO controller's parent irq.
>>> And they stop happening when I don't touch the touchpad.
>>
>> Only from the parent irq, or also on the touchpad irq itself ?
>>
>> If this only happens on the parent irq, then I would start looking at the
>> amd-pinctrl code which determines which of its "child" irqs to fire.
>
> This only happens on the parent irq. The input's pin#130 of the GIPO
> chip is low most of the time and pin#130.
Right, but it is a low-level triggered IRQ, so when it is low it should
be executing the i2c-hid interrupt-handler. If it is not executing that
then it is time to look at amd-pinctrl's irq-handler and figure out why
that is not triggering the child irq handler for the touchpad.
Regards,
Hans
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-10-02 19:45 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 13:22 Any other ways to debug GPIO interrupt controller (pinctrl-amd) for broken touchpads of a new laptop model? Coiby Xu
2020-10-01 13:22 ` [Linux-kernel-mentees] " Coiby Xu
2020-10-01 20:57 ` Linus Walleij
2020-10-01 20:57 ` [Linux-kernel-mentees] " Linus Walleij
2020-10-02 9:40 ` Hans de Goede
2020-10-02 9:40 ` [Linux-kernel-mentees] " Hans de Goede
2020-10-02 12:42 ` Coiby Xu
2020-10-02 12:42 ` [Linux-kernel-mentees] " Coiby Xu
2020-10-02 13:36 ` Hans de Goede
2020-10-02 13:36 ` [Linux-kernel-mentees] " Hans de Goede
2020-10-02 14:51 ` Coiby Xu
2020-10-02 14:51 ` [Linux-kernel-mentees] " Coiby Xu
2020-10-02 19:44 ` Hans de Goede [this message]
2020-10-02 19:44 ` Hans de Goede
2020-10-02 22:45 ` Coiby Xu
2020-10-02 22:45 ` [Linux-kernel-mentees] " Coiby Xu
2020-10-03 13:22 ` Hans de Goede
2020-10-03 13:22 ` [Linux-kernel-mentees] " Hans de Goede
2020-10-03 23:03 ` Coiby Xu
2020-10-03 23:03 ` [Linux-kernel-mentees] " Coiby Xu
2020-10-04 5:16 ` Coiby Xu
2020-10-04 5:16 ` [Linux-kernel-mentees] " Coiby Xu
2020-10-06 4:49 ` Coiby Xu
2020-10-06 4:49 ` [Linux-kernel-mentees] " Coiby Xu
2020-10-06 6:28 ` Hans de Goede
2020-10-06 6:28 ` [Linux-kernel-mentees] " Hans de Goede
2020-10-06 8:31 ` Coiby Xu
2020-10-06 8:31 ` [Linux-kernel-mentees] " Coiby Xu
2020-10-06 8:55 ` Hans de Goede
2020-10-06 8:55 ` [Linux-kernel-mentees] " Hans de Goede
2020-10-06 9:28 ` Hans de Goede
2020-10-06 9:28 ` [Linux-kernel-mentees] " Hans de Goede
2020-10-06 9:29 ` Hans de Goede
2020-10-06 9:29 ` [Linux-kernel-mentees] " Hans de Goede
2020-10-08 16:32 ` Coiby Xu
2020-10-08 16:32 ` [Linux-kernel-mentees] " Coiby Xu
2020-10-14 4:24 ` Coiby Xu
2020-10-14 4:24 ` [Linux-kernel-mentees] " Coiby Xu
2020-10-14 11:34 ` Coiby Xu
2020-10-14 11:34 ` [Linux-kernel-mentees] " Coiby Xu
2020-10-14 11:46 ` Hans de Goede
2020-10-14 11:46 ` [Linux-kernel-mentees] " Hans de Goede
2020-10-15 3:27 ` Coiby Xu
2020-10-15 3:27 ` [Linux-kernel-mentees] " Coiby Xu
2020-10-15 4:06 ` Coiby Xu
2020-10-15 4:06 ` [Linux-kernel-mentees] " Coiby Xu
2020-10-26 22:54 ` Coiby Xu
2020-10-26 22:54 ` [Linux-kernel-mentees] " Coiby Xu
2020-10-27 9:52 ` Andy Shevchenko
2020-10-27 9:52 ` [Linux-kernel-mentees] " Andy Shevchenko
2020-10-30 4:58 ` Coiby Xu
2020-10-30 4:58 ` [Linux-kernel-mentees] " Coiby Xu
2020-10-27 10:09 ` Hans de Goede
2020-10-27 10:09 ` [Linux-kernel-mentees] " Hans de Goede
2020-10-27 15:13 ` Andy Shevchenko
2020-10-27 15:13 ` [Linux-kernel-mentees] " Andy Shevchenko
2020-10-27 16:00 ` Hans de Goede
2020-10-27 16:00 ` [Linux-kernel-mentees] " Hans de Goede
2020-10-27 16:09 ` Andy Shevchenko
2020-10-27 16:09 ` [Linux-kernel-mentees] " Andy Shevchenko
2020-10-29 8:04 ` Mika Westerberg
2020-10-29 8:04 ` [Linux-kernel-mentees] " Mika Westerberg
2020-10-30 4:54 ` Coiby Xu
2020-10-30 4:54 ` [Linux-kernel-mentees] " Coiby Xu
2020-11-02 19:06 ` Andy Shevchenko
2020-11-02 19:06 ` [Linux-kernel-mentees] " Andy Shevchenko
2020-11-02 22:56 ` Coiby Xu
2020-11-02 22:56 ` [Linux-kernel-mentees] " Coiby Xu
2020-11-03 0:05 ` Coiby Xu
2020-11-03 0:05 ` [Linux-kernel-mentees] " Coiby Xu
2020-11-03 10:12 ` Hans de Goede
2020-11-03 10:12 ` [Linux-kernel-mentees] " Hans de Goede
2020-11-03 10:49 ` Andy Shevchenko
2020-11-03 10:49 ` [Linux-kernel-mentees] " Andy Shevchenko
2020-11-03 11:00 ` Hans de Goede
2020-11-03 11:00 ` [Linux-kernel-mentees] " Hans de Goede
2020-10-08 16:26 ` Coiby Xu
2020-10-08 16:26 ` [Linux-kernel-mentees] " Coiby Xu
2020-10-06 9:16 ` Linus Walleij
2020-10-06 9:16 ` [Linux-kernel-mentees] " Linus Walleij
2020-10-08 16:40 ` Coiby Xu
2020-10-08 16:40 ` [Linux-kernel-mentees] " Coiby Xu
2020-10-02 10:59 ` Coiby Xu
2020-10-02 10:59 ` [Linux-kernel-mentees] " Coiby Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eed704f5-4210-788c-37b7-06d65b58d3de@redhat.com \
--to=hdegoede@redhat.com \
--cc=Nehal-bakulchandra.Shah@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=coiby.xu@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.