All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Talbot <chris@talbothome.com>
To: ofono@ofono.org, netdev@vger.kernel.org,
	debian-on-mobile-maintainers@alioth-lists.debian.net,
	librem-5-dev@lists.community.puri.sm
Subject: [PATCH 4/9] Fix issue if there is an empty string in encoded text
Date: Sat, 10 Apr 2021 10:21:21 -0400	[thread overview]
Message-ID: <eee886683aa0cbf57ec3f0c8637ba02bc01600d6.camel@talbothome.com> (raw)
In-Reply-To: <178dd29027e6abb4a205e25c02f06769848cbb76.camel@talbothome.com>

A swedish carrier sends an empty string in the subject line. This
patch allows mmsd to handle it
---
 src/mmsutil.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/mmsutil.c b/src/mmsutil.c
index 9430bf1..615198f 100644
--- a/src/mmsutil.c
+++ b/src/mmsutil.c
@@ -297,6 +297,13 @@ static gboolean extract_encoded_text(struct
wsp_header_iter *iter, void *user)
 	p = wsp_header_iter_get_val(iter);
 	l = wsp_header_iter_get_val_len(iter);
 
+	if(l == 0) {
+		DBG("Length is 0! Returning empty string");
+		dec_text = g_strdup("");
+		*out = dec_text;
+		return TRUE;
+	}
+
 	switch (wsp_header_iter_get_val_type(iter)) {
 	case WSP_VALUE_TYPE_TEXT:
 		/* Text-string */
-- 
2.30.2


WARNING: multiple messages have this Message-ID (diff)
From: Chris Talbot <chris@talbothome.com>
To: ofono@ofono.org
Subject: [PATCH 4/9] Fix issue if there is an empty string in encoded text
Date: Sat, 10 Apr 2021 10:21:21 -0400	[thread overview]
Message-ID: <eee886683aa0cbf57ec3f0c8637ba02bc01600d6.camel@talbothome.com> (raw)
In-Reply-To: <178dd29027e6abb4a205e25c02f06769848cbb76.camel@talbothome.com>

[-- Attachment #1: Type: text/plain, Size: 722 bytes --]

A swedish carrier sends an empty string in the subject line. This
patch allows mmsd to handle it
---
 src/mmsutil.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/mmsutil.c b/src/mmsutil.c
index 9430bf1..615198f 100644
--- a/src/mmsutil.c
+++ b/src/mmsutil.c
@@ -297,6 +297,13 @@ static gboolean extract_encoded_text(struct
wsp_header_iter *iter, void *user)
 	p = wsp_header_iter_get_val(iter);
 	l = wsp_header_iter_get_val_len(iter);
 
+	if(l == 0) {
+		DBG("Length is 0! Returning empty string");
+		dec_text = g_strdup("");
+		*out = dec_text;
+		return TRUE;
+	}
+
 	switch (wsp_header_iter_get_val_type(iter)) {
 	case WSP_VALUE_TYPE_TEXT:
 		/* Text-string */
-- 
2.30.2

  reply	other threads:[~2021-04-10 14:22 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-10 14:13 [PATCH 0/9] Updates for mmsd Chris Talbot
2021-04-10 14:13 ` Chris Talbot
2021-04-10 14:17 ` [PATCH 1/9] Fix mmsd to work with T-mobile Chris Talbot
2021-04-10 14:17   ` Chris Talbot
2021-04-10 14:20   ` [PATCH 2/9] Ensure Compatibility with Telus Canada Chris Talbot
2021-04-10 14:20     ` Chris Talbot
2021-04-10 14:20     ` [PATCH 3/9] Ensure Compatibility with AT&T Chris Talbot
2021-04-10 14:20       ` Chris Talbot
2021-04-10 14:21       ` Chris Talbot [this message]
2021-04-10 14:21         ` [PATCH 4/9] Fix issue if there is an empty string in encoded text Chris Talbot
2021-04-10 14:22         ` [PATCH 5/9] Allow for a user configurable maximum attachment size Chris Talbot
2021-04-10 14:22           ` Chris Talbot
2021-04-10 14:22           ` [PATCH 6/9] Update README Chris Talbot
2021-04-10 14:22             ` Chris Talbot
2021-04-10 14:23             ` [PATCH 7/9] Fix Draft and Sent Bugs Chris Talbot
2021-04-10 14:23               ` Chris Talbot
2021-04-10 14:23               ` [PATCH 8/9] Allow Maintainer mode to compile without -WError Chris Talbot
2021-04-10 14:23                 ` Chris Talbot
2021-04-10 14:24                 ` [PATCH 9/9] Enable support for Modem Manager Chris Talbot
2021-04-10 14:24                   ` Chris Talbot
2021-04-14 18:21 ` Forking on MMSD Chris Talbot
2021-04-14 18:21   ` Chris Talbot
2021-04-14 18:30   ` [Debian-on-mobile-maintainers] " Guido Günther
2021-04-14 18:46     ` Chris Talbot
2021-04-15  9:10       ` Guido Günther
2021-04-14 18:39   ` Marius Gripsgard
2021-04-14 18:39     ` Marius Gripsgard
2021-04-14 22:09     ` Bug#985893: " Wookey
2021-04-15  0:12       ` Chris Talbot
2021-04-14 19:29   ` Pavel Machek
2021-04-14 19:29     ` Pavel Machek
2021-04-14 21:11     ` Bug#985893: " Paul Wise
     [not found]     ` <c7ffd7e4d62e5d5ed397f69be180d81588a4cfd1.camel@talbothome.com>
2021-04-14 22:58       ` Pavel Machek
2021-04-14 22:58         ` Pavel Machek
2021-04-15  0:01         ` Chris Talbot
2021-04-27  9:15           ` Pavel Machek
2021-04-27  9:15             ` Pavel Machek
2021-04-29 14:49             ` Chris Talbot
2021-05-18  3:56             ` hoangnambohung
  -- strict thread matches above, loose matches on Subject: below --
2021-03-26 10:50 [PATCH 4/9] Fix issue if there is an empty string in encoded text Christopher Talbot
2021-02-25  0:39 Patches For MMSD chris
2021-02-25  0:45 ` [PATCH 4/9] Fix issue if there is an empty string in encoded text Christopher Talbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eee886683aa0cbf57ec3f0c8637ba02bc01600d6.camel@talbothome.com \
    --to=chris@talbothome.com \
    --cc=debian-on-mobile-maintainers@alioth-lists.debian.net \
    --cc=librem-5-dev@lists.community.puri.sm \
    --cc=netdev@vger.kernel.org \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.