* [PATCH] sound: soc: codecs: wcd9335: fix "conversion to bool not needed here"
@ 2019-07-11 17:49 Hariprasad Kelam
2019-07-11 22:00 ` Joe Perches
0 siblings, 1 reply; 4+ messages in thread
From: Hariprasad Kelam @ 2019-07-11 17:49 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Srinivas Kandagatla, Vinod Koul, Wen Yang, Gen Zhang,
Hariprasad Kelam, Dan Carpenter, alsa-devel, linux-kernel
Fix below issue reported by coccicheck
sound/soc/codecs/wcd9335.c:3991:25-30: WARNING: conversion to bool not
needed here
Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
---
sound/soc/codecs/wcd9335.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c
index 1bbbe42..85a8d10 100644
--- a/sound/soc/codecs/wcd9335.c
+++ b/sound/soc/codecs/wcd9335.c
@@ -3988,12 +3988,7 @@ static irqreturn_t wcd9335_slimbus_irq(int irq, void *data)
regmap_read(wcd->if_regmap,
WCD9335_SLIM_PGD_PORT_INT_RX_SOURCE0 + j, &val);
if (val) {
- if (!tx)
- reg = WCD9335_SLIM_PGD_PORT_INT_EN0 +
- (port_id / 8);
- else
- reg = WCD9335_SLIM_PGD_PORT_INT_TX_EN0 +
- (port_id / 8);
+ reg = WCD9335_SLIM_PGD_PORT_INT_TX_EN0 + (port_id / 8);
regmap_read(
wcd->if_regmap, reg, &int_val);
/*
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] sound: soc: codecs: wcd9335: fix "conversion to bool not needed here"
2019-07-11 17:49 [PATCH] sound: soc: codecs: wcd9335: fix "conversion to bool not needed here" Hariprasad Kelam
@ 2019-07-11 22:00 ` Joe Perches
2019-07-13 13:46 ` Hariprasad Kelam
2019-07-13 13:50 ` Hariprasad Kelam
0 siblings, 2 replies; 4+ messages in thread
From: Joe Perches @ 2019-07-11 22:00 UTC (permalink / raw)
To: Hariprasad Kelam, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Srinivas Kandagatla, Vinod Koul, Wen Yang,
Gen Zhang, Dan Carpenter, alsa-devel, linux-kernel
On Thu, 2019-07-11 at 23:19 +0530, Hariprasad Kelam wrote:
> Fix below issue reported by coccicheck
> sound/soc/codecs/wcd9335.c:3991:25-30: WARNING: conversion to bool not
> needed here
>
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
> ---
> sound/soc/codecs/wcd9335.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c
> index 1bbbe42..85a8d10 100644
> --- a/sound/soc/codecs/wcd9335.c
> +++ b/sound/soc/codecs/wcd9335.c
> @@ -3988,12 +3988,7 @@ static irqreturn_t wcd9335_slimbus_irq(int irq, void *data)
> regmap_read(wcd->if_regmap,
> WCD9335_SLIM_PGD_PORT_INT_RX_SOURCE0 + j, &val);
> if (val) {
> - if (!tx)
> - reg = WCD9335_SLIM_PGD_PORT_INT_EN0 +
> - (port_id / 8);
> - else
> - reg = WCD9335_SLIM_PGD_PORT_INT_TX_EN0 +
> - (port_id / 8);
> + reg = WCD9335_SLIM_PGD_PORT_INT_TX_EN0 + (port_id / 8);
> regmap_read(
> wcd->if_regmap, reg, &int_val);
> /*
This change makes no sense and doesn't match the commit message.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] sound: soc: codecs: wcd9335: fix "conversion to bool not needed here"
2019-07-11 22:00 ` Joe Perches
@ 2019-07-13 13:46 ` Hariprasad Kelam
2019-07-13 13:50 ` Hariprasad Kelam
1 sibling, 0 replies; 4+ messages in thread
From: Hariprasad Kelam @ 2019-07-13 13:46 UTC (permalink / raw)
To: Joe Perches, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Srinivas Kandagatla, Vinod Koul, Wen Yang,
Gen Zhang, Dan Carpenter, alsa-devel, linux-kernel
On Thu, Jul 11, 2019 at 03:00:00PM -0700, Joe Perches wrote:
> On Thu, 2019-07-11 at 23:19 +0530, Hariprasad Kelam wrote:
> > Fix below issue reported by coccicheck
> > sound/soc/codecs/wcd9335.c:3991:25-30: WARNING: conversion to bool not
> > needed here
> >
> > Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
> > ---
> > sound/soc/codecs/wcd9335.c | 7 +------
> > 1 file changed, 1 insertion(+), 6 deletions(-)
> >
> > diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c
> > index 1bbbe42..85a8d10 100644
> > --- a/sound/soc/codecs/wcd9335.c
> > +++ b/sound/soc/codecs/wcd9335.c
> > @@ -3988,12 +3988,7 @@ static irqreturn_t wcd9335_slimbus_irq(int irq, void *data)
> > regmap_read(wcd->if_regmap,
> > WCD9335_SLIM_PGD_PORT_INT_RX_SOURCE0 + j, &val);
> > if (val) {
> > - if (!tx)
> > - reg = WCD9335_SLIM_PGD_PORT_INT_EN0 +
> > - (port_id / 8);
> > - else
> > - reg = WCD9335_SLIM_PGD_PORT_INT_TX_EN0 +
> > - (port_id / 8);
> > + reg = WCD9335_SLIM_PGD_PORT_INT_TX_EN0 + (port_id / 8);
> > regmap_read(
> > wcd->if_regmap, reg, &int_val);
> > /*
>
> This change makes no sense and doesn't match the commit message.
>
> Please ignore this patch.
> Both statments in if/else loop looked
> similar to me but they are different.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] sound: soc: codecs: wcd9335: fix "conversion to bool not needed here"
2019-07-11 22:00 ` Joe Perches
2019-07-13 13:46 ` Hariprasad Kelam
@ 2019-07-13 13:50 ` Hariprasad Kelam
1 sibling, 0 replies; 4+ messages in thread
From: Hariprasad Kelam @ 2019-07-13 13:50 UTC (permalink / raw)
To: Joe Perches, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Srinivas Kandagatla, Vinod Koul, Wen Yang,
Gen Zhang, Dan Carpenter, alsa-devel, linux-kernel
On Thu, Jul 11, 2019 at 03:00:00PM -0700, Joe Perches wrote:
> On Thu, 2019-07-11 at 23:19 +0530, Hariprasad Kelam wrote:
> > Fix below issue reported by coccicheck
> > sound/soc/codecs/wcd9335.c:3991:25-30: WARNING: conversion to bool not
> > needed here
> >
> > Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
> > ---
> > sound/soc/codecs/wcd9335.c | 7 +------
> > 1 file changed, 1 insertion(+), 6 deletions(-)
> >
> > diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c
> > index 1bbbe42..85a8d10 100644
> > --- a/sound/soc/codecs/wcd9335.c
> > +++ b/sound/soc/codecs/wcd9335.c
> > @@ -3988,12 +3988,7 @@ static irqreturn_t wcd9335_slimbus_irq(int irq, void *data)
> > regmap_read(wcd->if_regmap,
> > WCD9335_SLIM_PGD_PORT_INT_RX_SOURCE0 + j, &val);
> > if (val) {
> > - if (!tx)
> > - reg = WCD9335_SLIM_PGD_PORT_INT_EN0 +
> > - (port_id / 8);
> > - else
> > - reg = WCD9335_SLIM_PGD_PORT_INT_TX_EN0 +
> > - (port_id / 8);
> > + reg = WCD9335_SLIM_PGD_PORT_INT_TX_EN0 + (port_id / 8);
> > regmap_read(
> > wcd->if_regmap, reg, &int_val);
> > /*
>
> This change makes no sense and doesn't match the commit message.
>
>Please ignore this patch. Both the statments in if/else look similar to
>me but they are not.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-07-13 13:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-11 17:49 [PATCH] sound: soc: codecs: wcd9335: fix "conversion to bool not needed here" Hariprasad Kelam
2019-07-11 22:00 ` Joe Perches
2019-07-13 13:46 ` Hariprasad Kelam
2019-07-13 13:50 ` Hariprasad Kelam
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.