All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eelco Chaudron <echaudro@redhat.com>
To: Olivier MATZ <olivier.matz@6wind.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
	dev@dpdk.org, jingjing.wu@intel.com
Subject: Re: [PATCH] app/testpmd: adds mlockall() to fix pages
Date: Fri, 29 Sep 2017 09:59:38 +0200	[thread overview]
Message-ID: <eeec1767-b0f6-0aad-92be-85b136181113@redhat.com> (raw)
In-Reply-To: <20170925075319.agzytjfgai7usngs@platinum>

On 25/09/17 09:53, Olivier MATZ wrote:
>> [SNIP]
>> I did not at add a log, as the rte log subsystem is not yet initialized.
>> However we could add a printf("WARNING: mlockall() failed with error %s")
>> like message. What do you think?
> Since it's not critical, maybe NOTICE is better than WARNING.
>
> One more question: what would be the drawback of calling
> mlockall() after eal_init()? (rte_log would be initialized)
>
Calling mlockall() after eal_init() does seem to have the same effect.
I'll send out a v2 patch later today with a rte_log(NOTICE).

  reply	other threads:[~2017-09-29  7:59 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-12 13:08 [PATCH] app/testpmd: adds mlockall() to fix pages Eelco Chaudron
2017-09-12 14:50 ` Aaron Conole
2017-09-12 20:14   ` Thomas Monjalon
2017-09-12 20:29     ` Aaron Conole
2017-09-12 22:13       ` Thomas Monjalon
2017-09-13  8:55         ` Eelco Chaudron
2017-09-13 12:28         ` Aaron Conole
2017-09-13  9:15 ` Maxime Coquelin
2017-09-13  9:39 ` Thomas Monjalon
2017-09-14  7:22   ` Eelco Chaudron
2017-09-19  7:28     ` Olivier MATZ
2017-09-21 12:24       ` Eelco Chaudron
2017-09-25  7:53         ` Olivier MATZ
2017-09-29  7:59           ` Eelco Chaudron [this message]
2017-09-29  8:07 ` Sergio Gonzalez Monroy
2017-09-29  8:15   ` Eelco Chaudron
2017-09-29  9:27     ` Sergio Gonzalez Monroy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eeec1767-b0f6-0aad-92be-85b136181113@redhat.com \
    --to=echaudro@redhat.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    --cc=olivier.matz@6wind.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.