* [PATCH] usb: gadget: at91_udc: fix incorrect print type
@ 2022-01-19 2:08 ` Miles Chen
0 siblings, 0 replies; 4+ messages in thread
From: Miles Chen @ 2022-01-19 2:08 UTC (permalink / raw)
To: Felipe Balbi, Greg Kroah-Hartman, Nicolas Ferre,
Alexandre Belloni, Ludovic Desroches, Balamanikandan Gunasundar,
Matthias Brugger, Dan Sneddon
Cc: linux-usb, linux-arm-kernel, linux-kernel, linux-mediatek, Miles Chen
Fix a build error observed with ARCH=arm DEFCONFIG=allmodconfig build.
drivers/usb/gadget/udc/at91_udc.h:174:42: error: format '%d' expects argument of type 'int', but argument 3 has type 'struct gpio_desc *' [-Werror=format=]
Fixes: 4a555f2b8d31 ("usb: gadget: at91_udc: Convert to GPIO descriptors")
Signed-off-by: Miles Chen <miles.chen@mediatek.com>
---
drivers/usb/gadget/udc/at91_udc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/at91_udc.c b/drivers/usb/gadget/udc/at91_udc.c
index dd0819df096e..9040a0561466 100644
--- a/drivers/usb/gadget/udc/at91_udc.c
+++ b/drivers/usb/gadget/udc/at91_udc.c
@@ -1895,7 +1895,7 @@ static int at91udc_probe(struct platform_device *pdev)
at91_vbus_irq, 0, driver_name, udc);
if (retval) {
DBG("request vbus irq %d failed\n",
- udc->board.vbus_pin);
+ desc_to_gpio(udc->board.vbus_pin));
goto err_unprepare_iclk;
}
}
--
2.18.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] usb: gadget: at91_udc: fix incorrect print type
@ 2022-01-19 2:08 ` Miles Chen
0 siblings, 0 replies; 4+ messages in thread
From: Miles Chen @ 2022-01-19 2:08 UTC (permalink / raw)
To: Felipe Balbi, Greg Kroah-Hartman, Nicolas Ferre,
Alexandre Belloni, Ludovic Desroches, Balamanikandan Gunasundar,
Matthias Brugger, Dan Sneddon
Cc: linux-usb, linux-arm-kernel, linux-kernel, linux-mediatek, Miles Chen
Fix a build error observed with ARCH=arm DEFCONFIG=allmodconfig build.
drivers/usb/gadget/udc/at91_udc.h:174:42: error: format '%d' expects argument of type 'int', but argument 3 has type 'struct gpio_desc *' [-Werror=format=]
Fixes: 4a555f2b8d31 ("usb: gadget: at91_udc: Convert to GPIO descriptors")
Signed-off-by: Miles Chen <miles.chen@mediatek.com>
---
drivers/usb/gadget/udc/at91_udc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/at91_udc.c b/drivers/usb/gadget/udc/at91_udc.c
index dd0819df096e..9040a0561466 100644
--- a/drivers/usb/gadget/udc/at91_udc.c
+++ b/drivers/usb/gadget/udc/at91_udc.c
@@ -1895,7 +1895,7 @@ static int at91udc_probe(struct platform_device *pdev)
at91_vbus_irq, 0, driver_name, udc);
if (retval) {
DBG("request vbus irq %d failed\n",
- udc->board.vbus_pin);
+ desc_to_gpio(udc->board.vbus_pin));
goto err_unprepare_iclk;
}
}
--
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] usb: gadget: at91_udc: fix incorrect print type
@ 2022-01-19 2:08 ` Miles Chen
0 siblings, 0 replies; 4+ messages in thread
From: Miles Chen @ 2022-01-19 2:08 UTC (permalink / raw)
To: Felipe Balbi, Greg Kroah-Hartman, Nicolas Ferre,
Alexandre Belloni, Ludovic Desroches, Balamanikandan Gunasundar,
Matthias Brugger, Dan Sneddon
Cc: linux-usb, linux-arm-kernel, linux-kernel, linux-mediatek, Miles Chen
Fix a build error observed with ARCH=arm DEFCONFIG=allmodconfig build.
drivers/usb/gadget/udc/at91_udc.h:174:42: error: format '%d' expects argument of type 'int', but argument 3 has type 'struct gpio_desc *' [-Werror=format=]
Fixes: 4a555f2b8d31 ("usb: gadget: at91_udc: Convert to GPIO descriptors")
Signed-off-by: Miles Chen <miles.chen@mediatek.com>
---
drivers/usb/gadget/udc/at91_udc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/at91_udc.c b/drivers/usb/gadget/udc/at91_udc.c
index dd0819df096e..9040a0561466 100644
--- a/drivers/usb/gadget/udc/at91_udc.c
+++ b/drivers/usb/gadget/udc/at91_udc.c
@@ -1895,7 +1895,7 @@ static int at91udc_probe(struct platform_device *pdev)
at91_vbus_irq, 0, driver_name, udc);
if (retval) {
DBG("request vbus irq %d failed\n",
- udc->board.vbus_pin);
+ desc_to_gpio(udc->board.vbus_pin));
goto err_unprepare_iclk;
}
}
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: gadget: at91_udc: fix incorrect print type
2022-01-19 2:08 ` Miles Chen
(?)
(?)
@ 2022-01-19 3:52 ` Macpaul Lin
-1 siblings, 0 replies; 4+ messages in thread
From: Macpaul Lin @ 2022-01-19 3:52 UTC (permalink / raw)
To: Miles Chen, Felipe Balbi, Greg Kroah-Hartman, Nicolas Ferre,
Alexandre Belloni, Ludovic Desroches, Balamanikandan Gunasundar,
Matthias Brugger, Dan Sneddon
Cc: linux-usb, linux-arm-kernel, linux-kernel, linux-mediatek
On 1/19/22 10:08 AM, Miles Chen wrote:
> Fix a build error observed with ARCH=arm DEFCONFIG=allmodconfig build.
>
> drivers/usb/gadget/udc/at91_udc.h:174:42: error: format '%d' expects argument of type 'int', but argument 3 has type 'struct gpio_desc *' [-Werror=format=]
>
> Fixes: 4a555f2b8d31 ("usb: gadget: at91_udc: Convert to GPIO descriptors")
> Signed-off-by: Miles Chen <miles.chen@mediatek.com>
> ---
> drivers/usb/gadget/udc/at91_udc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/udc/at91_udc.c b/drivers/usb/gadget/udc/at91_udc.c
> index dd0819df096e..9040a0561466 100644
> --- a/drivers/usb/gadget/udc/at91_udc.c
> +++ b/drivers/usb/gadget/udc/at91_udc.c
> @@ -1895,7 +1895,7 @@ static int at91udc_probe(struct platform_device *pdev)
> at91_vbus_irq, 0, driver_name, udc);
> if (retval) {
> DBG("request vbus irq %d failed\n",
> - udc->board.vbus_pin);
> + desc_to_gpio(udc->board.vbus_pin));
> goto err_unprepare_iclk;
> }
> }
>
Reviewed-by: Macpaul Lin <macpaul.lin@mediatek.com>
Thanks!
Macpaul Lin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-01-19 3:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-19 2:08 [PATCH] usb: gadget: at91_udc: fix incorrect print type Miles Chen
2022-01-19 2:08 ` Miles Chen
2022-01-19 2:08 ` Miles Chen
2022-01-19 3:52 ` Macpaul Lin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.