From: Ralph Campbell <rcampbell@nvidia.com> To: "Christoph Hellwig" <hch@lst.de>, "Jérôme Glisse" <jglisse@redhat.com>, "Jason Gunthorpe" <jgg@mellanox.com>, "Ben Skeggs" <bskeggs@redhat.com> Cc: Bharata B Rao <bharata@linux.ibm.com>, Andrew Morton <akpm@linux-foundation.org>, <linux-mm@kvack.org>, <nouveau@lists.freedesktop.org>, <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 8/9] mm: remove the unused MIGRATE_PFN_DEVICE flag Date: Mon, 29 Jul 2019 16:31:21 -0700 [thread overview] Message-ID: <ef44f3bf-0f99-c76b-bf4b-6770545b5e38@nvidia.com> (raw) In-Reply-To: <20190729142843.22320-9-hch@lst.de> On 7/29/19 7:28 AM, Christoph Hellwig wrote: > No one ever checks this flag, and we could easily get that information > from the page if needed. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Ralph Campbell <rcampbell@nvidia.com> > --- > drivers/gpu/drm/nouveau/nouveau_dmem.c | 3 +-- > include/linux/migrate.h | 1 - > mm/migrate.c | 4 ++-- > 3 files changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/nouveau_dmem.c b/drivers/gpu/drm/nouveau/nouveau_dmem.c > index 6cb930755970..f04686a2c21f 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_dmem.c > +++ b/drivers/gpu/drm/nouveau/nouveau_dmem.c > @@ -582,8 +582,7 @@ static unsigned long nouveau_dmem_migrate_copy_one(struct nouveau_drm *drm, > *dma_addr)) > goto out_dma_unmap; > > - return migrate_pfn(page_to_pfn(dpage)) | > - MIGRATE_PFN_LOCKED | MIGRATE_PFN_DEVICE; > + return migrate_pfn(page_to_pfn(dpage)) | MIGRATE_PFN_LOCKED; > > out_dma_unmap: > dma_unmap_page(dev, *dma_addr, PAGE_SIZE, DMA_BIDIRECTIONAL); > diff --git a/include/linux/migrate.h b/include/linux/migrate.h > index 229153c2c496..8b46cfdb1a0e 100644 > --- a/include/linux/migrate.h > +++ b/include/linux/migrate.h > @@ -166,7 +166,6 @@ static inline int migrate_misplaced_transhuge_page(struct mm_struct *mm, > #define MIGRATE_PFN_MIGRATE (1UL << 1) > #define MIGRATE_PFN_LOCKED (1UL << 2) > #define MIGRATE_PFN_WRITE (1UL << 3) > -#define MIGRATE_PFN_DEVICE (1UL << 4) > #define MIGRATE_PFN_SHIFT 6 > > static inline struct page *migrate_pfn_to_page(unsigned long mpfn) > diff --git a/mm/migrate.c b/mm/migrate.c > index dc4e60a496f2..74735256e260 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -2237,8 +2237,8 @@ static int migrate_vma_collect_pmd(pmd_t *pmdp, > goto next; > > page = device_private_entry_to_page(entry); > - mpfn = migrate_pfn(page_to_pfn(page))| > - MIGRATE_PFN_DEVICE | MIGRATE_PFN_MIGRATE; > + mpfn = migrate_pfn(page_to_pfn(page)) | > + MIGRATE_PFN_MIGRATE; > if (is_write_device_private_entry(entry)) > mpfn |= MIGRATE_PFN_WRITE; > } else { >
WARNING: multiple messages have this Message-ID (diff)
From: Ralph Campbell <rcampbell@nvidia.com> To: "Christoph Hellwig" <hch@lst.de>, "Jérôme Glisse" <jglisse@redhat.com>, "Jason Gunthorpe" <jgg@mellanox.com>, "Ben Skeggs" <bskeggs@redhat.com> Cc: Bharata B Rao <bharata@linux.ibm.com>, Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 8/9] mm: remove the unused MIGRATE_PFN_DEVICE flag Date: Mon, 29 Jul 2019 16:31:21 -0700 [thread overview] Message-ID: <ef44f3bf-0f99-c76b-bf4b-6770545b5e38@nvidia.com> (raw) In-Reply-To: <20190729142843.22320-9-hch@lst.de> On 7/29/19 7:28 AM, Christoph Hellwig wrote: > No one ever checks this flag, and we could easily get that information > from the page if needed. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Ralph Campbell <rcampbell@nvidia.com> > --- > drivers/gpu/drm/nouveau/nouveau_dmem.c | 3 +-- > include/linux/migrate.h | 1 - > mm/migrate.c | 4 ++-- > 3 files changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/nouveau_dmem.c b/drivers/gpu/drm/nouveau/nouveau_dmem.c > index 6cb930755970..f04686a2c21f 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_dmem.c > +++ b/drivers/gpu/drm/nouveau/nouveau_dmem.c > @@ -582,8 +582,7 @@ static unsigned long nouveau_dmem_migrate_copy_one(struct nouveau_drm *drm, > *dma_addr)) > goto out_dma_unmap; > > - return migrate_pfn(page_to_pfn(dpage)) | > - MIGRATE_PFN_LOCKED | MIGRATE_PFN_DEVICE; > + return migrate_pfn(page_to_pfn(dpage)) | MIGRATE_PFN_LOCKED; > > out_dma_unmap: > dma_unmap_page(dev, *dma_addr, PAGE_SIZE, DMA_BIDIRECTIONAL); > diff --git a/include/linux/migrate.h b/include/linux/migrate.h > index 229153c2c496..8b46cfdb1a0e 100644 > --- a/include/linux/migrate.h > +++ b/include/linux/migrate.h > @@ -166,7 +166,6 @@ static inline int migrate_misplaced_transhuge_page(struct mm_struct *mm, > #define MIGRATE_PFN_MIGRATE (1UL << 1) > #define MIGRATE_PFN_LOCKED (1UL << 2) > #define MIGRATE_PFN_WRITE (1UL << 3) > -#define MIGRATE_PFN_DEVICE (1UL << 4) > #define MIGRATE_PFN_SHIFT 6 > > static inline struct page *migrate_pfn_to_page(unsigned long mpfn) > diff --git a/mm/migrate.c b/mm/migrate.c > index dc4e60a496f2..74735256e260 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -2237,8 +2237,8 @@ static int migrate_vma_collect_pmd(pmd_t *pmdp, > goto next; > > page = device_private_entry_to_page(entry); > - mpfn = migrate_pfn(page_to_pfn(page))| > - MIGRATE_PFN_DEVICE | MIGRATE_PFN_MIGRATE; > + mpfn = migrate_pfn(page_to_pfn(page)) | > + MIGRATE_PFN_MIGRATE; > if (is_write_device_private_entry(entry)) > mpfn |= MIGRATE_PFN_WRITE; > } else { >
next prev parent reply other threads:[~2019-07-29 23:31 UTC|newest] Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-29 14:28 turn the hmm migrate_vma upside down Christoph Hellwig 2019-07-29 14:28 ` [PATCH 1/9] mm: turn " Christoph Hellwig 2019-07-29 23:12 ` Ralph Campbell 2019-07-29 23:12 ` Ralph Campbell 2019-07-29 23:43 ` Jerome Glisse 2019-07-31 1:46 ` Ralph Campbell 2019-07-31 1:46 ` Ralph Campbell 2019-08-01 7:42 ` Christoph Hellwig 2019-07-29 14:28 ` [PATCH 2/9] nouveau: reset dma_nr in nouveau_dmem_migrate_alloc_and_copy Christoph Hellwig 2019-07-29 23:18 ` Ralph Campbell 2019-07-29 23:18 ` Ralph Campbell 2019-07-29 14:28 ` [PATCH 3/9] nouveau: factor out device memory address calculation Christoph Hellwig 2019-07-29 14:28 ` Christoph Hellwig 2019-07-29 23:21 ` Ralph Campbell 2019-07-29 23:21 ` Ralph Campbell 2019-07-29 14:28 ` [PATCH 4/9] nouveau: factor out dmem fence completion Christoph Hellwig 2019-07-29 14:28 ` Christoph Hellwig 2019-07-29 23:23 ` Ralph Campbell 2019-07-29 23:23 ` Ralph Campbell 2019-07-29 14:28 ` [PATCH 5/9] nouveau: simplify nouveau_dmem_migrate_to_ram Christoph Hellwig 2019-07-29 14:28 ` Christoph Hellwig 2019-07-29 23:26 ` Ralph Campbell 2019-07-29 23:26 ` Ralph Campbell 2019-07-31 9:57 ` Bharata B Rao 2019-08-01 7:46 ` Christoph Hellwig 2019-08-01 7:46 ` Christoph Hellwig 2019-07-29 14:28 ` [PATCH 6/9] nouveau: simplify nouveau_dmem_migrate_vma Christoph Hellwig 2019-07-29 14:28 ` Christoph Hellwig 2019-07-29 23:27 ` Ralph Campbell 2019-07-29 23:27 ` Ralph Campbell 2019-07-29 14:28 ` [PATCH 7/9] mm: remove the unused MIGRATE_PFN_ERROR flag Christoph Hellwig 2019-07-29 14:28 ` Christoph Hellwig 2019-07-29 23:29 ` Ralph Campbell 2019-07-29 23:29 ` Ralph Campbell 2019-07-29 14:28 ` [PATCH 8/9] mm: remove the unused MIGRATE_PFN_DEVICE flag Christoph Hellwig 2019-07-29 14:28 ` Christoph Hellwig 2019-07-29 23:31 ` Ralph Campbell [this message] 2019-07-29 23:31 ` Ralph Campbell 2019-07-29 14:28 ` [PATCH 9/9] mm: remove the MIGRATE_PFN_WRITE flag Christoph Hellwig 2019-07-29 14:28 ` Christoph Hellwig 2019-07-29 23:30 ` Jerome Glisse 2019-07-30 5:46 ` Christoph Hellwig 2019-07-30 5:46 ` Christoph Hellwig 2019-07-30 15:51 ` Jerome Glisse 2019-07-29 23:42 ` Ralph Campbell 2019-07-29 23:42 ` Ralph Campbell 2019-07-29 23:46 ` Jerome Glisse 2019-07-30 12:32 ` turn the hmm migrate_vma upside down Jason Gunthorpe 2019-07-30 13:09 ` Christoph Hellwig
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ef44f3bf-0f99-c76b-bf4b-6770545b5e38@nvidia.com \ --to=rcampbell@nvidia.com \ --cc=akpm@linux-foundation.org \ --cc=bharata@linux.ibm.com \ --cc=bskeggs@redhat.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=hch@lst.de \ --cc=jgg@mellanox.com \ --cc=jglisse@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=nouveau@lists.freedesktop.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.