* [PATCH] spi: imx: Implement set_speed
@ 2021-02-25 20:51 Marek Vasut
2021-02-25 23:41 ` Bin Meng
0 siblings, 1 reply; 8+ messages in thread
From: Marek Vasut @ 2021-02-25 20:51 UTC (permalink / raw)
To: u-boot
The set_speed() callback should configure the bus speed, make it so.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Jagan Teki <jagan@amarulasolutions.com>
Cc: Stefano Babic <sbabic@denx.de>
---
drivers/spi/mxc_spi.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/spi/mxc_spi.c b/drivers/spi/mxc_spi.c
index bb68eb90e91..bce5356b294 100644
--- a/drivers/spi/mxc_spi.c
+++ b/drivers/spi/mxc_spi.c
@@ -662,7 +662,10 @@ static int mxc_spi_release_bus(struct udevice *dev)
static int mxc_spi_set_speed(struct udevice *bus, uint speed)
{
- /* Nothing to do */
+ struct mxc_spi_slave *mxcs = dev_get_platdata(bus);
+
+ mxcs->max_hz = speed;
+
return 0;
}
--
2.30.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH] spi: imx: Implement set_speed
2021-02-25 20:51 [PATCH] spi: imx: Implement set_speed Marek Vasut
@ 2021-02-25 23:41 ` Bin Meng
2021-02-26 0:14 ` Marek Vasut
0 siblings, 1 reply; 8+ messages in thread
From: Bin Meng @ 2021-02-25 23:41 UTC (permalink / raw)
To: u-boot
Hi Marek,
On Fri, Feb 26, 2021 at 4:52 AM Marek Vasut <marex@denx.de> wrote:
>
> The set_speed() callback should configure the bus speed, make it so.
>
This patch is not flagged as v3 since previously there were 2 versions
already on the ML. Did you mistakenly send this?
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Jagan Teki <jagan@amarulasolutions.com>
> Cc: Stefano Babic <sbabic@denx.de>
> ---
> drivers/spi/mxc_spi.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/spi/mxc_spi.c b/drivers/spi/mxc_spi.c
> index bb68eb90e91..bce5356b294 100644
> --- a/drivers/spi/mxc_spi.c
> +++ b/drivers/spi/mxc_spi.c
> @@ -662,7 +662,10 @@ static int mxc_spi_release_bus(struct udevice *dev)
>
> static int mxc_spi_set_speed(struct udevice *bus, uint speed)
> {
> - /* Nothing to do */
> + struct mxc_spi_slave *mxcs = dev_get_platdata(bus);
This patch is the same as the previous v1 patch here:
https://lists.denx.de/pipermail/u-boot/2021-February/439840.html
And you already sent a v2 that was reviewed.
https://lists.denx.de/pipermail/u-boot/2021-February/439863.html
> +
> + mxcs->max_hz = speed;
> +
> return 0;
> }
Regards,
Bin
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH] spi: imx: Implement set_speed
2021-02-25 23:41 ` Bin Meng
@ 2021-02-26 0:14 ` Marek Vasut
2021-02-26 1:28 ` Bin Meng
0 siblings, 1 reply; 8+ messages in thread
From: Marek Vasut @ 2021-02-26 0:14 UTC (permalink / raw)
To: u-boot
On 2/26/21 12:41 AM, Bin Meng wrote:
> Hi Marek,
Hello Bin,
> On Fri, Feb 26, 2021 at 4:52 AM Marek Vasut <marex@denx.de> wrote:
>>
>> The set_speed() callback should configure the bus speed, make it so.
>>
>
> This patch is not flagged as v3 since previously there were 2 versions
> already on the ML. Did you mistakenly send this?
No, I sent it yet again because I still do not see this patch upstream.
[...]
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] spi: imx: Implement set_speed
2021-02-26 0:14 ` Marek Vasut
@ 2021-02-26 1:28 ` Bin Meng
2021-02-26 1:54 ` Marek Vasut
0 siblings, 1 reply; 8+ messages in thread
From: Bin Meng @ 2021-02-26 1:28 UTC (permalink / raw)
To: u-boot
Hi Marek,
On Fri, Feb 26, 2021 at 8:14 AM Marek Vasut <marex@denx.de> wrote:
>
> On 2/26/21 12:41 AM, Bin Meng wrote:
> > Hi Marek,
>
> Hello Bin,
>
> > On Fri, Feb 26, 2021 at 4:52 AM Marek Vasut <marex@denx.de> wrote:
> >>
> >> The set_speed() callback should configure the bus speed, make it so.
> >>
> >
> > This patch is not flagged as v3 since previously there were 2 versions
> > already on the ML. Did you mistakenly send this?
>
> No, I sent it yet again because I still do not see this patch upstream.
>
Okay, but you ended up sending a wrong version :) Better to tag the
patch as [RESEND] to avoid misunderstanding.
> [...]
Regards,
Bin
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] spi: imx: Implement set_speed
2021-02-26 1:28 ` Bin Meng
@ 2021-02-26 1:54 ` Marek Vasut
0 siblings, 0 replies; 8+ messages in thread
From: Marek Vasut @ 2021-02-26 1:54 UTC (permalink / raw)
To: u-boot
On 2/26/21 2:28 AM, Bin Meng wrote:
> Hi Marek,
Hello Bin,
> On Fri, Feb 26, 2021 at 8:14 AM Marek Vasut <marex@denx.de> wrote:
>>
>> On 2/26/21 12:41 AM, Bin Meng wrote:
>>> Hi Marek,
>>
>> Hello Bin,
>>
>>> On Fri, Feb 26, 2021 at 4:52 AM Marek Vasut <marex@denx.de> wrote:
>>>>
>>>> The set_speed() callback should configure the bus speed, make it so.
>>>>
>>>
>>> This patch is not flagged as v3 since previously there were 2 versions
>>> already on the ML. Did you mistakenly send this?
>>
>> No, I sent it yet again because I still do not see this patch upstream.
>>
>
> Okay, but you ended up sending a wrong version :)
Okay :)
> Better to tag the
> patch as [RESEND] to avoid misunderstanding.
Thank you for your feedback.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] spi: imx: Implement set_speed
@ 2021-01-27 16:01 Marek Vasut
2021-02-02 3:10 ` Bin Meng
0 siblings, 1 reply; 8+ messages in thread
From: Marek Vasut @ 2021-01-27 16:01 UTC (permalink / raw)
To: u-boot
The set_speed() callback should configure the bus speed, make it so.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Jagan Teki <jagan@amarulasolutions.com>
Cc: Stefano Babic <sbabic@denx.de>
---
drivers/spi/mxc_spi.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/spi/mxc_spi.c b/drivers/spi/mxc_spi.c
index 553a0315df5..47100d89aef 100644
--- a/drivers/spi/mxc_spi.c
+++ b/drivers/spi/mxc_spi.c
@@ -661,7 +661,10 @@ static int mxc_spi_release_bus(struct udevice *dev)
static int mxc_spi_set_speed(struct udevice *bus, uint speed)
{
- /* Nothing to do */
+ struct mxc_spi_slave *mxcs = dev_get_platdata(bus);
+
+ mxcs->max_hz = speed;
+
return 0;
}
--
2.29.2
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH] spi: imx: Implement set_speed
2021-01-27 16:01 Marek Vasut
@ 2021-02-02 3:10 ` Bin Meng
2021-02-03 16:54 ` Marek Vasut
0 siblings, 1 reply; 8+ messages in thread
From: Bin Meng @ 2021-02-02 3:10 UTC (permalink / raw)
To: u-boot
On Thu, Jan 28, 2021 at 12:01 AM Marek Vasut <marex@denx.de> wrote:
>
> The set_speed() callback should configure the bus speed, make it so.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Jagan Teki <jagan@amarulasolutions.com>
> Cc: Stefano Babic <sbabic@denx.de>
> ---
> drivers/spi/mxc_spi.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/spi/mxc_spi.c b/drivers/spi/mxc_spi.c
> index 553a0315df5..47100d89aef 100644
> --- a/drivers/spi/mxc_spi.c
> +++ b/drivers/spi/mxc_spi.c
> @@ -661,7 +661,10 @@ static int mxc_spi_release_bus(struct udevice *dev)
>
> static int mxc_spi_set_speed(struct udevice *bus, uint speed)
> {
> - /* Nothing to do */
> + struct mxc_spi_slave *mxcs = dev_get_platdata(bus);
This is now renamed to dev_get_plat()
> +
> + mxcs->max_hz = speed;
> +
> return 0;
> }
>
Otherwise,
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH] spi: imx: Implement set_speed
2021-02-02 3:10 ` Bin Meng
@ 2021-02-03 16:54 ` Marek Vasut
0 siblings, 0 replies; 8+ messages in thread
From: Marek Vasut @ 2021-02-03 16:54 UTC (permalink / raw)
To: u-boot
On 2/2/21 4:10 AM, Bin Meng wrote:
> On Thu, Jan 28, 2021 at 12:01 AM Marek Vasut <marex@denx.de> wrote:
>>
>> The set_speed() callback should configure the bus speed, make it so.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Cc: Jagan Teki <jagan@amarulasolutions.com>
>> Cc: Stefano Babic <sbabic@denx.de>
>> ---
>> drivers/spi/mxc_spi.c | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/spi/mxc_spi.c b/drivers/spi/mxc_spi.c
>> index 553a0315df5..47100d89aef 100644
>> --- a/drivers/spi/mxc_spi.c
>> +++ b/drivers/spi/mxc_spi.c
>> @@ -661,7 +661,10 @@ static int mxc_spi_release_bus(struct udevice *dev)
>>
>> static int mxc_spi_set_speed(struct udevice *bus, uint speed)
>> {
>> - /* Nothing to do */
>> + struct mxc_spi_slave *mxcs = dev_get_platdata(bus);
>
> This is now renamed to dev_get_plat()
Fixed in V2, thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-02-26 1:54 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-25 20:51 [PATCH] spi: imx: Implement set_speed Marek Vasut
2021-02-25 23:41 ` Bin Meng
2021-02-26 0:14 ` Marek Vasut
2021-02-26 1:28 ` Bin Meng
2021-02-26 1:54 ` Marek Vasut
-- strict thread matches above, loose matches on Subject: below --
2021-01-27 16:01 Marek Vasut
2021-02-02 3:10 ` Bin Meng
2021-02-03 16:54 ` Marek Vasut
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.