From: Randy Dunlap <rdunlap@infradead.org>
To: Daniel Kiper <daniel.kiper@oracle.com>,
coreboot@coreboot.org, grub-devel@gnu.org,
linux-kernel@vger.kernel.org,
systemd-devel@lists.freedesktop.org,
trenchboot-devel@googlegroups.com, u-boot@lists.denx.de,
x86@kernel.org, xen-devel@lists.xenproject.org
Cc: alecb@umass.edu, alexander.burmashev@oracle.com,
allen.cryptic@gmail.com, andrew.cooper3@citrix.com,
ard.biesheuvel@linaro.org, btrotter@gmail.com,
dpsmith@apertussolutions.com, eric.devolder@oracle.com,
eric.snowberg@oracle.com, hpa@zytor.com, hun@n-dimensional.de,
javierm@redhat.com, joao.m.martins@oracle.com,
kanth.ghatraju@oracle.com, konrad.wilk@oracle.com,
krystian.hebel@3mdeb.com, leif@nuviainc.com,
lukasz.hawrylko@intel.com, luto@amacapital.net,
michal.zygowski@3mdeb.com, mjg59@google.com, mtottenh@akamai.com,
phcoder@gmail.com, piotr.krol@3mdeb.com, pjones@redhat.com,
pmenzel@molgen.mpg.de, roger.pau@citrix.com,
ross.philipson@oracle.com, tyhicks@linux.microsoft.com
Subject: Re: [SPECIFICATION RFC] The firmware and bootloader log specification
Date: Fri, 13 Nov 2020 19:14:44 -0800 [thread overview]
Message-ID: <ef83facc-b08d-a43d-aff1-e0492ab38064@infradead.org> (raw)
In-Reply-To: <20201113235242.k6fzlwmwm2xqhqsi@tomti.i.net-space.pl>
On 11/13/20 3:52 PM, Daniel Kiper wrote:
> Hey,
>
>
> Here is the description (pseudocode) of the structures which will be
> used to store the log data.
>
> Anyway, I am aware that this is not specification per se.
Yes, you have caveats here. I'm sure that you either already know
or would learn soon enough that struct struct bf_log has some
padding added to it (for alignment) unless it is packed.
Or you could rearrange the order of some of its fields
and save 8 bytes per struct on x86_64.
> struct bf_log
> {
> uint32_t version;
> char producer[64];
> uint64_t flags;
> uint64_t next_bf_log_addr;
> uint32_t next_msg_off;
> bf_log_msg msgs[];
> }
>
> struct bf_log_msg
> {
> uint32_t size;
> uint64_t ts_nsec;
> uint32_t level;
> uint32_t facility;
> uint32_t msg_off;
> char strings[];
> }
cheers.
--
~Randy
WARNING: multiple messages have this Message-ID (diff)
From: Randy Dunlap <rdunlap@infradead.org>
To: u-boot@lists.denx.de
Subject: [SPECIFICATION RFC] The firmware and bootloader log specification
Date: Fri, 13 Nov 2020 19:14:44 -0800 [thread overview]
Message-ID: <ef83facc-b08d-a43d-aff1-e0492ab38064@infradead.org> (raw)
In-Reply-To: <20201113235242.k6fzlwmwm2xqhqsi@tomti.i.net-space.pl>
On 11/13/20 3:52 PM, Daniel Kiper wrote:
> Hey,
>
>
> Here is the description (pseudocode) of the structures which will be
> used to store the log data.
>
> Anyway, I am aware that this is not specification per se.
Yes, you have caveats here. I'm sure that you either already know
or would learn soon enough that struct struct bf_log has some
padding added to it (for alignment) unless it is packed.
Or you could rearrange the order of some of its fields
and save 8 bytes per struct on x86_64.
> struct bf_log
> {
> uint32_t version;
> char producer[64];
> uint64_t flags;
> uint64_t next_bf_log_addr;
> uint32_t next_msg_off;
> bf_log_msg msgs[];
> }
>
> struct bf_log_msg
> {
> uint32_t size;
> uint64_t ts_nsec;
> uint32_t level;
> uint32_t facility;
> uint32_t msg_off;
> char strings[];
> }
cheers.
--
~Randy
next prev parent reply other threads:[~2020-11-14 3:16 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 23:52 [SPECIFICATION RFC] The firmware and bootloader log specification Daniel Kiper
2020-11-13 23:52 ` Daniel Kiper
2020-11-14 3:14 ` Randy Dunlap [this message]
2020-11-14 3:14 ` Randy Dunlap
2020-11-14 12:32 ` Nico Huber
2020-11-14 12:32 ` Nico Huber
2020-11-15 14:01 ` James Courtier-Dutton
2020-11-15 14:01 ` James Courtier-Dutton
2020-11-16 7:02 ` Antw: [EXT] [systemd-devel] " Ulrich Windl
2020-11-16 7:02 ` Ulrich Windl
2020-11-16 7:02 ` Ulrich Windl
2020-11-16 8:57 ` Rasmus Villemoes
2020-11-16 8:57 ` Rasmus Villemoes
2020-11-16 8:57 ` Rasmus Villemoes
2020-11-18 15:01 ` Heinrich Schuchardt
2020-11-18 15:01 ` Heinrich Schuchardt
2020-12-03 1:17 ` Julius Werner
2020-12-03 1:17 ` Julius Werner
2020-12-03 1:17 ` Julius Werner
2020-12-04 12:52 ` Wim Vervoorn
2020-12-04 12:52 ` Wim Vervoorn
2020-12-04 12:52 ` Wim Vervoorn
2020-12-04 13:23 ` Paul Menzel
2020-12-04 13:23 ` Paul Menzel
2020-12-07 21:50 ` Tom Rini
2020-12-07 21:50 ` Tom Rini
2020-12-09 5:41 ` Frank Rowand
2020-12-09 5:41 ` Frank Rowand
2020-12-03 16:31 ` Andy Shevchenko
2020-12-03 16:31 ` Andy Shevchenko
2020-12-03 16:31 ` Andy Shevchenko
2020-12-15 20:25 ` Simon Glass
2020-12-15 20:25 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef83facc-b08d-a43d-aff1-e0492ab38064@infradead.org \
--to=rdunlap@infradead.org \
--cc=alecb@umass.edu \
--cc=alexander.burmashev@oracle.com \
--cc=allen.cryptic@gmail.com \
--cc=andrew.cooper3@citrix.com \
--cc=ard.biesheuvel@linaro.org \
--cc=btrotter@gmail.com \
--cc=coreboot@coreboot.org \
--cc=daniel.kiper@oracle.com \
--cc=dpsmith@apertussolutions.com \
--cc=eric.devolder@oracle.com \
--cc=eric.snowberg@oracle.com \
--cc=grub-devel@gnu.org \
--cc=hpa@zytor.com \
--cc=hun@n-dimensional.de \
--cc=javierm@redhat.com \
--cc=joao.m.martins@oracle.com \
--cc=kanth.ghatraju@oracle.com \
--cc=konrad.wilk@oracle.com \
--cc=krystian.hebel@3mdeb.com \
--cc=leif@nuviainc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukasz.hawrylko@intel.com \
--cc=luto@amacapital.net \
--cc=michal.zygowski@3mdeb.com \
--cc=mjg59@google.com \
--cc=mtottenh@akamai.com \
--cc=phcoder@gmail.com \
--cc=piotr.krol@3mdeb.com \
--cc=pjones@redhat.com \
--cc=pmenzel@molgen.mpg.de \
--cc=roger.pau@citrix.com \
--cc=ross.philipson@oracle.com \
--cc=systemd-devel@lists.freedesktop.org \
--cc=trenchboot-devel@googlegroups.com \
--cc=tyhicks@linux.microsoft.com \
--cc=u-boot@lists.denx.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.