All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <marc.zyngier@arm.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: swarren@nvidia.com, johnstul@us.ibm.com,
	devicetree-discuss@lists.ozlabs.org, rob.herring@calxeda.com,
	Thomas Abraham <thomas.abraham@linaro.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: architected timers: allow dt based discovery using clocksource_of_init
Date: Mon, 21 Jan 2013 19:25:55 +0100	[thread overview]
Message-ID: <ef8b986a3b0a2c3fae230c8d7416d42d@localhost> (raw)
In-Reply-To: <50FD7904.1070201@wwwdotorg.org>

On Mon, 21 Jan 2013 10:21:08 -0700, Stephen Warren <swarren@wwwdotorg.org>
wrote:
> On 01/20/2013 06:22 PM, Thomas Abraham wrote:
>> Add an entry in __clksrc_of_table so that ARMv7 architected timer is
>> discoverable using call to clocksource_of_init.
> 
>> diff --git a/arch/arm/kernel/arch_timer.c
b/arch/arm/kernel/arch_timer.c
> 
>> +#ifdef CONFIG_CLKSRC_OF
>> +CLOCKSOURCE_OF_DECLARE(armv7_timer, "arm,armv7-timer",
>> arch_timer_of_register)
>> +#endif
> 
> I wonder if we shouldn't enhance include/linux/clocksource.h to define
> CLOCKSOURCE_OF_DECLARE even when !CONFIG_CLKSRC_OF; that way, drivers
> wouldn't need that ifdef.

Indeed. That would be a lot nicer.

        M.
-- 
Fast, cheap, reliable. Pick two.

WARNING: multiple messages have this Message-ID (diff)
From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: architected timers: allow dt based discovery using clocksource_of_init
Date: Mon, 21 Jan 2013 19:25:55 +0100	[thread overview]
Message-ID: <ef8b986a3b0a2c3fae230c8d7416d42d@localhost> (raw)
In-Reply-To: <50FD7904.1070201@wwwdotorg.org>

On Mon, 21 Jan 2013 10:21:08 -0700, Stephen Warren <swarren@wwwdotorg.org>
wrote:
> On 01/20/2013 06:22 PM, Thomas Abraham wrote:
>> Add an entry in __clksrc_of_table so that ARMv7 architected timer is
>> discoverable using call to clocksource_of_init.
> 
>> diff --git a/arch/arm/kernel/arch_timer.c
b/arch/arm/kernel/arch_timer.c
> 
>> +#ifdef CONFIG_CLKSRC_OF
>> +CLOCKSOURCE_OF_DECLARE(armv7_timer, "arm,armv7-timer",
>> arch_timer_of_register)
>> +#endif
> 
> I wonder if we shouldn't enhance include/linux/clocksource.h to define
> CLOCKSOURCE_OF_DECLARE even when !CONFIG_CLKSRC_OF; that way, drivers
> wouldn't need that ifdef.

Indeed. That would be a lot nicer.

        M.
-- 
Fast, cheap, reliable. Pick two.

  reply	other threads:[~2013-01-21 18:25 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-21  1:22 [PATCH] ARM: architected timers: allow dt based discovery using clocksource_of_init Thomas Abraham
2013-01-21  1:22 ` Thomas Abraham
2013-01-21 12:13 ` Mark Rutland
2013-01-21 12:13   ` Mark Rutland
     [not found]   ` <20130121121353.GH15707-NuALmloUBlrZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2013-01-21 18:19     ` Thomas Abraham
2013-01-21 18:19       ` Thomas Abraham
     [not found] ` <1358731326-2979-1-git-send-email-thomas.abraham-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-01-21 17:21   ` Stephen Warren
2013-01-21 17:21     ` Stephen Warren
2013-01-21 18:25     ` Marc Zyngier [this message]
2013-01-21 18:25       ` Marc Zyngier
     [not found]     ` <50FD7904.1070201-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-01-21 18:30       ` Thomas Abraham
2013-01-21 18:30         ` Thomas Abraham
2013-01-22 11:04         ` Mark Rutland
2013-01-22 11:04           ` Mark Rutland
2013-01-30 17:19           ` Mark Rutland
2013-01-30 17:19             ` Mark Rutland
2013-01-30 17:49             ` Stephen Warren
2013-01-30 17:49               ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ef8b986a3b0a2c3fae230c8d7416d42d@localhost \
    --to=marc.zyngier@arm.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=johnstul@us.ibm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=rob.herring@calxeda.com \
    --cc=swarren@nvidia.com \
    --cc=swarren@wwwdotorg.org \
    --cc=thomas.abraham@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.