All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Robin Gong <yibin.gong@nxp.com>,
	wim@linux-watchdog.org, shawnguo@kernel.org,
	s.hauer@pengutronix.de, festevam@gmail.com
Cc: linux-imx@nxp.com, kernel@pengutronix.de,
	linux-watchdog@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] watchdog: imx2_wdt: avoid to ping before resume back
Date: Fri, 14 May 2021 06:42:12 -0700	[thread overview]
Message-ID: <efc34ded-720d-ef57-8906-37e8ab36c3cf@roeck-us.net> (raw)
In-Reply-To: <1621012875-22667-1-git-send-email-yibin.gong@nxp.com>

On 5/14/21 10:21 AM, Robin Gong wrote:
> Since watchdog_ping_work is not freezable so that it maybe scheduled before
> imx2_wdt_resume where watchdog clock enabled, hence, kernel will hang in
> imx2_wdt_ping without clock, and then watchdog reset happen. Add clk_is_on
> to prevent the above case by ignoring ping until watchdog driver resume
> back indeed.
> 
> Signed-off-by: Robin Gong <yibin.gong@nxp.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   drivers/watchdog/imx2_wdt.c | 10 ++++++++++
>   1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/watchdog/imx2_wdt.c b/drivers/watchdog/imx2_wdt.c
> index b84f80f..cc86018 100644
> --- a/drivers/watchdog/imx2_wdt.c
> +++ b/drivers/watchdog/imx2_wdt.c
> @@ -65,6 +65,7 @@ struct imx2_wdt_device {
>   	struct regmap *regmap;
>   	struct watchdog_device wdog;
>   	bool ext_reset;
> +	bool clk_is_on;
>   };
>   
>   static bool nowayout = WATCHDOG_NOWAYOUT;
> @@ -160,6 +161,9 @@ static int imx2_wdt_ping(struct watchdog_device *wdog)
>   {
>   	struct imx2_wdt_device *wdev = watchdog_get_drvdata(wdog);
>   
> +	if (!wdev->clk_is_on)
> +		return 0;
> +
>   	regmap_write(wdev->regmap, IMX2_WDT_WSR, IMX2_WDT_SEQ1);
>   	regmap_write(wdev->regmap, IMX2_WDT_WSR, IMX2_WDT_SEQ2);
>   	return 0;
> @@ -301,6 +305,8 @@ static int __init imx2_wdt_probe(struct platform_device *pdev)
>   	if (ret)
>   		return ret;
>   
> +	wdev->clk_is_on = true;
> +
>   	regmap_read(wdev->regmap, IMX2_WDT_WRSR, &val);
>   	wdog->bootstatus = val & IMX2_WDT_WRSR_TOUT ? WDIOF_CARDRESET : 0;
>   
> @@ -361,6 +367,8 @@ static int __maybe_unused imx2_wdt_suspend(struct device *dev)
>   
>   	clk_disable_unprepare(wdev->clk);
>   
> +	wdev->clk_is_on = false;
> +
>   	return 0;
>   }
>   
> @@ -375,6 +383,8 @@ static int __maybe_unused imx2_wdt_resume(struct device *dev)
>   	if (ret)
>   		return ret;
>   
> +	wdev->clk_is_on = true;
> +
>   	if (watchdog_active(wdog) && !imx2_wdt_is_running(wdev)) {
>   		/*
>   		 * If the watchdog is still active and resumes
> 


WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Robin Gong <yibin.gong@nxp.com>,
	wim@linux-watchdog.org, shawnguo@kernel.org,
	s.hauer@pengutronix.de, festevam@gmail.com
Cc: linux-imx@nxp.com, kernel@pengutronix.de,
	linux-watchdog@vger.kernel.org,
	 linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] watchdog: imx2_wdt: avoid to ping before resume back
Date: Fri, 14 May 2021 06:42:12 -0700	[thread overview]
Message-ID: <efc34ded-720d-ef57-8906-37e8ab36c3cf@roeck-us.net> (raw)
In-Reply-To: <1621012875-22667-1-git-send-email-yibin.gong@nxp.com>

On 5/14/21 10:21 AM, Robin Gong wrote:
> Since watchdog_ping_work is not freezable so that it maybe scheduled before
> imx2_wdt_resume where watchdog clock enabled, hence, kernel will hang in
> imx2_wdt_ping without clock, and then watchdog reset happen. Add clk_is_on
> to prevent the above case by ignoring ping until watchdog driver resume
> back indeed.
> 
> Signed-off-by: Robin Gong <yibin.gong@nxp.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   drivers/watchdog/imx2_wdt.c | 10 ++++++++++
>   1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/watchdog/imx2_wdt.c b/drivers/watchdog/imx2_wdt.c
> index b84f80f..cc86018 100644
> --- a/drivers/watchdog/imx2_wdt.c
> +++ b/drivers/watchdog/imx2_wdt.c
> @@ -65,6 +65,7 @@ struct imx2_wdt_device {
>   	struct regmap *regmap;
>   	struct watchdog_device wdog;
>   	bool ext_reset;
> +	bool clk_is_on;
>   };
>   
>   static bool nowayout = WATCHDOG_NOWAYOUT;
> @@ -160,6 +161,9 @@ static int imx2_wdt_ping(struct watchdog_device *wdog)
>   {
>   	struct imx2_wdt_device *wdev = watchdog_get_drvdata(wdog);
>   
> +	if (!wdev->clk_is_on)
> +		return 0;
> +
>   	regmap_write(wdev->regmap, IMX2_WDT_WSR, IMX2_WDT_SEQ1);
>   	regmap_write(wdev->regmap, IMX2_WDT_WSR, IMX2_WDT_SEQ2);
>   	return 0;
> @@ -301,6 +305,8 @@ static int __init imx2_wdt_probe(struct platform_device *pdev)
>   	if (ret)
>   		return ret;
>   
> +	wdev->clk_is_on = true;
> +
>   	regmap_read(wdev->regmap, IMX2_WDT_WRSR, &val);
>   	wdog->bootstatus = val & IMX2_WDT_WRSR_TOUT ? WDIOF_CARDRESET : 0;
>   
> @@ -361,6 +367,8 @@ static int __maybe_unused imx2_wdt_suspend(struct device *dev)
>   
>   	clk_disable_unprepare(wdev->clk);
>   
> +	wdev->clk_is_on = false;
> +
>   	return 0;
>   }
>   
> @@ -375,6 +383,8 @@ static int __maybe_unused imx2_wdt_resume(struct device *dev)
>   	if (ret)
>   		return ret;
>   
> +	wdev->clk_is_on = true;
> +
>   	if (watchdog_active(wdog) && !imx2_wdt_is_running(wdev)) {
>   		/*
>   		 * If the watchdog is still active and resumes
> 


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-05-14 13:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-14 17:21 [PATCH v2] watchdog: imx2_wdt: avoid to ping before resume back Robin Gong
2021-05-14 17:21 ` Robin Gong
2021-05-14 13:42 ` Guenter Roeck [this message]
2021-05-14 13:42   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=efc34ded-720d-ef57-8906-37e8ab36c3cf@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=wim@linux-watchdog.org \
    --cc=yibin.gong@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.