* [PATCH 0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()
@ 2018-01-27 20:15 ` SF Markus Elfring
0 siblings, 0 replies; 20+ messages in thread
From: SF Markus Elfring @ 2018-01-27 20:15 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA, Devesh Sharma, Doug Ledford,
Jason Gunthorpe, Selvin Xavier, Somnath Kotur,
Sriharsha Basavapatna
Cc: LKML, kernel-janitors-u79uwXL29TY76Z2rM5mHXA, Himanshu Jha
From: Markus Elfring <elfring-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Date: Sat, 27 Jan 2018 21:10:12 +0100
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete two error messages for a failed memory allocation
Use common error handling code
drivers/infiniband/hw/bnxt_re/qplib_res.c | 18 +++++++-----------
1 file changed, 7 insertions(+), 11 deletions(-)
--
2.16.1
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH 0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()
@ 2018-01-27 20:15 ` SF Markus Elfring
0 siblings, 0 replies; 20+ messages in thread
From: SF Markus Elfring @ 2018-01-27 20:15 UTC (permalink / raw)
To: linux-rdma, Devesh Sharma, Doug Ledford, Jason Gunthorpe,
Selvin Xavier, Somnath Kotur, Sriharsha Basavapatna
Cc: LKML, kernel-janitors, Himanshu Jha
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 27 Jan 2018 21:10:12 +0100
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete two error messages for a failed memory allocation
Use common error handling code
drivers/infiniband/hw/bnxt_re/qplib_res.c | 18 +++++++-----------
1 file changed, 7 insertions(+), 11 deletions(-)
--
2.16.1
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH 0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()
@ 2018-01-27 20:15 ` SF Markus Elfring
0 siblings, 0 replies; 20+ messages in thread
From: SF Markus Elfring @ 2018-01-27 20:15 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA, Devesh Sharma, Doug Ledford,
Jason Gunthorpe, Selvin Xavier, Somnath Kotur,
Sriharsha Basavapatna
Cc: LKML, kernel-janitors-u79uwXL29TY76Z2rM5mHXA, Himanshu Jha
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 27 Jan 2018 21:10:12 +0100
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete two error messages for a failed memory allocation
Use common error handling code
drivers/infiniband/hw/bnxt_re/qplib_res.c | 18 +++++++-----------
1 file changed, 7 insertions(+), 11 deletions(-)
--
2.16.1
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH 1/2] RDMA/bnxt_re: Delete two error messages for a failed memory allocation in bnxt_qplib_alloc_dpi_tbl()
2018-01-27 20:15 ` SF Markus Elfring
(?)
@ 2018-01-27 20:16 ` SF Markus Elfring
-1 siblings, 0 replies; 20+ messages in thread
From: SF Markus Elfring @ 2018-01-27 20:16 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA, Devesh Sharma, Doug Ledford,
Jason Gunthorpe, Selvin Xavier, Somnath Kotur,
Sriharsha Basavapatna
Cc: LKML, kernel-janitors-u79uwXL29TY76Z2rM5mHXA, Himanshu Jha
From: Markus Elfring <elfring-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Date: Sat, 27 Jan 2018 20:40:11 +0100
Omit extra messages for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
---
drivers/infiniband/hw/bnxt_re/qplib_res.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/infiniband/hw/bnxt_re/qplib_res.c b/drivers/infiniband/hw/bnxt_re/qplib_res.c
index ad37d54affcc..9dacfd24869b 100644
--- a/drivers/infiniband/hw/bnxt_re/qplib_res.c
+++ b/drivers/infiniband/hw/bnxt_re/qplib_res.c
@@ -707,8 +707,6 @@ static int bnxt_qplib_alloc_dpi_tbl(struct bnxt_qplib_res *res,
dpit->app_tbl = kcalloc(dpit->max, sizeof(void *), GFP_KERNEL);
if (!dpit->app_tbl) {
pci_iounmap(res->pdev, dpit->dbr_bar_reg_iomem);
- dev_err(&res->pdev->dev,
- "QPLIB: DPI app tbl allocation failed");
return -ENOMEM;
}
@@ -721,9 +719,6 @@ static int bnxt_qplib_alloc_dpi_tbl(struct bnxt_qplib_res *res,
pci_iounmap(res->pdev, dpit->dbr_bar_reg_iomem);
kfree(dpit->app_tbl);
dpit->app_tbl = NULL;
- dev_err(&res->pdev->dev,
- "QPLIB: DPI tbl allocation failed for size = %d",
- bytes);
return -ENOMEM;
}
--
2.16.1
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 1/2] RDMA/bnxt_re: Delete two error messages for a failed memory allocation in bnxt_qplib_alloc_dpi_tbl()
@ 2018-01-27 20:16 ` SF Markus Elfring
0 siblings, 0 replies; 20+ messages in thread
From: SF Markus Elfring @ 2018-01-27 20:16 UTC (permalink / raw)
To: linux-rdma, Devesh Sharma, Doug Ledford, Jason Gunthorpe,
Selvin Xavier, Somnath Kotur, Sriharsha Basavapatna
Cc: LKML, kernel-janitors, Himanshu Jha
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 27 Jan 2018 20:40:11 +0100
Omit extra messages for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/infiniband/hw/bnxt_re/qplib_res.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/infiniband/hw/bnxt_re/qplib_res.c b/drivers/infiniband/hw/bnxt_re/qplib_res.c
index ad37d54affcc..9dacfd24869b 100644
--- a/drivers/infiniband/hw/bnxt_re/qplib_res.c
+++ b/drivers/infiniband/hw/bnxt_re/qplib_res.c
@@ -707,8 +707,6 @@ static int bnxt_qplib_alloc_dpi_tbl(struct bnxt_qplib_res *res,
dpit->app_tbl = kcalloc(dpit->max, sizeof(void *), GFP_KERNEL);
if (!dpit->app_tbl) {
pci_iounmap(res->pdev, dpit->dbr_bar_reg_iomem);
- dev_err(&res->pdev->dev,
- "QPLIB: DPI app tbl allocation failed");
return -ENOMEM;
}
@@ -721,9 +719,6 @@ static int bnxt_qplib_alloc_dpi_tbl(struct bnxt_qplib_res *res,
pci_iounmap(res->pdev, dpit->dbr_bar_reg_iomem);
kfree(dpit->app_tbl);
dpit->app_tbl = NULL;
- dev_err(&res->pdev->dev,
- "QPLIB: DPI tbl allocation failed for size = %d",
- bytes);
return -ENOMEM;
}
--
2.16.1
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 1/2] RDMA/bnxt_re: Delete two error messages for a failed memory allocation in bnxt_qplib_all
@ 2018-01-27 20:16 ` SF Markus Elfring
0 siblings, 0 replies; 20+ messages in thread
From: SF Markus Elfring @ 2018-01-27 20:16 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA, Devesh Sharma, Doug Ledford,
Jason Gunthorpe, Selvin Xavier, Somnath Kotur,
Sriharsha Basavapatna
Cc: LKML, kernel-janitors-u79uwXL29TY76Z2rM5mHXA, Himanshu Jha
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 27 Jan 2018 20:40:11 +0100
Omit extra messages for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/infiniband/hw/bnxt_re/qplib_res.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/infiniband/hw/bnxt_re/qplib_res.c b/drivers/infiniband/hw/bnxt_re/qplib_res.c
index ad37d54affcc..9dacfd24869b 100644
--- a/drivers/infiniband/hw/bnxt_re/qplib_res.c
+++ b/drivers/infiniband/hw/bnxt_re/qplib_res.c
@@ -707,8 +707,6 @@ static int bnxt_qplib_alloc_dpi_tbl(struct bnxt_qplib_res *res,
dpit->app_tbl = kcalloc(dpit->max, sizeof(void *), GFP_KERNEL);
if (!dpit->app_tbl) {
pci_iounmap(res->pdev, dpit->dbr_bar_reg_iomem);
- dev_err(&res->pdev->dev,
- "QPLIB: DPI app tbl allocation failed");
return -ENOMEM;
}
@@ -721,9 +719,6 @@ static int bnxt_qplib_alloc_dpi_tbl(struct bnxt_qplib_res *res,
pci_iounmap(res->pdev, dpit->dbr_bar_reg_iomem);
kfree(dpit->app_tbl);
dpit->app_tbl = NULL;
- dev_err(&res->pdev->dev,
- "QPLIB: DPI tbl allocation failed for size = %d",
- bytes);
return -ENOMEM;
}
--
2.16.1
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 2/2] RDMA/bnxt_re: Use common error handling code in bnxt_qplib_alloc_dpi_tbl()
2018-01-27 20:15 ` SF Markus Elfring
(?)
@ 2018-01-27 20:17 ` SF Markus Elfring
-1 siblings, 0 replies; 20+ messages in thread
From: SF Markus Elfring @ 2018-01-27 20:17 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA, Devesh Sharma, Doug Ledford,
Jason Gunthorpe, Selvin Xavier, Somnath Kotur,
Sriharsha Basavapatna
Cc: LKML, kernel-janitors-u79uwXL29TY76Z2rM5mHXA, Himanshu Jha
From: Markus Elfring <elfring-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Date: Sat, 27 Jan 2018 20:56:56 +0100
Add a jump target so that a bit of exception handling can be better reused
at the end of this function.
Signed-off-by: Markus Elfring <elfring-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
---
drivers/infiniband/hw/bnxt_re/qplib_res.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/infiniband/hw/bnxt_re/qplib_res.c b/drivers/infiniband/hw/bnxt_re/qplib_res.c
index 9dacfd24869b..539a5d44e6db 100644
--- a/drivers/infiniband/hw/bnxt_re/qplib_res.c
+++ b/drivers/infiniband/hw/bnxt_re/qplib_res.c
@@ -705,10 +705,8 @@ static int bnxt_qplib_alloc_dpi_tbl(struct bnxt_qplib_res *res,
dpit->max = dbr_len / PAGE_SIZE;
dpit->app_tbl = kcalloc(dpit->max, sizeof(void *), GFP_KERNEL);
- if (!dpit->app_tbl) {
- pci_iounmap(res->pdev, dpit->dbr_bar_reg_iomem);
- return -ENOMEM;
- }
+ if (!dpit->app_tbl)
+ goto unmap_io;
bytes = dpit->max >> 3;
if (!bytes)
@@ -716,15 +714,18 @@ static int bnxt_qplib_alloc_dpi_tbl(struct bnxt_qplib_res *res,
dpit->tbl = kmalloc(bytes, GFP_KERNEL);
if (!dpit->tbl) {
- pci_iounmap(res->pdev, dpit->dbr_bar_reg_iomem);
kfree(dpit->app_tbl);
dpit->app_tbl = NULL;
- return -ENOMEM;
+ goto unmap_io;
}
memset((u8 *)dpit->tbl, 0xFF, bytes);
return 0;
+
+unmap_io:
+ pci_iounmap(res->pdev, dpit->dbr_bar_reg_iomem);
+ return -ENOMEM;
}
/* PKEYs */
--
2.16.1
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 2/2] RDMA/bnxt_re: Use common error handling code in bnxt_qplib_alloc_dpi_tbl()
@ 2018-01-27 20:17 ` SF Markus Elfring
0 siblings, 0 replies; 20+ messages in thread
From: SF Markus Elfring @ 2018-01-27 20:17 UTC (permalink / raw)
To: linux-rdma, Devesh Sharma, Doug Ledford, Jason Gunthorpe,
Selvin Xavier, Somnath Kotur, Sriharsha Basavapatna
Cc: LKML, kernel-janitors, Himanshu Jha
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 27 Jan 2018 20:56:56 +0100
Add a jump target so that a bit of exception handling can be better reused
at the end of this function.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/infiniband/hw/bnxt_re/qplib_res.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/infiniband/hw/bnxt_re/qplib_res.c b/drivers/infiniband/hw/bnxt_re/qplib_res.c
index 9dacfd24869b..539a5d44e6db 100644
--- a/drivers/infiniband/hw/bnxt_re/qplib_res.c
+++ b/drivers/infiniband/hw/bnxt_re/qplib_res.c
@@ -705,10 +705,8 @@ static int bnxt_qplib_alloc_dpi_tbl(struct bnxt_qplib_res *res,
dpit->max = dbr_len / PAGE_SIZE;
dpit->app_tbl = kcalloc(dpit->max, sizeof(void *), GFP_KERNEL);
- if (!dpit->app_tbl) {
- pci_iounmap(res->pdev, dpit->dbr_bar_reg_iomem);
- return -ENOMEM;
- }
+ if (!dpit->app_tbl)
+ goto unmap_io;
bytes = dpit->max >> 3;
if (!bytes)
@@ -716,15 +714,18 @@ static int bnxt_qplib_alloc_dpi_tbl(struct bnxt_qplib_res *res,
dpit->tbl = kmalloc(bytes, GFP_KERNEL);
if (!dpit->tbl) {
- pci_iounmap(res->pdev, dpit->dbr_bar_reg_iomem);
kfree(dpit->app_tbl);
dpit->app_tbl = NULL;
- return -ENOMEM;
+ goto unmap_io;
}
memset((u8 *)dpit->tbl, 0xFF, bytes);
return 0;
+
+unmap_io:
+ pci_iounmap(res->pdev, dpit->dbr_bar_reg_iomem);
+ return -ENOMEM;
}
/* PKEYs */
--
2.16.1
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 2/2] RDMA/bnxt_re: Use common error handling code in bnxt_qplib_alloc_dpi_tbl()
@ 2018-01-27 20:17 ` SF Markus Elfring
0 siblings, 0 replies; 20+ messages in thread
From: SF Markus Elfring @ 2018-01-27 20:17 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA, Devesh Sharma, Doug Ledford,
Jason Gunthorpe, Selvin Xavier, Somnath Kotur,
Sriharsha Basavapatna
Cc: LKML, kernel-janitors-u79uwXL29TY76Z2rM5mHXA, Himanshu Jha
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 27 Jan 2018 20:56:56 +0100
Add a jump target so that a bit of exception handling can be better reused
at the end of this function.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/infiniband/hw/bnxt_re/qplib_res.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/infiniband/hw/bnxt_re/qplib_res.c b/drivers/infiniband/hw/bnxt_re/qplib_res.c
index 9dacfd24869b..539a5d44e6db 100644
--- a/drivers/infiniband/hw/bnxt_re/qplib_res.c
+++ b/drivers/infiniband/hw/bnxt_re/qplib_res.c
@@ -705,10 +705,8 @@ static int bnxt_qplib_alloc_dpi_tbl(struct bnxt_qplib_res *res,
dpit->max = dbr_len / PAGE_SIZE;
dpit->app_tbl = kcalloc(dpit->max, sizeof(void *), GFP_KERNEL);
- if (!dpit->app_tbl) {
- pci_iounmap(res->pdev, dpit->dbr_bar_reg_iomem);
- return -ENOMEM;
- }
+ if (!dpit->app_tbl)
+ goto unmap_io;
bytes = dpit->max >> 3;
if (!bytes)
@@ -716,15 +714,18 @@ static int bnxt_qplib_alloc_dpi_tbl(struct bnxt_qplib_res *res,
dpit->tbl = kmalloc(bytes, GFP_KERNEL);
if (!dpit->tbl) {
- pci_iounmap(res->pdev, dpit->dbr_bar_reg_iomem);
kfree(dpit->app_tbl);
dpit->app_tbl = NULL;
- return -ENOMEM;
+ goto unmap_io;
}
memset((u8 *)dpit->tbl, 0xFF, bytes);
return 0;
+
+unmap_io:
+ pci_iounmap(res->pdev, dpit->dbr_bar_reg_iomem);
+ return -ENOMEM;
}
/* PKEYs */
--
2.16.1
^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCH 0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()
2018-01-27 20:15 ` SF Markus Elfring
(?)
@ 2018-01-29 3:44 ` Devesh Sharma
-1 siblings, 0 replies; 20+ messages in thread
From: Devesh Sharma @ 2018-01-29 3:44 UTC (permalink / raw)
To: SF Markus Elfring
Cc: linux-rdma, Doug Ledford, Jason Gunthorpe, Selvin Xavier,
Somnath Kotur, Sriharsha Basavapatna, LKML,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA, Himanshu Jha
On Sun, Jan 28, 2018 at 1:45 AM, SF Markus Elfring
<elfring-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org> wrote:
> From: Markus Elfring <elfring-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
> Date: Sat, 27 Jan 2018 21:10:12 +0100
>
> Two update suggestions were taken into account
> from static source code analysis.
You don't need 2 patches when changing same lines of code. Could
you squash both and send your changes in a single patch.
The patches look good to me otherwise.
-Thanks
Reviewed-By: Devesh Sharma <devesh.sharma-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
>
> Markus Elfring (2):
> Delete two error messages for a failed memory allocation
> Use common error handling code
>
> drivers/infiniband/hw/bnxt_re/qplib_res.c | 18 +++++++-----------
> 1 file changed, 7 insertions(+), 11 deletions(-)
>
> --
> 2.16.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()
@ 2018-01-29 3:44 ` Devesh Sharma
0 siblings, 0 replies; 20+ messages in thread
From: Devesh Sharma @ 2018-01-29 3:44 UTC (permalink / raw)
To: SF Markus Elfring
Cc: linux-rdma, Doug Ledford, Jason Gunthorpe, Selvin Xavier,
Somnath Kotur, Sriharsha Basavapatna, LKML, kernel-janitors,
Himanshu Jha
On Sun, Jan 28, 2018 at 1:45 AM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 27 Jan 2018 21:10:12 +0100
>
> Two update suggestions were taken into account
> from static source code analysis.
You don't need 2 patches when changing same lines of code. Could
you squash both and send your changes in a single patch.
The patches look good to me otherwise.
-Thanks
Reviewed-By: Devesh Sharma <devesh.sharma@broadcom.com>
>
> Markus Elfring (2):
> Delete two error messages for a failed memory allocation
> Use common error handling code
>
> drivers/infiniband/hw/bnxt_re/qplib_res.c | 18 +++++++-----------
> 1 file changed, 7 insertions(+), 11 deletions(-)
>
> --
> 2.16.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()
@ 2018-01-29 3:44 ` Devesh Sharma
0 siblings, 0 replies; 20+ messages in thread
From: Devesh Sharma @ 2018-01-29 3:56 UTC (permalink / raw)
To: SF Markus Elfring
Cc: linux-rdma, Doug Ledford, Jason Gunthorpe, Selvin Xavier,
Somnath Kotur, Sriharsha Basavapatna, LKML,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA, Himanshu Jha
On Sun, Jan 28, 2018 at 1:45 AM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 27 Jan 2018 21:10:12 +0100
>
> Two update suggestions were taken into account
> from static source code analysis.
You don't need 2 patches when changing same lines of code. Could
you squash both and send your changes in a single patch.
The patches look good to me otherwise.
-Thanks
Reviewed-By: Devesh Sharma <devesh.sharma@broadcom.com>
>
> Markus Elfring (2):
> Delete two error messages for a failed memory allocation
> Use common error handling code
>
> drivers/infiniband/hw/bnxt_re/qplib_res.c | 18 +++++++-----------
> 1 file changed, 7 insertions(+), 11 deletions(-)
>
> --
> 2.16.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()
2018-01-29 3:44 ` Devesh Sharma
(?)
(?)
@ 2018-01-29 9:31 ` SF Markus Elfring
[not found] ` <fe3d92c5-8e51-ea72-7637-6545c1654dd3-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
-1 siblings, 1 reply; 20+ messages in thread
From: SF Markus Elfring @ 2018-01-29 9:31 UTC (permalink / raw)
To: Devesh Sharma, linux-rdma
Cc: Doug Ledford, Jason Gunthorpe, Selvin Xavier, Somnath Kotur,
Sriharsha Basavapatna, LKML, kernel-janitors, Himanshu Jha
> You don't need 2 patches when changing same lines of code.
Are these really the same?
> Could you squash both and send your changes in a single patch.
I prefer to keep the deletion of questionable error messages separate
from the refactoring for a bit of exception handling.
> The patches look good to me otherwise.
Thanks for your constructive feedback.
Regards,
Markus
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()
2018-01-29 9:31 ` [0/2] " SF Markus Elfring
@ 2018-01-29 12:08 ` Devesh Sharma
0 siblings, 0 replies; 20+ messages in thread
From: Devesh Sharma @ 2018-01-29 12:08 UTC (permalink / raw)
To: SF Markus Elfring
Cc: linux-rdma, Doug Ledford, Jason Gunthorpe, Selvin Xavier,
Somnath Kotur, Sriharsha Basavapatna, LKML,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA, Himanshu Jha
On Mon, Jan 29, 2018 at 3:01 PM, SF Markus Elfring
<elfring-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org> wrote:
>> You don't need 2 patches when changing same lines of code.
>
> Are these really the same?
>
>
>> Could you squash both and send your changes in a single patch.
>
> I prefer to keep the deletion of questionable error messages separate
> from the refactoring for a bit of exception handling.
>
Okay fair enough
Series Acked-By: Devesh Sharma <devesh.sharma-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
>
>> The patches look good to me otherwise.
>
> Thanks for your constructive feedback.
>
> Regards,
> Markus
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()
@ 2018-01-29 12:08 ` Devesh Sharma
0 siblings, 0 replies; 20+ messages in thread
From: Devesh Sharma @ 2018-01-29 12:08 UTC (permalink / raw)
To: SF Markus Elfring
Cc: linux-rdma, Doug Ledford, Jason Gunthorpe, Selvin Xavier,
Somnath Kotur, Sriharsha Basavapatna, LKML, kernel-janitors,
Himanshu Jha
On Mon, Jan 29, 2018 at 3:01 PM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
>> You don't need 2 patches when changing same lines of code.
>
> Are these really the same?
>
>
>> Could you squash both and send your changes in a single patch.
>
> I prefer to keep the deletion of questionable error messages separate
> from the refactoring for a bit of exception handling.
>
Okay fair enough
Series Acked-By: Devesh Sharma <devesh.sharma@broadcom.com>
>
>> The patches look good to me otherwise.
>
> Thanks for your constructive feedback.
>
> Regards,
> Markus
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()
2018-01-27 20:15 ` SF Markus Elfring
(?)
@ 2018-01-29 14:19 ` Jonathan Toppins
-1 siblings, 0 replies; 20+ messages in thread
From: Jonathan Toppins @ 2018-01-29 14:19 UTC (permalink / raw)
To: SF Markus Elfring, linux-rdma-u79uwXL29TY76Z2rM5mHXA,
Devesh Sharma, Doug Ledford, Jason Gunthorpe, Selvin Xavier,
Somnath Kotur, Sriharsha Basavapatna
Cc: LKML, kernel-janitors-u79uwXL29TY76Z2rM5mHXA, Himanshu Jha
On 01/27/2018 03:15 PM, SF Markus Elfring wrote:
> From: Markus Elfring <elfring-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
> Date: Sat, 27 Jan 2018 21:10:12 +0100
>
> Two update suggestions were taken into account
> from static source code analysis.
>
> Markus Elfring (2):
> Delete two error messages for a failed memory allocation
> Use common error handling code
>
> drivers/infiniband/hw/bnxt_re/qplib_res.c | 18 +++++++-----------
> 1 file changed, 7 insertions(+), 11 deletions(-)
>
I like it.
Acked-by: Jonathan Toppins <jtoppins-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()
@ 2018-01-29 14:19 ` Jonathan Toppins
0 siblings, 0 replies; 20+ messages in thread
From: Jonathan Toppins @ 2018-01-29 14:19 UTC (permalink / raw)
To: SF Markus Elfring, linux-rdma, Devesh Sharma, Doug Ledford,
Jason Gunthorpe, Selvin Xavier, Somnath Kotur,
Sriharsha Basavapatna
Cc: LKML, kernel-janitors, Himanshu Jha
On 01/27/2018 03:15 PM, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 27 Jan 2018 21:10:12 +0100
>
> Two update suggestions were taken into account
> from static source code analysis.
>
> Markus Elfring (2):
> Delete two error messages for a failed memory allocation
> Use common error handling code
>
> drivers/infiniband/hw/bnxt_re/qplib_res.c | 18 +++++++-----------
> 1 file changed, 7 insertions(+), 11 deletions(-)
>
I like it.
Acked-by: Jonathan Toppins <jtoppins@redhat.com>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()
@ 2018-01-29 14:19 ` Jonathan Toppins
0 siblings, 0 replies; 20+ messages in thread
From: Jonathan Toppins @ 2018-01-29 14:19 UTC (permalink / raw)
To: SF Markus Elfring, linux-rdma-u79uwXL29TY76Z2rM5mHXA,
Devesh Sharma, Doug Ledford, Jason Gunthorpe, Selvin Xavier,
Somnath Kotur, Sriharsha Basavapatna
Cc: LKML, kernel-janitors-u79uwXL29TY76Z2rM5mHXA, Himanshu Jha
On 01/27/2018 03:15 PM, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 27 Jan 2018 21:10:12 +0100
>
> Two update suggestions were taken into account
> from static source code analysis.
>
> Markus Elfring (2):
> Delete two error messages for a failed memory allocation
> Use common error handling code
>
> drivers/infiniband/hw/bnxt_re/qplib_res.c | 18 +++++++-----------
> 1 file changed, 7 insertions(+), 11 deletions(-)
>
I like it.
Acked-by: Jonathan Toppins <jtoppins@redhat.com>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()
2018-01-27 20:15 ` SF Markus Elfring
@ 2018-02-01 22:49 ` Jason Gunthorpe
-1 siblings, 0 replies; 20+ messages in thread
From: Jason Gunthorpe @ 2018-02-01 22:49 UTC (permalink / raw)
To: SF Markus Elfring
Cc: linux-rdma, Devesh Sharma, Doug Ledford, Selvin Xavier,
Somnath Kotur, Sriharsha Basavapatna, LKML, kernel-janitors,
Himanshu Jha, Jonathan Toppins
On Sat, Jan 27, 2018 at 09:15:09PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 27 Jan 2018 21:10:12 +0100
>
> Two update suggestions were taken into account
> from static source code analysis.
>
> Markus Elfring (2):
> Delete two error messages for a failed memory allocation
> Use common error handling code
Applied to for-next with Jonathan and Devesh's ack, thanks all
Jason
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()
@ 2018-02-01 22:49 ` Jason Gunthorpe
0 siblings, 0 replies; 20+ messages in thread
From: Jason Gunthorpe @ 2018-02-01 22:49 UTC (permalink / raw)
To: SF Markus Elfring
Cc: linux-rdma, Devesh Sharma, Doug Ledford, Selvin Xavier,
Somnath Kotur, Sriharsha Basavapatna, LKML, kernel-janitors,
Himanshu Jha, Jonathan Toppins
On Sat, Jan 27, 2018 at 09:15:09PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 27 Jan 2018 21:10:12 +0100
>
> Two update suggestions were taken into account
> from static source code analysis.
>
> Markus Elfring (2):
> Delete two error messages for a failed memory allocation
> Use common error handling code
Applied to for-next with Jonathan and Devesh's ack, thanks all
Jason
^ permalink raw reply [flat|nested] 20+ messages in thread
end of thread, other threads:[~2018-02-01 22:49 UTC | newest]
Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-27 20:15 [PATCH 0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl() SF Markus Elfring
2018-01-27 20:15 ` SF Markus Elfring
2018-01-27 20:15 ` SF Markus Elfring
[not found] ` <19c755a6-8c52-bbd5-a425-48fc08cecd4f-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
2018-01-27 20:16 ` [PATCH 1/2] RDMA/bnxt_re: Delete two error messages for a failed memory allocation in bnxt_qplib_alloc_dpi_tbl() SF Markus Elfring
2018-01-27 20:16 ` [PATCH 1/2] RDMA/bnxt_re: Delete two error messages for a failed memory allocation in bnxt_qplib_all SF Markus Elfring
2018-01-27 20:16 ` [PATCH 1/2] RDMA/bnxt_re: Delete two error messages for a failed memory allocation in bnxt_qplib_alloc_dpi_tbl() SF Markus Elfring
2018-01-27 20:17 ` [PATCH 2/2] RDMA/bnxt_re: Use common error handling code " SF Markus Elfring
2018-01-27 20:17 ` SF Markus Elfring
2018-01-27 20:17 ` SF Markus Elfring
2018-01-29 3:44 ` [PATCH 0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl() Devesh Sharma
2018-01-29 3:56 ` Devesh Sharma
2018-01-29 3:44 ` Devesh Sharma
2018-01-29 9:31 ` [0/2] " SF Markus Elfring
[not found] ` <fe3d92c5-8e51-ea72-7637-6545c1654dd3-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
2018-01-29 12:08 ` Devesh Sharma
2018-01-29 12:08 ` Devesh Sharma
2018-01-29 14:19 ` [PATCH 0/2] " Jonathan Toppins
2018-01-29 14:19 ` Jonathan Toppins
2018-01-29 14:19 ` Jonathan Toppins
2018-02-01 22:49 ` Jason Gunthorpe
2018-02-01 22:49 ` Jason Gunthorpe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.