From: akolli@codeaurora.org
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Jouni Malinen <jouni@codeaurora.org>,
ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/3] ath11k: add htt cmd to enable full monitor mode
Date: Mon, 27 Sep 2021 09:49:45 +0530 [thread overview]
Message-ID: <f01c7797e7072687ab6014ccba431eb9@codeaurora.org> (raw)
In-Reply-To: <87tuiaryhk.fsf@codeaurora.org>
On 2021-09-24 17:12, Kalle Valo wrote:
> Jouni Malinen <jouni@codeaurora.org> writes:
>
>> From: Anilkumar Kolli <akolli@codeaurora.org>
>>
>> Add a new hw_param full_monitor_mode to enable full monitor support
>> for
>> QCN9074. HTT_H2T_MSG_TYPE_RX_FULL_MONITOR_MODE cmd is sent to the
>> firmware to enable the full monitor mode.
>
> Nowhere it's explained what "full monitor mode" means from an user's
> point of view. Can someone give a high level summary what advantages
> this feature has? For example, more frames delivered to user space or
> what?
Yes, more frames delivered with full monitor mode. The advantage with
full
monitor mode is, hardware has status buffers available for all the MPDUs
in
mon_dst_ring. Both status buffer and MPDUs from mon_dst_ring is used to
build
the frame.
Patch "ath11k: Process full monitor mode rx support" has the commit
message.
In full monitor mode, monitor destination ring is read before monitor
status ring. mon_dst_ring has ppdu id, reap till the end of PPDU. Add
all the MPDUs to list. Start processing the status ring, if PPDU id in
status ring is lagging behind, reap the status ring, once the PPDU ID
matches, deliver the MSDU to upper layer. If status PPDU id leading,
reap the mon_dst_ring. The advantage with full monitor mode is hardware
has status buffers available for all the MPDUs in mon_dst_ring.
- Anil.
WARNING: multiple messages have this Message-ID (diff)
From: akolli@codeaurora.org
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Jouni Malinen <jouni@codeaurora.org>,
ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/3] ath11k: add htt cmd to enable full monitor mode
Date: Mon, 27 Sep 2021 09:49:45 +0530 [thread overview]
Message-ID: <f01c7797e7072687ab6014ccba431eb9@codeaurora.org> (raw)
In-Reply-To: <87tuiaryhk.fsf@codeaurora.org>
On 2021-09-24 17:12, Kalle Valo wrote:
> Jouni Malinen <jouni@codeaurora.org> writes:
>
>> From: Anilkumar Kolli <akolli@codeaurora.org>
>>
>> Add a new hw_param full_monitor_mode to enable full monitor support
>> for
>> QCN9074. HTT_H2T_MSG_TYPE_RX_FULL_MONITOR_MODE cmd is sent to the
>> firmware to enable the full monitor mode.
>
> Nowhere it's explained what "full monitor mode" means from an user's
> point of view. Can someone give a high level summary what advantages
> this feature has? For example, more frames delivered to user space or
> what?
Yes, more frames delivered with full monitor mode. The advantage with
full
monitor mode is, hardware has status buffers available for all the MPDUs
in
mon_dst_ring. Both status buffer and MPDUs from mon_dst_ring is used to
build
the frame.
Patch "ath11k: Process full monitor mode rx support" has the commit
message.
In full monitor mode, monitor destination ring is read before monitor
status ring. mon_dst_ring has ppdu id, reap till the end of PPDU. Add
all the MPDUs to list. Start processing the status ring, if PPDU id in
status ring is lagging behind, reap the status ring, once the PPDU ID
matches, deliver the MSDU to upper layer. If status PPDU id leading,
reap the mon_dst_ring. The advantage with full monitor mode is hardware
has status buffers available for all the MPDUs in mon_dst_ring.
- Anil.
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
next prev parent reply other threads:[~2021-09-27 4:20 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 17:19 [PATCH 0/3] ath11k: add full monitor mode support for QCN9074 Jouni Malinen
2021-07-21 17:19 ` Jouni Malinen
2021-07-21 17:19 ` [PATCH 1/3] ath11k: add htt cmd to enable full monitor mode Jouni Malinen
2021-07-21 17:19 ` Jouni Malinen
2021-09-24 11:42 ` Kalle Valo
2021-09-24 11:42 ` Kalle Valo
2021-09-27 4:19 ` akolli [this message]
2021-09-27 4:19 ` akolli
2021-09-28 6:56 ` Kalle Valo
2021-09-28 6:56 ` Kalle Valo
2021-09-30 6:47 ` Anilkumar Kolli
2021-09-30 6:47 ` Anilkumar Kolli
2021-10-04 4:23 ` Anilkumar Kolli
2021-10-04 4:23 ` Anilkumar Kolli
2021-09-24 13:52 ` Kalle Valo
2021-09-24 13:52 ` Kalle Valo
2021-09-27 4:31 ` Anilkumar Kolli
2021-09-27 4:31 ` Anilkumar Kolli
2021-07-21 17:19 ` [PATCH 2/3] ath11k: add software monitor ring descriptor for full monitor Jouni Malinen
2021-07-21 17:19 ` Jouni Malinen
2021-07-21 17:19 ` [PATCH 3/3] ath11k: process full monitor mode rx support Jouni Malinen
2021-07-21 17:19 ` Jouni Malinen
2021-11-12 7:52 ` Kalle Valo
2021-11-12 7:52 ` Kalle Valo
2021-12-08 13:13 ` Anilkumar Kolli
2021-12-08 13:13 ` Anilkumar Kolli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f01c7797e7072687ab6014ccba431eb9@codeaurora.org \
--to=akolli@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=jouni@codeaurora.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.