* [U-Boot] [PATCH 1/1] dwc3-generic: Don't fail probe if clk/reset entries are absent
@ 2019-10-25 8:18 Vignesh Raghavendra
2019-10-25 8:20 ` Tero Kristo
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Vignesh Raghavendra @ 2019-10-25 8:18 UTC (permalink / raw)
To: u-boot
Some boards don't populate clk/reset entries as these are are optional
as per binding documentation. Therefore, don't fail driver probe if
clk/reset entries are absent in DT.
This fixes fastboot failures seen due to enabling of CONFIG_CLK on AM57xx
Fixes: e8e683d33b0c ("board: ti: am57xx-idk: Configure the CDCE913 clock synthesizer")
Reported-by: Sam Protsenko <semen.protsenko@linaro.org>
Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
---
drivers/usb/dwc3/dwc3-generic.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/dwc3/dwc3-generic.c b/drivers/usb/dwc3/dwc3-generic.c
index 406bf0b3628b..d76cd7a4c5ca 100644
--- a/drivers/usb/dwc3/dwc3-generic.c
+++ b/drivers/usb/dwc3/dwc3-generic.c
@@ -258,7 +258,7 @@ static int dwc3_glue_reset_init(struct udevice *dev,
int ret;
ret = reset_get_bulk(dev, &glue->resets);
- if (ret == -ENOTSUPP)
+ if (ret == -ENOTSUPP || ret == -ENOENT)
return 0;
else if (ret)
return ret;
@@ -278,7 +278,7 @@ static int dwc3_glue_clk_init(struct udevice *dev,
int ret;
ret = clk_get_bulk(dev, &glue->clks);
- if (ret == -ENOSYS)
+ if (ret == -ENOSYS || ret == -ENOENT)
return 0;
if (ret)
return ret;
--
2.23.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH 1/1] dwc3-generic: Don't fail probe if clk/reset entries are absent
2019-10-25 8:18 [U-Boot] [PATCH 1/1] dwc3-generic: Don't fail probe if clk/reset entries are absent Vignesh Raghavendra
@ 2019-10-25 8:20 ` Tero Kristo
2019-10-25 10:08 ` Sam Protsenko
2019-10-25 13:50 ` Marek Vasut
2 siblings, 0 replies; 5+ messages in thread
From: Tero Kristo @ 2019-10-25 8:20 UTC (permalink / raw)
To: u-boot
On 25/10/2019 11:18, Vignesh Raghavendra wrote:
> Some boards don't populate clk/reset entries as these are are optional
> as per binding documentation. Therefore, don't fail driver probe if
> clk/reset entries are absent in DT.
>
> This fixes fastboot failures seen due to enabling of CONFIG_CLK on AM57xx
>
> Fixes: e8e683d33b0c ("board: ti: am57xx-idk: Configure the CDCE913 clock synthesizer")
> Reported-by: Sam Protsenko <semen.protsenko@linaro.org>
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
Thanks for the patch.
Tested-by: Tero Kristo <t-kristo@ti.com>
> ---
> drivers/usb/dwc3/dwc3-generic.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-generic.c b/drivers/usb/dwc3/dwc3-generic.c
> index 406bf0b3628b..d76cd7a4c5ca 100644
> --- a/drivers/usb/dwc3/dwc3-generic.c
> +++ b/drivers/usb/dwc3/dwc3-generic.c
> @@ -258,7 +258,7 @@ static int dwc3_glue_reset_init(struct udevice *dev,
> int ret;
>
> ret = reset_get_bulk(dev, &glue->resets);
> - if (ret == -ENOTSUPP)
> + if (ret == -ENOTSUPP || ret == -ENOENT)
> return 0;
> else if (ret)
> return ret;
> @@ -278,7 +278,7 @@ static int dwc3_glue_clk_init(struct udevice *dev,
> int ret;
>
> ret = clk_get_bulk(dev, &glue->clks);
> - if (ret == -ENOSYS)
> + if (ret == -ENOSYS || ret == -ENOENT)
> return 0;
> if (ret)
> return ret;
>
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH 1/1] dwc3-generic: Don't fail probe if clk/reset entries are absent
2019-10-25 8:18 [U-Boot] [PATCH 1/1] dwc3-generic: Don't fail probe if clk/reset entries are absent Vignesh Raghavendra
2019-10-25 8:20 ` Tero Kristo
@ 2019-10-25 10:08 ` Sam Protsenko
2019-10-25 10:08 ` Sam Protsenko
2019-10-25 13:50 ` Marek Vasut
2 siblings, 1 reply; 5+ messages in thread
From: Sam Protsenko @ 2019-10-25 10:08 UTC (permalink / raw)
To: u-boot
Hi Vignesh,
On Fri, Oct 25, 2019 at 11:17 AM Vignesh Raghavendra <vigneshr@ti.com> wrote:
>
> Some boards don't populate clk/reset entries as these are are optional
> as per binding documentation. Therefore, don't fail driver probe if
> clk/reset entries are absent in DT.
>
> This fixes fastboot failures seen due to enabling of CONFIG_CLK on AM57xx
>
> Fixes: e8e683d33b0c ("board: ti: am57xx-idk: Configure the CDCE913 clock synthesizer")
> Reported-by: Sam Protsenko <semen.protsenko@linaro.org>
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
> ---
Tested-by: Sam Protsenko <semen.protsenko@linaro.org>
Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
> drivers/usb/dwc3/dwc3-generic.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-generic.c b/drivers/usb/dwc3/dwc3-generic.c
> index 406bf0b3628b..d76cd7a4c5ca 100644
> --- a/drivers/usb/dwc3/dwc3-generic.c
> +++ b/drivers/usb/dwc3/dwc3-generic.c
> @@ -258,7 +258,7 @@ static int dwc3_glue_reset_init(struct udevice *dev,
> int ret;
>
> ret = reset_get_bulk(dev, &glue->resets);
> - if (ret == -ENOTSUPP)
> + if (ret == -ENOTSUPP || ret == -ENOENT)
> return 0;
> else if (ret)
> return ret;
> @@ -278,7 +278,7 @@ static int dwc3_glue_clk_init(struct udevice *dev,
> int ret;
>
> ret = clk_get_bulk(dev, &glue->clks);
> - if (ret == -ENOSYS)
> + if (ret == -ENOSYS || ret == -ENOENT)
> return 0;
> if (ret)
> return ret;
> --
> 2.23.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH 1/1] dwc3-generic: Don't fail probe if clk/reset entries are absent
2019-10-25 10:08 ` Sam Protsenko
@ 2019-10-25 10:08 ` Sam Protsenko
0 siblings, 0 replies; 5+ messages in thread
From: Sam Protsenko @ 2019-10-25 10:08 UTC (permalink / raw)
To: u-boot
+ Praneeth
On Fri, Oct 25, 2019 at 1:08 PM Sam Protsenko
<semen.protsenko@linaro.org> wrote:
>
> Hi Vignesh,
>
> On Fri, Oct 25, 2019 at 11:17 AM Vignesh Raghavendra <vigneshr@ti.com> wrote:
> >
> > Some boards don't populate clk/reset entries as these are are optional
> > as per binding documentation. Therefore, don't fail driver probe if
> > clk/reset entries are absent in DT.
> >
> > This fixes fastboot failures seen due to enabling of CONFIG_CLK on AM57xx
> >
> > Fixes: e8e683d33b0c ("board: ti: am57xx-idk: Configure the CDCE913 clock synthesizer")
> > Reported-by: Sam Protsenko <semen.protsenko@linaro.org>
> > Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
> > ---
>
> Tested-by: Sam Protsenko <semen.protsenko@linaro.org>
> Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
>
> > drivers/usb/dwc3/dwc3-generic.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/usb/dwc3/dwc3-generic.c b/drivers/usb/dwc3/dwc3-generic.c
> > index 406bf0b3628b..d76cd7a4c5ca 100644
> > --- a/drivers/usb/dwc3/dwc3-generic.c
> > +++ b/drivers/usb/dwc3/dwc3-generic.c
> > @@ -258,7 +258,7 @@ static int dwc3_glue_reset_init(struct udevice *dev,
> > int ret;
> >
> > ret = reset_get_bulk(dev, &glue->resets);
> > - if (ret == -ENOTSUPP)
> > + if (ret == -ENOTSUPP || ret == -ENOENT)
> > return 0;
> > else if (ret)
> > return ret;
> > @@ -278,7 +278,7 @@ static int dwc3_glue_clk_init(struct udevice *dev,
> > int ret;
> >
> > ret = clk_get_bulk(dev, &glue->clks);
> > - if (ret == -ENOSYS)
> > + if (ret == -ENOSYS || ret == -ENOENT)
> > return 0;
> > if (ret)
> > return ret;
> > --
> > 2.23.0
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH 1/1] dwc3-generic: Don't fail probe if clk/reset entries are absent
2019-10-25 8:18 [U-Boot] [PATCH 1/1] dwc3-generic: Don't fail probe if clk/reset entries are absent Vignesh Raghavendra
2019-10-25 8:20 ` Tero Kristo
2019-10-25 10:08 ` Sam Protsenko
@ 2019-10-25 13:50 ` Marek Vasut
2 siblings, 0 replies; 5+ messages in thread
From: Marek Vasut @ 2019-10-25 13:50 UTC (permalink / raw)
To: u-boot
On 10/25/19 10:18 AM, Vignesh Raghavendra wrote:
> Some boards don't populate clk/reset entries as these are are optional
> as per binding documentation. Therefore, don't fail driver probe if
> clk/reset entries are absent in DT.
>
> This fixes fastboot failures seen due to enabling of CONFIG_CLK on AM57xx
Applied, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-10-25 13:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-25 8:18 [U-Boot] [PATCH 1/1] dwc3-generic: Don't fail probe if clk/reset entries are absent Vignesh Raghavendra
2019-10-25 8:20 ` Tero Kristo
2019-10-25 10:08 ` Sam Protsenko
2019-10-25 10:08 ` Sam Protsenko
2019-10-25 13:50 ` Marek Vasut
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.