* [PATCH] f2fs: remove unused cp_blkaddr in f2fs_sanity_check_ckpt
@ 2018-07-31 5:21 Junling Zheng
2018-08-01 6:54 ` Chao Yu
0 siblings, 1 reply; 3+ messages in thread
From: Junling Zheng @ 2018-07-31 5:21 UTC (permalink / raw)
To: jaegeuk, yuchao0; +Cc: miaoxie, linux-f2fs-devel
Remove unused cp_blkaddr in f2fs_sanity_check_ckpt().
Signed-off-by: Junling Zheng <zhengjunling@huawei.com>
---
fs/f2fs/super.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index d56bc6eb8760..6ee003e87f63 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -2297,7 +2297,7 @@ int f2fs_sanity_check_ckpt(struct f2fs_sb_info *sbi)
unsigned int sit_bitmap_size, nat_bitmap_size;
unsigned int log_blocks_per_seg;
unsigned int segment_count_main;
- unsigned int cp_pack_start_sum, cp_blkaddr, cp_payload;
+ unsigned int cp_pack_start_sum, cp_payload;
block_t user_block_count;
int i;
@@ -2359,7 +2359,6 @@ int f2fs_sanity_check_ckpt(struct f2fs_sb_info *sbi)
}
cp_pack_start_sum = __start_sum_addr(sbi);
- cp_blkaddr = __start_cp_addr(sbi);
cp_payload = __cp_payload(sbi);
if (cp_pack_start_sum < cp_payload + 1 ||
cp_pack_start_sum > blocks_per_seg - 1 -
--
2.18.0
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] f2fs: remove unused cp_blkaddr in f2fs_sanity_check_ckpt
2018-07-31 5:21 [PATCH] f2fs: remove unused cp_blkaddr in f2fs_sanity_check_ckpt Junling Zheng
@ 2018-08-01 6:54 ` Chao Yu
2018-08-01 8:06 ` Junling Zheng
0 siblings, 1 reply; 3+ messages in thread
From: Chao Yu @ 2018-08-01 6:54 UTC (permalink / raw)
To: Junling Zheng, jaegeuk; +Cc: miaoxie, linux-f2fs-devel
Hi Junling,
On 2018/7/31 13:21, Junling Zheng wrote:
> Remove unused cp_blkaddr in f2fs_sanity_check_ckpt().
Since this issue is introduced by recent change, and the related patch has not
been upstreamed yet, can we merge this into that patch, if you don't mind?
Thanks,
>
> Signed-off-by: Junling Zheng <zhengjunling@huawei.com>
> ---
> fs/f2fs/super.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index d56bc6eb8760..6ee003e87f63 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -2297,7 +2297,7 @@ int f2fs_sanity_check_ckpt(struct f2fs_sb_info *sbi)
> unsigned int sit_bitmap_size, nat_bitmap_size;
> unsigned int log_blocks_per_seg;
> unsigned int segment_count_main;
> - unsigned int cp_pack_start_sum, cp_blkaddr, cp_payload;
> + unsigned int cp_pack_start_sum, cp_payload;
> block_t user_block_count;
> int i;
>
> @@ -2359,7 +2359,6 @@ int f2fs_sanity_check_ckpt(struct f2fs_sb_info *sbi)
> }
>
> cp_pack_start_sum = __start_sum_addr(sbi);
> - cp_blkaddr = __start_cp_addr(sbi);
> cp_payload = __cp_payload(sbi);
> if (cp_pack_start_sum < cp_payload + 1 ||
> cp_pack_start_sum > blocks_per_seg - 1 -
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] f2fs: remove unused cp_blkaddr in f2fs_sanity_check_ckpt
2018-08-01 6:54 ` Chao Yu
@ 2018-08-01 8:06 ` Junling Zheng
0 siblings, 0 replies; 3+ messages in thread
From: Junling Zheng @ 2018-08-01 8:06 UTC (permalink / raw)
To: Chao Yu, jaegeuk; +Cc: miaoxie, linux-f2fs-devel
On 2018/8/1 14:54, Chao Yu wrote:
> Hi Junling,
>
> On 2018/7/31 13:21, Junling Zheng wrote:
>> Remove unused cp_blkaddr in f2fs_sanity_check_ckpt().
>
> Since this issue is introduced by recent change, and the related patch has not
> been upstreamed yet, can we merge this into that patch, if you don't mind?
>
OK, I don't mind :)
> Thanks,
>
>>
>> Signed-off-by: Junling Zheng <zhengjunling@huawei.com>
>> ---
>> fs/f2fs/super.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
>> index d56bc6eb8760..6ee003e87f63 100644
>> --- a/fs/f2fs/super.c
>> +++ b/fs/f2fs/super.c
>> @@ -2297,7 +2297,7 @@ int f2fs_sanity_check_ckpt(struct f2fs_sb_info *sbi)
>> unsigned int sit_bitmap_size, nat_bitmap_size;
>> unsigned int log_blocks_per_seg;
>> unsigned int segment_count_main;
>> - unsigned int cp_pack_start_sum, cp_blkaddr, cp_payload;
>> + unsigned int cp_pack_start_sum, cp_payload;
>> block_t user_block_count;
>> int i;
>>
>> @@ -2359,7 +2359,6 @@ int f2fs_sanity_check_ckpt(struct f2fs_sb_info *sbi)
>> }
>>
>> cp_pack_start_sum = __start_sum_addr(sbi);
>> - cp_blkaddr = __start_cp_addr(sbi);
>> cp_payload = __cp_payload(sbi);
>> if (cp_pack_start_sum < cp_payload + 1 ||
>> cp_pack_start_sum > blocks_per_seg - 1 -
>>
>
>
> .
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-01 8:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-31 5:21 [PATCH] f2fs: remove unused cp_blkaddr in f2fs_sanity_check_ckpt Junling Zheng
2018-08-01 6:54 ` Chao Yu
2018-08-01 8:06 ` Junling Zheng
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.