[ipset PATCH] tests: hash:ip,port.t: Replace VRRP by GRE protocol

[ipset PATCH] tests: hash:ip,port.t: Replace VRRP by GRE protocol

[Phil Sutter]

Some systems may not have "vrrp" as alias to "carp" yet, so use a
protocol which is less likely to cause problems for testing purposes.

Fixes: a67aa712ed912 ("tests: hash:ip,port.t: 'vrrp' is printed as 'carp'")
Signed-off-by: Phil Sutter <phil@nwl.cc>
---
 tests/hash:ip,port.t       | 8 ++++----
 tests/hash:ip,port.t.list2 | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/tests/hash:ip,port.t b/tests/hash:ip,port.t
index addbe3be1f787..f65fb59116824 100644
--- a/tests/hash:ip,port.t
+++ b/tests/hash:ip,port.t
@@ -62,10 +62,10 @@
 0 ipset test test 2.0.0.1,tcp:80
 # Test element with UDP protocol
 0 ipset test test 2.0.0.1,udp:80
-# Add element with vrrp
-0 ipset add test 2.0.0.1,vrrp:0
-# Test element with vrrp
-0 ipset test test 2.0.0.1,vrrp:0
+# Add element with GRE
+0 ipset add test 2.0.0.1,gre:0
+# Test element with GRE
+0 ipset test test 2.0.0.1,gre:0
 # Add element with sctp
 0 ipset add test 2.0.0.1,sctp:80
 # Test element with sctp
diff --git a/tests/hash:ip,port.t.list2 b/tests/hash:ip,port.t.list2
index 0c5d3a15ef369..25504227d4fd7 100644
--- a/tests/hash:ip,port.t.list2
+++ b/tests/hash:ip,port.t.list2
@@ -6,6 +6,6 @@ Size in memory: 480
 References: 0
 Number of entries: 3
 Members:
-2.0.0.1,carp:0
+2.0.0.1,gre:0
 2.0.0.1,tcp:80
 2.0.0.1,udp:80
-- 
2.38.0

Re: [ipset PATCH] tests: hash:ip,port.t: Replace VRRP by GRE protocol

[Pablo Neira Ayuso]

On Fri, Mar 10, 2023 at 06:49:03PM +0100, Phil Sutter wrote:
> Some systems may not have "vrrp" as alias to "carp" yet, so use a
> protocol which is less likely to cause problems for testing purposes.

LGTM, thanks

Re: [ipset PATCH] tests: hash:ip,port.t: Replace VRRP by GRE protocol

[Phil Sutter]

On Fri, Mar 10, 2023 at 06:49:03PM +0100, Phil Sutter wrote:
> Some systems may not have "vrrp" as alias to "carp" yet, so use a
> protocol which is less likely to cause problems for testing purposes.
> 
> Fixes: a67aa712ed912 ("tests: hash:ip,port.t: 'vrrp' is printed as 'carp'")
> Signed-off-by: Phil Sutter <phil@nwl.cc>

Patch applied.

Re: [ipset PATCH] tests: hash:ip,port.t: Replace VRRP by GRE protocol

[Jozsef Kadlecsik]

Hi Phil, Pablo,

On Fri, 10 Mar 2023, Phil Sutter wrote:

> On Fri, Mar 10, 2023 at 06:49:03PM +0100, Phil Sutter wrote:
> > Some systems may not have "vrrp" as alias to "carp" yet, so use a
> > protocol which is less likely to cause problems for testing purposes.
> > 
> > Fixes: a67aa712ed912 ("tests: hash:ip,port.t: 'vrrp' is printed as 'carp'")
> > Signed-off-by: Phil Sutter <phil@nwl.cc>
> 
> Patch applied.

Thank you for helping me out in these times! For the time being I can only 
work on ipset sporadically.

Best regards,
Jozsef
-
E-mail  : kadlec@blackhole.kfki.hu, kadlecsik.jozsef@wigner.hu
PGP key : https://wigner.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics
          H-1525 Budapest 114, POB. 49, Hungary