[Buildroot] [PATCH 1/1] package/brotli: workaround m68k build issues

[Buildroot] [PATCH 1/1] package/brotli: workaround m68k build issues

[Adrian Perez de Castro]

On m68k building with optimizations  results in failures such as:

/tmp/cckiMnG5.s: Assembler messages:
/tmp/cckiMnG5.s:142572: Error: value -39206 out of range
/tmp/cckiMnG5.s:142629: Error: value -40282 out of range
/tmp/cckiMnG5.s:146408: Error: value -53294 out of range
/tmp/cckiMnG5.s:159014: Error: value -39206 out of range
/tmp/cckiMnG5.s:159071: Error: value -40282 out of range
/tmp/cckiMnG5.s:162850: Error: value -53294 out of range
/tmp/cckiMnG5.s:175456: Error: value -39206 out of range
/tmp/cckiMnG5.s:175513: Error: value -40282 out of range
/tmp/cckiMnG5.s:179292: Error: value -53294 out of range
/tmp/cckiMnG5.s:191898: Error: value -39206 out of range
/tmp/cckiMnG5.s:191955: Error: value -40282 out of range
/tmp/cckiMnG5.s:195734: Error: value -53294 out of range

These only appear when building with -O2, the smaller code generated
with -Os does not cause trouble, so workaround by using that.

Fixes:

  http://autobuild.buildroot.net/results/2f222d5a86b4237b81ca31dba89f58b0e6e879db/

Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>
---
 package/brotli/brotli.mk | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/package/brotli/brotli.mk b/package/brotli/brotli.mk
index 43c8524c0b..ac49fe664f 100644
--- a/package/brotli/brotli.mk
+++ b/package/brotli/brotli.mk
@@ -21,6 +21,12 @@ ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_68485),y)
 BROTLI_CFLAGS += -O0
 endif
 
+# Workaround "Error: value -1234 out of range" assembler issues
+# when building with optimizations.
+ifeq ($(BR2_m68k),y)
+BROTLI_CFLAGS += -Os
+endif
+
 BROTLI_CONF_OPTS += -DCMAKE_C_FLAGS="$(BROTLI_CFLAGS)"
 
 $(eval $(cmake-package))
-- 
2.36.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/brotli: workaround m68k build issues

[Arnout Vandecappelle]

On 27/04/2022 10:17, Adrian Perez de Castro wrote:
> On m68k building with optimizations  results in failures such as:
> 
> /tmp/cckiMnG5.s: Assembler messages:
> /tmp/cckiMnG5.s:142572: Error: value -39206 out of range
> /tmp/cckiMnG5.s:142629: Error: value -40282 out of range
> /tmp/cckiMnG5.s:146408: Error: value -53294 out of range
> /tmp/cckiMnG5.s:159014: Error: value -39206 out of range
> /tmp/cckiMnG5.s:159071: Error: value -40282 out of range
> /tmp/cckiMnG5.s:162850: Error: value -53294 out of range
> /tmp/cckiMnG5.s:175456: Error: value -39206 out of range
> /tmp/cckiMnG5.s:175513: Error: value -40282 out of range
> /tmp/cckiMnG5.s:179292: Error: value -53294 out of range
> /tmp/cckiMnG5.s:191898: Error: value -39206 out of range
> /tmp/cckiMnG5.s:191955: Error: value -40282 out of range
> /tmp/cckiMnG5.s:195734: Error: value -53294 out of range
> 
> These only appear when building with -O2, the smaller code generated
> with -Os does not cause trouble, so workaround by using that.
> 
> Fixes:
> 
>    http://autobuild.buildroot.net/results/2f222d5a86b4237b81ca31dba89f58b0e6e879db/
> 
> Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>

  Applied to master, thanks.

  Regards,
  Arnout

> ---
>   package/brotli/brotli.mk | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/package/brotli/brotli.mk b/package/brotli/brotli.mk
> index 43c8524c0b..ac49fe664f 100644
> --- a/package/brotli/brotli.mk
> +++ b/package/brotli/brotli.mk
> @@ -21,6 +21,12 @@ ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_68485),y)
>   BROTLI_CFLAGS += -O0
>   endif
>   
> +# Workaround "Error: value -1234 out of range" assembler issues
> +# when building with optimizations.
> +ifeq ($(BR2_m68k),y)
> +BROTLI_CFLAGS += -Os
> +endif
> +
>   BROTLI_CONF_OPTS += -DCMAKE_C_FLAGS="$(BROTLI_CFLAGS)"
>   
>   $(eval $(cmake-package))
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/brotli: workaround m68k build issues

[Peter Korsgaard]

>>>>> "Adrian" == Adrian Perez de Castro <aperez@igalia.com> writes:

 > On m68k building with optimizations  results in failures such as:
 > /tmp/cckiMnG5.s: Assembler messages:
 > /tmp/cckiMnG5.s:142572: Error: value -39206 out of range
 > /tmp/cckiMnG5.s:142629: Error: value -40282 out of range
 > /tmp/cckiMnG5.s:146408: Error: value -53294 out of range
 > /tmp/cckiMnG5.s:159014: Error: value -39206 out of range
 > /tmp/cckiMnG5.s:159071: Error: value -40282 out of range
 > /tmp/cckiMnG5.s:162850: Error: value -53294 out of range
 > /tmp/cckiMnG5.s:175456: Error: value -39206 out of range
 > /tmp/cckiMnG5.s:175513: Error: value -40282 out of range
 > /tmp/cckiMnG5.s:179292: Error: value -53294 out of range
 > /tmp/cckiMnG5.s:191898: Error: value -39206 out of range
 > /tmp/cckiMnG5.s:191955: Error: value -40282 out of range
 > /tmp/cckiMnG5.s:195734: Error: value -53294 out of range

 > These only appear when building with -O2, the smaller code generated
 > with -Os does not cause trouble, so workaround by using that.

 > Fixes:

 >   http://autobuild.buildroot.net/results/2f222d5a86b4237b81ca31dba89f58b0e6e879db/

 > Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>

Committed to 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot