All of lore.kernel.org
 help / color / mirror / Atom feed
From: "liuyd.fnst@fujitsu.com" <liuyd.fnst@fujitsu.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: "virtio-fs@redhat.com" <virtio-fs@redhat.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	Vivek Goyal <vgoyal@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH] docs: Correct the default thread-pool-size
Date: Thu, 21 Apr 2022 10:24:42 +0000	[thread overview]
Message-ID: <f03b52d2-8d3f-6caf-8983-cb0773172838@fujitsu.com> (raw)
In-Reply-To: <YlgRRcgIbbE+ZKb7@redhat.com>

Hi, Stefan

Please help review it. I'm sorry that I forgot to add you to the 
recipient 😅

On 4/14/22 8:19 PM, Vivek Goyal wrote:
> On Wed, Apr 13, 2022 at 12:20:54PM +0800, Liu Yiding wrote:
>> Refer to 26ec190964 virtiofsd: Do not use a thread pool by default
>>
>> Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com>
> Looks good. Our default used to be --thread-pool-size=64. But we changed
> it to using no thread pool because on lower end of workloads it performed
> better. When multiple threads are doing parallel I/O then, thread pool
> helps. So people who want to do lots of parallel I/O should manually
> enable thread pool.
>
> Acked-by: Vivek Goyal <vgoyal@redhat.com>
>
> Vivek
>> ---
>>   docs/tools/virtiofsd.rst | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/docs/tools/virtiofsd.rst b/docs/tools/virtiofsd.rst
>> index 0c0560203c..33fed08c6f 100644
>> --- a/docs/tools/virtiofsd.rst
>> +++ b/docs/tools/virtiofsd.rst
>> @@ -127,7 +127,7 @@ Options
>>   .. option:: --thread-pool-size=NUM
>>   
>>     Restrict the number of worker threads per request queue to NUM.  The default
>> -  is 64.
>> +  is 0.
>>   
>>   .. option:: --cache=none|auto|always
>>   
>> -- 
>> 2.31.1
>>
>>
>>
>>
-- 
Best Regards.
Yiding Liu

WARNING: multiple messages have this Message-ID (diff)
From: "liuyd.fnst@fujitsu.com" <liuyd.fnst@fujitsu.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	Vivek Goyal <vgoyal@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	"virtio-fs@redhat.com" <virtio-fs@redhat.com>
Subject: Re: [Virtio-fs] [PATCH] docs: Correct the default thread-pool-size
Date: Thu, 21 Apr 2022 10:24:42 +0000	[thread overview]
Message-ID: <f03b52d2-8d3f-6caf-8983-cb0773172838@fujitsu.com> (raw)
In-Reply-To: <YlgRRcgIbbE+ZKb7@redhat.com>

Hi, Stefan

Please help review it. I'm sorry that I forgot to add you to the 
recipient 😅

On 4/14/22 8:19 PM, Vivek Goyal wrote:
> On Wed, Apr 13, 2022 at 12:20:54PM +0800, Liu Yiding wrote:
>> Refer to 26ec190964 virtiofsd: Do not use a thread pool by default
>>
>> Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com>
> Looks good. Our default used to be --thread-pool-size=64. But we changed
> it to using no thread pool because on lower end of workloads it performed
> better. When multiple threads are doing parallel I/O then, thread pool
> helps. So people who want to do lots of parallel I/O should manually
> enable thread pool.
>
> Acked-by: Vivek Goyal <vgoyal@redhat.com>
>
> Vivek
>> ---
>>   docs/tools/virtiofsd.rst | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/docs/tools/virtiofsd.rst b/docs/tools/virtiofsd.rst
>> index 0c0560203c..33fed08c6f 100644
>> --- a/docs/tools/virtiofsd.rst
>> +++ b/docs/tools/virtiofsd.rst
>> @@ -127,7 +127,7 @@ Options
>>   .. option:: --thread-pool-size=NUM
>>   
>>     Restrict the number of worker threads per request queue to NUM.  The default
>> -  is 64.
>> +  is 0.
>>   
>>   .. option:: --cache=none|auto|always
>>   
>> -- 
>> 2.31.1
>>
>>
>>
>>
-- 
Best Regards.
Yiding Liu

  reply	other threads:[~2022-04-21 10:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-13  4:20 [PATCH] docs: Correct the default thread-pool-size Liu Yiding
2022-04-14  5:05 ` liuyd.fnst
2022-04-14 10:03   ` liuyd.fnst
2022-04-14 12:19 ` Vivek Goyal
2022-04-21 10:24   ` liuyd.fnst [this message]
2022-04-21 10:24     ` [Virtio-fs] " liuyd.fnst
2022-04-27  1:12   ` liuyd.fnst
2022-05-06  2:09     ` liuyd.fnst
2022-05-09 15:23 ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f03b52d2-8d3f-6caf-8983-cb0773172838@fujitsu.com \
    --to=liuyd.fnst@fujitsu.com \
    --cc=dgilbert@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=vgoyal@redhat.com \
    --cc=virtio-fs@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.