* Re: [PATCH v2] scsi: remove extra white space at the end of the line
[not found] <20171221113535.38734-1-yanaijie@huawei.com>
@ 2017-12-21 13:38 ` Damien Le Moal
0 siblings, 0 replies; only message in thread
From: Damien Le Moal @ 2017-12-21 13:38 UTC (permalink / raw)
To: Jason Yan, martin.petersen, jejb; +Cc: linux-scsi, jthumshirn
Jason,
On 2017/12/21 20:35, Jason Yan wrote:
> My editor always try to remove the extra white space at the end of the
> line when I make some changes. I'm tired of adjusting them manually.
> Can we remove them in mainline?
>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
> drivers/scsi/3w-9xxx.c | 48 ++---
> drivers/scsi/3w-sas.c | 42 ++--
> drivers/scsi/3w-xxxx.c | 140 ++++++------
> drivers/scsi/3w-xxxx.h | 66 +++---
> drivers/scsi/53c700.c | 104 ++++-----
> drivers/scsi/53c700.h | 8 +-
> drivers/scsi/FlashPoint.c | 10 +-
> drivers/scsi/NCR5380.h | 22 +-
> drivers/scsi/NCR53c406a.c | 26 +--
> drivers/scsi/NCR_D700.c | 8 +-
> drivers/scsi/NCR_Q720.c | 10 +-
> drivers/scsi/a100u2w.c | 2 +-
> drivers/scsi/advansys.c | 2 +-
> drivers/scsi/aha1542.c | 14 +-
> drivers/scsi/aha1740.c | 36 ++--
> drivers/scsi/atp870u.c | 180 ++++++++--------
> drivers/scsi/atp870u.h | 2 +-
> drivers/scsi/dc395x.c | 84 ++++----
> drivers/scsi/dmx3191d.c | 2 +-
> drivers/scsi/dpt_i2o.c | 242 ++++++++++-----------
> drivers/scsi/dpti.h | 14 +-
> drivers/scsi/eata.c | 4 +-
> drivers/scsi/eata_generic.h | 58 ++---
> drivers/scsi/eata_pio.c | 18 +-
> drivers/scsi/eata_pio.h | 2 +-
> drivers/scsi/fdomain.c | 106 ++++-----
> drivers/scsi/gdth.c | 422 ++++++++++++++++++------------------
> drivers/scsi/gdth.h | 40 ++--
> drivers/scsi/gdth_ioctl.h | 8 +-
> drivers/scsi/gdth_proc.c | 62 +++---
> drivers/scsi/gdth_proc.h | 2 +-
> drivers/scsi/hosts.c | 6 +-
> drivers/scsi/imm.c | 18 +-
> drivers/scsi/imm.h | 8 +-
> drivers/scsi/initio.c | 2 +-
> drivers/scsi/lasi700.c | 4 +-
> drivers/scsi/mac53c94.c | 6 +-
> drivers/scsi/megaraid.c | 42 ++--
> drivers/scsi/mesh.c | 22 +-
> drivers/scsi/ncr53c8xx.c | 440 +++++++++++++++++++-------------------
> drivers/scsi/ncr53c8xx.h | 78 +++----
> drivers/scsi/nsp32.c | 116 +++++-----
> drivers/scsi/nsp32_debug.c | 22 +-
> drivers/scsi/osst.c | 168 +++++++--------
> drivers/scsi/osst.h | 8 +-
> drivers/scsi/osst_options.h | 6 +-
> drivers/scsi/ppa.c | 38 ++--
> drivers/scsi/ppa.h | 10 +-
> drivers/scsi/qla1280.c | 22 +-
> drivers/scsi/qla1280.h | 10 +-
> drivers/scsi/qlogicfas.c | 10 +-
> drivers/scsi/qlogicfas408.c | 52 ++---
> drivers/scsi/qlogicpti.c | 8 +-
> drivers/scsi/qlogicpti.h | 2 +-
> drivers/scsi/raid_class.c | 6 +-
> drivers/scsi/scsi.c | 2 +-
> drivers/scsi/scsi.h | 2 +-
> drivers/scsi/scsi_debug.c | 2 +-
> drivers/scsi/scsi_ioctl.c | 22 +-
> drivers/scsi/scsi_lib.c | 20 +-
> drivers/scsi/scsi_priv.h | 4 +-
> drivers/scsi/scsi_proc.c | 12 +-
> drivers/scsi/scsi_scan.c | 10 +-
> drivers/scsi/scsi_sysfs.c | 4 +-
> drivers/scsi/scsi_transport_spi.c | 48 ++---
> drivers/scsi/scsicam.c | 6 +-
> drivers/scsi/sd.c | 60 +++---
> drivers/scsi/sg.c | 14 +-
> drivers/scsi/sgiwd93.c | 2 +-
> drivers/scsi/sim710.c | 4 +-
> drivers/scsi/sr.c | 6 +-
> drivers/scsi/sr.h | 6 +-
> drivers/scsi/sr_ioctl.c | 8 +-
> drivers/scsi/sr_vendor.c | 8 +-
> drivers/scsi/st.c | 4 +-
> drivers/scsi/sun3_scsi.c | 34 +--
> drivers/scsi/sym53c416.c | 20 +-
> drivers/scsi/sym53c416.h | 2 +-
> drivers/scsi/zalon.c | 6 +-
> 79 files changed, 1597 insertions(+), 1597 deletions(-)
scripts/checkpatch.pl reports 220 instances of white spaces at the *beginning*
of lines, and that is only for what your patches touched and the lines around them.
If I run in the drivers/scsi directory the command:
grep -r '^ [[ ]]*' *.[ch] | wc -l
I get 8795 lines. I guess you could make your patch even bigger:)
If we exclude leading spaces, applying the patch and doing a "diff -rb" of the
patched scsi files against the original unpatched files leads to no differences
at all. So it looks good.
Best regards.
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-12-21 13:38 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20171221113535.38734-1-yanaijie@huawei.com>
2017-12-21 13:38 ` [PATCH v2] scsi: remove extra white space at the end of the line Damien Le Moal
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.