[PATCH libdrm] amdgpu: Deinitialize vamgr_high{,_32}

[PATCH libdrm] amdgpu: Deinitialize vamgr_high{,_32}

[Michel Dänzer]

From: Michel Dänzer <michel.daenzer@amd.com>

Fixes memory leaks.

Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>
---
 amdgpu/amdgpu_device.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/amdgpu/amdgpu_device.c b/amdgpu/amdgpu_device.c
index d81efcf8..983b19ab 100644
--- a/amdgpu/amdgpu_device.c
+++ b/amdgpu/amdgpu_device.c
@@ -128,6 +128,8 @@ static void amdgpu_device_free_internal(amdgpu_device_handle dev)
 {
 	amdgpu_vamgr_deinit(&dev->vamgr_32);
 	amdgpu_vamgr_deinit(&dev->vamgr);
+	amdgpu_vamgr_deinit(&dev->vamgr_high_32);
+	amdgpu_vamgr_deinit(&dev->vamgr_high);
 	util_hash_table_destroy(dev->bo_flink_names);
 	util_hash_table_destroy(dev->bo_handles);
 	pthread_mutex_destroy(&dev->bo_table_mutex);
-- 
2.17.0

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH libdrm] amdgpu: Deinitialize vamgr_high{,_32}

[Michel Dänzer]

On 2018-04-27 04:44 PM, Michel Dänzer wrote:
> From: Michel Dänzer <michel.daenzer@amd.com>
> 
> Fixes memory leaks.
> 
> Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>
> ---
>  amdgpu/amdgpu_device.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/amdgpu/amdgpu_device.c b/amdgpu/amdgpu_device.c
> index d81efcf8..983b19ab 100644
> --- a/amdgpu/amdgpu_device.c
> +++ b/amdgpu/amdgpu_device.c
> @@ -128,6 +128,8 @@ static void amdgpu_device_free_internal(amdgpu_device_handle dev)
>  {
>  	amdgpu_vamgr_deinit(&dev->vamgr_32);
>  	amdgpu_vamgr_deinit(&dev->vamgr);
> +	amdgpu_vamgr_deinit(&dev->vamgr_high_32);
> +	amdgpu_vamgr_deinit(&dev->vamgr_high);
>  	util_hash_table_destroy(dev->bo_flink_names);
>  	util_hash_table_destroy(dev->bo_handles);
>  	pthread_mutex_destroy(&dev->bo_table_mutex);
> 

Any reviews? Without negative feedback, I'll push this tomorrow.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH libdrm] amdgpu: Deinitialize vamgr_high{,_32}

[Andrey Grodzovsky]

[-- Attachment #1.1: Type: text/plain, Size: 1103 bytes --]

Reviewed-by: Andrey Grodzovsky <andrey.grodzovsky-5C7GfCeVMHo@public.gmane.org>

Andrey


On 05/01/2018 04:03 AM, Michel Dänzer wrote:
> On 2018-04-27 04:44 PM, Michel Dänzer wrote:
>> From: Michel Dänzer <michel.daenzer-5C7GfCeVMHo@public.gmane.org>
>>
>> Fixes memory leaks.
>>
>> Signed-off-by: Michel Dänzer <michel.daenzer-5C7GfCeVMHo@public.gmane.org>
>> ---
>>   amdgpu/amdgpu_device.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/amdgpu/amdgpu_device.c b/amdgpu/amdgpu_device.c
>> index d81efcf8..983b19ab 100644
>> --- a/amdgpu/amdgpu_device.c
>> +++ b/amdgpu/amdgpu_device.c
>> @@ -128,6 +128,8 @@ static void amdgpu_device_free_internal(amdgpu_device_handle dev)
>>   {
>>   	amdgpu_vamgr_deinit(&dev->vamgr_32);
>>   	amdgpu_vamgr_deinit(&dev->vamgr);
>> +	amdgpu_vamgr_deinit(&dev->vamgr_high_32);
>> +	amdgpu_vamgr_deinit(&dev->vamgr_high);
>>   	util_hash_table_destroy(dev->bo_flink_names);
>>   	util_hash_table_destroy(dev->bo_handles);
>>   	pthread_mutex_destroy(&dev->bo_table_mutex);
>>
> Any reviews? Without negative feedback, I'll push this tomorrow.
>
>


[-- Attachment #1.2: Type: text/html, Size: 1922 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH libdrm] amdgpu: Deinitialize vamgr_high{,_32}

[Christian König]

[-- Attachment #1.1: Type: text/plain, Size: 1464 bytes --]

Reviewed-by: Christian König <christian.koenig-5C7GfCeVMHo@public.gmane.org>

Am 01.05.2018 um 13:20 schrieb Andrey Grodzovsky:
>
> Reviewed-by: Andrey Grodzovsky <andrey.grodzovsky-5C7GfCeVMHo@public.gmane.org>
>
> Andrey
>
>
> On 05/01/2018 04:03 AM, Michel Dänzer wrote:
>> On 2018-04-27 04:44 PM, Michel Dänzer wrote:
>>> From: Michel Dänzer<michel.daenzer-5C7GfCeVMHo@public.gmane.org>
>>>
>>> Fixes memory leaks.
>>>
>>> Signed-off-by: Michel Dänzer<michel.daenzer-5C7GfCeVMHo@public.gmane.org>
>>> ---
>>>   amdgpu/amdgpu_device.c | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/amdgpu/amdgpu_device.c b/amdgpu/amdgpu_device.c
>>> index d81efcf8..983b19ab 100644
>>> --- a/amdgpu/amdgpu_device.c
>>> +++ b/amdgpu/amdgpu_device.c
>>> @@ -128,6 +128,8 @@ static void amdgpu_device_free_internal(amdgpu_device_handle dev)
>>>   {
>>>   	amdgpu_vamgr_deinit(&dev->vamgr_32);
>>>   	amdgpu_vamgr_deinit(&dev->vamgr);
>>> +	amdgpu_vamgr_deinit(&dev->vamgr_high_32);
>>> +	amdgpu_vamgr_deinit(&dev->vamgr_high);
>>>   	util_hash_table_destroy(dev->bo_flink_names);
>>>   	util_hash_table_destroy(dev->bo_handles);
>>>   	pthread_mutex_destroy(&dev->bo_table_mutex);
>>>
>> Any reviews? Without negative feedback, I'll push this tomorrow.
>>
>>
>
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


[-- Attachment #1.2: Type: text/html, Size: 3049 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx