* [PATCH 1/3] net/sfc/base: fix failure path in EF10 Tx queue PIO enable
@ 2017-04-04 12:13 Andrew Rybchenko
2017-04-04 12:13 ` [PATCH 2/3] net/sfc/base: fix potential buffer overflow in Tx queue init Andrew Rybchenko
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Andrew Rybchenko @ 2017-04-04 12:13 UTC (permalink / raw)
To: dev; +Cc: Andy Moreton, stable
From: Andy Moreton <amoreton@solarflare.com>
Coverity issue: 1387551
Fixes: e7cd430c864f ("net/sfc/base: import SFN7xxx family support")
Cc: stable@dpdk.org
Signed-off-by: Andy Moreton <amoreton@solarflare.com>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
drivers/net/sfc/base/ef10_tx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/sfc/base/ef10_tx.c b/drivers/net/sfc/base/ef10_tx.c
index 0f48a6c..6ad11dd 100644
--- a/drivers/net/sfc/base/ef10_tx.c
+++ b/drivers/net/sfc/base/ef10_tx.c
@@ -282,9 +282,9 @@ ef10_tx_qpio_enable(
fail3:
EFSYS_PROBE(fail3);
ef10_nic_pio_free(enp, etp->et_pio_bufnum, etp->et_pio_blknum);
- etp->et_pio_size = 0;
fail2:
EFSYS_PROBE(fail2);
+ etp->et_pio_size = 0;
fail1:
EFSYS_PROBE1(fail1, efx_rc_t, rc);
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/3] net/sfc/base: fix potential buffer overflow in Tx queue init
2017-04-04 12:13 [PATCH 1/3] net/sfc/base: fix failure path in EF10 Tx queue PIO enable Andrew Rybchenko
@ 2017-04-04 12:13 ` Andrew Rybchenko
2017-04-04 12:13 ` [PATCH 3/3] net/sfc/base: fix out of bounds read in VIs allocation Andrew Rybchenko
2017-04-04 13:18 ` [dpdk-stable] [PATCH 1/3] net/sfc/base: fix failure path in EF10 Tx queue PIO enable Ferruh Yigit
2 siblings, 0 replies; 4+ messages in thread
From: Andrew Rybchenko @ 2017-04-04 12:13 UTC (permalink / raw)
To: dev; +Cc: Andy Moreton, stable
From: Andy Moreton <amoreton@solarflare.com>
Improve error checking to avoid a caller overflowing the MCDI
request buffer if the requested TXQ size was excessively large.
Coverity issue: 1305527
Fixes: e7cd430c864f ("net/sfc/base: import SFN7xxx family support")
CC: stable@dpdk.org
Signed-off-by: Andy Moreton <amoreton@solarflare.com>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
drivers/net/sfc/base/ef10_tx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/sfc/base/ef10_tx.c b/drivers/net/sfc/base/ef10_tx.c
index 6ad11dd..0f8e9b1 100644
--- a/drivers/net/sfc/base/ef10_tx.c
+++ b/drivers/net/sfc/base/ef10_tx.c
@@ -67,7 +67,7 @@ efx_mcdi_init_txq(
EFX_TXQ_NBUFS(enp->en_nic_cfg.enc_txq_max_ndescs));
npages = EFX_TXQ_NBUFS(size);
- if (npages > MC_CMD_INIT_TXQ_IN_DMA_ADDR_MAXNUM) {
+ if (MC_CMD_INIT_TXQ_IN_LEN(npages) > sizeof (payload)) {
rc = EINVAL;
goto fail1;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 3/3] net/sfc/base: fix out of bounds read in VIs allocation
2017-04-04 12:13 [PATCH 1/3] net/sfc/base: fix failure path in EF10 Tx queue PIO enable Andrew Rybchenko
2017-04-04 12:13 ` [PATCH 2/3] net/sfc/base: fix potential buffer overflow in Tx queue init Andrew Rybchenko
@ 2017-04-04 12:13 ` Andrew Rybchenko
2017-04-04 13:18 ` [dpdk-stable] [PATCH 1/3] net/sfc/base: fix failure path in EF10 Tx queue PIO enable Ferruh Yigit
2 siblings, 0 replies; 4+ messages in thread
From: Andrew Rybchenko @ 2017-04-04 12:13 UTC (permalink / raw)
To: dev; +Cc: Andy Moreton, stable
From: Andy Moreton <amoreton@solarflare.com>
Coverity issue: 1349662
Fixes: e7cd430c864f ("net/sfc/base: import SFN7xxx family support")
Cc: stable@dpdk.org
Signed-off-by: Andy Moreton <amoreton@solarflare.com>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
drivers/net/sfc/base/ef10_nic.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/sfc/base/ef10_nic.c b/drivers/net/sfc/base/ef10_nic.c
index 3a74320..aac2679 100644
--- a/drivers/net/sfc/base/ef10_nic.c
+++ b/drivers/net/sfc/base/ef10_nic.c
@@ -501,7 +501,7 @@ efx_mcdi_alloc_vis(
{
efx_mcdi_req_t req;
uint8_t payload[MAX(MC_CMD_ALLOC_VIS_IN_LEN,
- MC_CMD_ALLOC_VIS_OUT_LEN)];
+ MC_CMD_ALLOC_VIS_EXT_OUT_LEN)];
efx_rc_t rc;
if (vi_countp == NULL) {
@@ -514,7 +514,7 @@ efx_mcdi_alloc_vis(
req.emr_in_buf = payload;
req.emr_in_length = MC_CMD_ALLOC_VIS_IN_LEN;
req.emr_out_buf = payload;
- req.emr_out_length = MC_CMD_ALLOC_VIS_OUT_LEN;
+ req.emr_out_length = MC_CMD_ALLOC_VIS_EXT_OUT_LEN;
MCDI_IN_SET_DWORD(req, ALLOC_VIS_IN_MIN_VI_COUNT, min_vi_count);
MCDI_IN_SET_DWORD(req, ALLOC_VIS_IN_MAX_VI_COUNT, max_vi_count);
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [dpdk-stable] [PATCH 1/3] net/sfc/base: fix failure path in EF10 Tx queue PIO enable
2017-04-04 12:13 [PATCH 1/3] net/sfc/base: fix failure path in EF10 Tx queue PIO enable Andrew Rybchenko
2017-04-04 12:13 ` [PATCH 2/3] net/sfc/base: fix potential buffer overflow in Tx queue init Andrew Rybchenko
2017-04-04 12:13 ` [PATCH 3/3] net/sfc/base: fix out of bounds read in VIs allocation Andrew Rybchenko
@ 2017-04-04 13:18 ` Ferruh Yigit
2 siblings, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2017-04-04 13:18 UTC (permalink / raw)
To: Andrew Rybchenko, dev; +Cc: Andy Moreton, stable
On 4/4/2017 1:13 PM, Andrew Rybchenko wrote:
> From: Andy Moreton <amoreton@solarflare.com>
>
> Coverity issue: 1387551
> Fixes: e7cd430c864f ("net/sfc/base: import SFN7xxx family support")
> Cc: stable@dpdk.org
>
> Signed-off-by: Andy Moreton <amoreton@solarflare.com>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
Series applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-04-04 13:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-04 12:13 [PATCH 1/3] net/sfc/base: fix failure path in EF10 Tx queue PIO enable Andrew Rybchenko
2017-04-04 12:13 ` [PATCH 2/3] net/sfc/base: fix potential buffer overflow in Tx queue init Andrew Rybchenko
2017-04-04 12:13 ` [PATCH 3/3] net/sfc/base: fix out of bounds read in VIs allocation Andrew Rybchenko
2017-04-04 13:18 ` [dpdk-stable] [PATCH 1/3] net/sfc/base: fix failure path in EF10 Tx queue PIO enable Ferruh Yigit
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.