* Re: [Cocci] [PATCH] scripts: add dummy report mode to add_namespace.cocci
@ 2020-06-22 8:03 ` Matthias Maennich
0 siblings, 0 replies; 22+ messages in thread
From: Matthias Maennich @ 2020-06-22 8:03 UTC (permalink / raw)
To: Shuah Khan
Cc: Greg Kroah-Hartman, YueHaibing, linux-kernel, stable, jeyu,
kernel-team, cocci
On Thu, Jun 04, 2020 at 02:39:18PM -0600, Shuah Khan wrote:
>On 6/4/20 1:31 PM, Julia Lawall wrote:
>>
>>
>>On Thu, 4 Jun 2020, Matthias Maennich wrote:
>>
>>>When running `make coccicheck` in report mode using the
>>>add_namespace.cocci file, it will fail for files that contain
>>>MODULE_LICENSE. Those match the replacement precondition, but spatch
>>>errors out as virtual.ns is not set.
>>>
>>>In order to fix that, add the virtual rule nsdeps and only do search and
>>>replace if that rule has been explicitly requested.
>>>
>>>In order to make spatch happy in report mode, we also need a dummy rule,
>>>as otherwise it errors out with "No rules apply". Using a script:python
>>>rule appears unrelated and odd, but this is the shortest I could come up
>>>with.
>>>
>>>Adjust scripts/nsdeps accordingly to set the nsdeps rule when run trough
>>>`make nsdeps`.
>>>
>>>Suggested-by: Julia Lawall <julia.lawall@inria.fr>
>>>Fixes: c7c4e29fb5a4 ("scripts: add_namespace: Fix coccicheck failed")
>>>Cc: YueHaibing <yuehaibing@huawei.com>
>>>Cc: jeyu@kernel.org
>>>Cc: cocci@systeme.lip6.fr
>>>Cc: stable@vger.kernel.org
>>>Signed-off-by: Matthias Maennich <maennich@google.com>
>>
>>Acked-by: Julia Lawall <julia.lawall@inria.fr>
>>
>>Shuah reported the problem to me, so you could add
>>
>>Reported-by: Shuah Khan <skhan@linuxfoundation.org>
>>
>
>Very cool. No errors with this patch. Thanks for fixing it
>quickly.
I am happy I could fix that and thanks for confirming. I assume your
Tested-by could be added?
Is somebody willing to take this patch through their tree?
Cheers,
Matthias
>
>thanks,
>-- Shuah
>
>
>
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH] scripts: add dummy report mode to add_namespace.cocci
2020-06-22 8:03 ` [Cocci] " Matthias Maennich
@ 2020-06-22 8:59 ` Julia Lawall
-1 siblings, 0 replies; 22+ messages in thread
From: Julia Lawall @ 2020-06-22 8:59 UTC (permalink / raw)
To: Matthias Maennich
Cc: Shuah Khan, linux-kernel, kernel-team, YueHaibing, jeyu, cocci,
stable, Greg Kroah-Hartman
On Mon, 22 Jun 2020, Matthias Maennich wrote:
> On Thu, Jun 04, 2020 at 02:39:18PM -0600, Shuah Khan wrote:
> > On 6/4/20 1:31 PM, Julia Lawall wrote:
> > >
> > >
> > > On Thu, 4 Jun 2020, Matthias Maennich wrote:
> > >
> > > > When running `make coccicheck` in report mode using the
> > > > add_namespace.cocci file, it will fail for files that contain
> > > > MODULE_LICENSE. Those match the replacement precondition, but spatch
> > > > errors out as virtual.ns is not set.
> > > >
> > > > In order to fix that, add the virtual rule nsdeps and only do search and
> > > > replace if that rule has been explicitly requested.
> > > >
> > > > In order to make spatch happy in report mode, we also need a dummy rule,
> > > > as otherwise it errors out with "No rules apply". Using a script:python
> > > > rule appears unrelated and odd, but this is the shortest I could come up
> > > > with.
> > > >
> > > > Adjust scripts/nsdeps accordingly to set the nsdeps rule when run trough
> > > > `make nsdeps`.
> > > >
> > > > Suggested-by: Julia Lawall <julia.lawall@inria.fr>
> > > > Fixes: c7c4e29fb5a4 ("scripts: add_namespace: Fix coccicheck failed")
> > > > Cc: YueHaibing <yuehaibing@huawei.com>
> > > > Cc: jeyu@kernel.org
> > > > Cc: cocci@systeme.lip6.fr
> > > > Cc: stable@vger.kernel.org
> > > > Signed-off-by: Matthias Maennich <maennich@google.com>
> > >
> > > Acked-by: Julia Lawall <julia.lawall@inria.fr>
> > >
> > > Shuah reported the problem to me, so you could add
> > >
> > > Reported-by: Shuah Khan <skhan@linuxfoundation.org>
> > >
> >
> > Very cool. No errors with this patch. Thanks for fixing it
> > quickly.
>
> I am happy I could fix that and thanks for confirming. I assume your
> Tested-by could be added?
Yes, that would be fine.
julia
>
> Is somebody willing to take this patch through their tree?
>
> Cheers,
> Matthias
>
> >
> > thanks,
> > -- Shuah
> >
> >
> >
>
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [Cocci] [PATCH] scripts: add dummy report mode to add_namespace.cocci
@ 2020-06-22 8:59 ` Julia Lawall
0 siblings, 0 replies; 22+ messages in thread
From: Julia Lawall @ 2020-06-22 8:59 UTC (permalink / raw)
To: Matthias Maennich
Cc: Greg Kroah-Hartman, Shuah Khan, YueHaibing, linux-kernel, stable,
jeyu, kernel-team, cocci
On Mon, 22 Jun 2020, Matthias Maennich wrote:
> On Thu, Jun 04, 2020 at 02:39:18PM -0600, Shuah Khan wrote:
> > On 6/4/20 1:31 PM, Julia Lawall wrote:
> > >
> > >
> > > On Thu, 4 Jun 2020, Matthias Maennich wrote:
> > >
> > > > When running `make coccicheck` in report mode using the
> > > > add_namespace.cocci file, it will fail for files that contain
> > > > MODULE_LICENSE. Those match the replacement precondition, but spatch
> > > > errors out as virtual.ns is not set.
> > > >
> > > > In order to fix that, add the virtual rule nsdeps and only do search and
> > > > replace if that rule has been explicitly requested.
> > > >
> > > > In order to make spatch happy in report mode, we also need a dummy rule,
> > > > as otherwise it errors out with "No rules apply". Using a script:python
> > > > rule appears unrelated and odd, but this is the shortest I could come up
> > > > with.
> > > >
> > > > Adjust scripts/nsdeps accordingly to set the nsdeps rule when run trough
> > > > `make nsdeps`.
> > > >
> > > > Suggested-by: Julia Lawall <julia.lawall@inria.fr>
> > > > Fixes: c7c4e29fb5a4 ("scripts: add_namespace: Fix coccicheck failed")
> > > > Cc: YueHaibing <yuehaibing@huawei.com>
> > > > Cc: jeyu@kernel.org
> > > > Cc: cocci@systeme.lip6.fr
> > > > Cc: stable@vger.kernel.org
> > > > Signed-off-by: Matthias Maennich <maennich@google.com>
> > >
> > > Acked-by: Julia Lawall <julia.lawall@inria.fr>
> > >
> > > Shuah reported the problem to me, so you could add
> > >
> > > Reported-by: Shuah Khan <skhan@linuxfoundation.org>
> > >
> >
> > Very cool. No errors with this patch. Thanks for fixing it
> > quickly.
>
> I am happy I could fix that and thanks for confirming. I assume your
> Tested-by could be added?
Yes, that would be fine.
julia
>
> Is somebody willing to take this patch through their tree?
>
> Cheers,
> Matthias
>
> >
> > thanks,
> > -- Shuah
> >
> >
> >
>
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH] scripts: add dummy report mode to add_namespace.cocci
2020-06-22 8:03 ` [Cocci] " Matthias Maennich
@ 2020-06-22 14:46 ` Shuah Khan
-1 siblings, 0 replies; 22+ messages in thread
From: Shuah Khan @ 2020-06-22 14:46 UTC (permalink / raw)
To: Matthias Maennich, Julia Lawall
Cc: linux-kernel, kernel-team, YueHaibing, jeyu, cocci, stable,
Greg Kroah-Hartman, Shuah Khan
On 6/22/20 2:03 AM, Matthias Maennich wrote:
> On Thu, Jun 04, 2020 at 02:39:18PM -0600, Shuah Khan wrote:
>> On 6/4/20 1:31 PM, Julia Lawall wrote:
>>>
>>>
>>> On Thu, 4 Jun 2020, Matthias Maennich wrote:
>>>
>>>> When running `make coccicheck` in report mode using the
>>>> add_namespace.cocci file, it will fail for files that contain
>>>> MODULE_LICENSE. Those match the replacement precondition, but spatch
>>>> errors out as virtual.ns is not set.
>>>>
>>>> In order to fix that, add the virtual rule nsdeps and only do search
>>>> and
>>>> replace if that rule has been explicitly requested.
>>>>
>>>> In order to make spatch happy in report mode, we also need a dummy
>>>> rule,
>>>> as otherwise it errors out with "No rules apply". Using a script:python
>>>> rule appears unrelated and odd, but this is the shortest I could
>>>> come up
>>>> with.
>>>>
>>>> Adjust scripts/nsdeps accordingly to set the nsdeps rule when run
>>>> trough
>>>> `make nsdeps`.
>>>>
>>>> Suggested-by: Julia Lawall <julia.lawall@inria.fr>
>>>> Fixes: c7c4e29fb5a4 ("scripts: add_namespace: Fix coccicheck failed")
>>>> Cc: YueHaibing <yuehaibing@huawei.com>
>>>> Cc: jeyu@kernel.org
>>>> Cc: cocci@systeme.lip6.fr
>>>> Cc: stable@vger.kernel.org
>>>> Signed-off-by: Matthias Maennich <maennich@google.com>
>>>
>>> Acked-by: Julia Lawall <julia.lawall@inria.fr>
>>>
>>> Shuah reported the problem to me, so you could add
>>>
>>> Reported-by: Shuah Khan <skhan@linuxfoundation.org>
>>>
>>
>> Very cool. No errors with this patch. Thanks for fixing it
>> quickly.
>
> I am happy I could fix that and thanks for confirming. I assume your
> Tested-by could be added?
Yes
Tested-by: Shuah Khan <skhan@linuxfoundation.org>
>
> Is somebody willing to take this patch through their tree?
>
My guess is that these go through kbuild git??
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [Cocci] [PATCH] scripts: add dummy report mode to add_namespace.cocci
@ 2020-06-22 14:46 ` Shuah Khan
0 siblings, 0 replies; 22+ messages in thread
From: Shuah Khan @ 2020-06-22 14:46 UTC (permalink / raw)
To: Matthias Maennich, Julia Lawall
Cc: Greg Kroah-Hartman, Shuah Khan, YueHaibing, linux-kernel, stable,
jeyu, kernel-team, cocci
On 6/22/20 2:03 AM, Matthias Maennich wrote:
> On Thu, Jun 04, 2020 at 02:39:18PM -0600, Shuah Khan wrote:
>> On 6/4/20 1:31 PM, Julia Lawall wrote:
>>>
>>>
>>> On Thu, 4 Jun 2020, Matthias Maennich wrote:
>>>
>>>> When running `make coccicheck` in report mode using the
>>>> add_namespace.cocci file, it will fail for files that contain
>>>> MODULE_LICENSE. Those match the replacement precondition, but spatch
>>>> errors out as virtual.ns is not set.
>>>>
>>>> In order to fix that, add the virtual rule nsdeps and only do search
>>>> and
>>>> replace if that rule has been explicitly requested.
>>>>
>>>> In order to make spatch happy in report mode, we also need a dummy
>>>> rule,
>>>> as otherwise it errors out with "No rules apply". Using a script:python
>>>> rule appears unrelated and odd, but this is the shortest I could
>>>> come up
>>>> with.
>>>>
>>>> Adjust scripts/nsdeps accordingly to set the nsdeps rule when run
>>>> trough
>>>> `make nsdeps`.
>>>>
>>>> Suggested-by: Julia Lawall <julia.lawall@inria.fr>
>>>> Fixes: c7c4e29fb5a4 ("scripts: add_namespace: Fix coccicheck failed")
>>>> Cc: YueHaibing <yuehaibing@huawei.com>
>>>> Cc: jeyu@kernel.org
>>>> Cc: cocci@systeme.lip6.fr
>>>> Cc: stable@vger.kernel.org
>>>> Signed-off-by: Matthias Maennich <maennich@google.com>
>>>
>>> Acked-by: Julia Lawall <julia.lawall@inria.fr>
>>>
>>> Shuah reported the problem to me, so you could add
>>>
>>> Reported-by: Shuah Khan <skhan@linuxfoundation.org>
>>>
>>
>> Very cool. No errors with this patch. Thanks for fixing it
>> quickly.
>
> I am happy I could fix that and thanks for confirming. I assume your
> Tested-by could be added?
Yes
Tested-by: Shuah Khan <skhan@linuxfoundation.org>
>
> Is somebody willing to take this patch through their tree?
>
My guess is that these go through kbuild git??
thanks,
-- Shuah
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH] scripts: add dummy report mode to add_namespace.cocci
2020-06-22 14:46 ` [Cocci] " Shuah Khan
@ 2020-06-22 15:06 ` Greg Kroah-Hartman
-1 siblings, 0 replies; 22+ messages in thread
From: Greg Kroah-Hartman @ 2020-06-22 15:06 UTC (permalink / raw)
To: Shuah Khan
Cc: Matthias Maennich, Julia Lawall, linux-kernel, kernel-team,
YueHaibing, jeyu, cocci, stable
On Mon, Jun 22, 2020 at 08:46:18AM -0600, Shuah Khan wrote:
> On 6/22/20 2:03 AM, Matthias Maennich wrote:
> > On Thu, Jun 04, 2020 at 02:39:18PM -0600, Shuah Khan wrote:
> > > On 6/4/20 1:31 PM, Julia Lawall wrote:
> > > >
> > > >
> > > > On Thu, 4 Jun 2020, Matthias Maennich wrote:
> > > >
> > > > > When running `make coccicheck` in report mode using the
> > > > > add_namespace.cocci file, it will fail for files that contain
> > > > > MODULE_LICENSE. Those match the replacement precondition, but spatch
> > > > > errors out as virtual.ns is not set.
> > > > >
> > > > > In order to fix that, add the virtual rule nsdeps and only
> > > > > do search and
> > > > > replace if that rule has been explicitly requested.
> > > > >
> > > > > In order to make spatch happy in report mode, we also need a
> > > > > dummy rule,
> > > > > as otherwise it errors out with "No rules apply". Using a script:python
> > > > > rule appears unrelated and odd, but this is the shortest I
> > > > > could come up
> > > > > with.
> > > > >
> > > > > Adjust scripts/nsdeps accordingly to set the nsdeps rule
> > > > > when run trough
> > > > > `make nsdeps`.
> > > > >
> > > > > Suggested-by: Julia Lawall <julia.lawall@inria.fr>
> > > > > Fixes: c7c4e29fb5a4 ("scripts: add_namespace: Fix coccicheck failed")
> > > > > Cc: YueHaibing <yuehaibing@huawei.com>
> > > > > Cc: jeyu@kernel.org
> > > > > Cc: cocci@systeme.lip6.fr
> > > > > Cc: stable@vger.kernel.org
> > > > > Signed-off-by: Matthias Maennich <maennich@google.com>
> > > >
> > > > Acked-by: Julia Lawall <julia.lawall@inria.fr>
> > > >
> > > > Shuah reported the problem to me, so you could add
> > > >
> > > > Reported-by: Shuah Khan <skhan@linuxfoundation.org>
> > > >
> > >
> > > Very cool. No errors with this patch. Thanks for fixing it
> > > quickly.
> >
> > I am happy I could fix that and thanks for confirming. I assume your
> > Tested-by could be added?
>
> Yes
>
> Tested-by: Shuah Khan <skhan@linuxfoundation.org>
> >
> > Is somebody willing to take this patch through their tree?
> >
>
> My guess is that these go through kbuild git??
If you want to take this, that's fine with me. But as I had the
original file come through my tree, I can take it too. It's up to you,
either is ok with me.
thanks
greg k-h
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [Cocci] [PATCH] scripts: add dummy report mode to add_namespace.cocci
@ 2020-06-22 15:06 ` Greg Kroah-Hartman
0 siblings, 0 replies; 22+ messages in thread
From: Greg Kroah-Hartman @ 2020-06-22 15:06 UTC (permalink / raw)
To: Shuah Khan
Cc: Matthias Maennich, YueHaibing, linux-kernel, stable, jeyu,
kernel-team, cocci
On Mon, Jun 22, 2020 at 08:46:18AM -0600, Shuah Khan wrote:
> On 6/22/20 2:03 AM, Matthias Maennich wrote:
> > On Thu, Jun 04, 2020 at 02:39:18PM -0600, Shuah Khan wrote:
> > > On 6/4/20 1:31 PM, Julia Lawall wrote:
> > > >
> > > >
> > > > On Thu, 4 Jun 2020, Matthias Maennich wrote:
> > > >
> > > > > When running `make coccicheck` in report mode using the
> > > > > add_namespace.cocci file, it will fail for files that contain
> > > > > MODULE_LICENSE. Those match the replacement precondition, but spatch
> > > > > errors out as virtual.ns is not set.
> > > > >
> > > > > In order to fix that, add the virtual rule nsdeps and only
> > > > > do search and
> > > > > replace if that rule has been explicitly requested.
> > > > >
> > > > > In order to make spatch happy in report mode, we also need a
> > > > > dummy rule,
> > > > > as otherwise it errors out with "No rules apply". Using a script:python
> > > > > rule appears unrelated and odd, but this is the shortest I
> > > > > could come up
> > > > > with.
> > > > >
> > > > > Adjust scripts/nsdeps accordingly to set the nsdeps rule
> > > > > when run trough
> > > > > `make nsdeps`.
> > > > >
> > > > > Suggested-by: Julia Lawall <julia.lawall@inria.fr>
> > > > > Fixes: c7c4e29fb5a4 ("scripts: add_namespace: Fix coccicheck failed")
> > > > > Cc: YueHaibing <yuehaibing@huawei.com>
> > > > > Cc: jeyu@kernel.org
> > > > > Cc: cocci@systeme.lip6.fr
> > > > > Cc: stable@vger.kernel.org
> > > > > Signed-off-by: Matthias Maennich <maennich@google.com>
> > > >
> > > > Acked-by: Julia Lawall <julia.lawall@inria.fr>
> > > >
> > > > Shuah reported the problem to me, so you could add
> > > >
> > > > Reported-by: Shuah Khan <skhan@linuxfoundation.org>
> > > >
> > >
> > > Very cool. No errors with this patch. Thanks for fixing it
> > > quickly.
> >
> > I am happy I could fix that and thanks for confirming. I assume your
> > Tested-by could be added?
>
> Yes
>
> Tested-by: Shuah Khan <skhan@linuxfoundation.org>
> >
> > Is somebody willing to take this patch through their tree?
> >
>
> My guess is that these go through kbuild git??
If you want to take this, that's fine with me. But as I had the
original file come through my tree, I can take it too. It's up to you,
either is ok with me.
thanks
greg k-h
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH] scripts: add dummy report mode to add_namespace.cocci
2020-06-22 15:06 ` [Cocci] " Greg Kroah-Hartman
@ 2020-06-22 16:14 ` Shuah Khan
-1 siblings, 0 replies; 22+ messages in thread
From: Shuah Khan @ 2020-06-22 16:14 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Matthias Maennich, Julia Lawall, linux-kernel, kernel-team,
YueHaibing, jeyu, cocci, stable, skhan
On 6/22/20 9:06 AM, Greg Kroah-Hartman wrote:
> On Mon, Jun 22, 2020 at 08:46:18AM -0600, Shuah Khan wrote:
>> On 6/22/20 2:03 AM, Matthias Maennich wrote:
>>> On Thu, Jun 04, 2020 at 02:39:18PM -0600, Shuah Khan wrote:
>>>> On 6/4/20 1:31 PM, Julia Lawall wrote:
>>>>>
>>>>>
>>>>> On Thu, 4 Jun 2020, Matthias Maennich wrote:
>>>>>
>>>>>> When running `make coccicheck` in report mode using the
>>>>>> add_namespace.cocci file, it will fail for files that contain
>>>>>> MODULE_LICENSE. Those match the replacement precondition, but spatch
>>>>>> errors out as virtual.ns is not set.
>>>>>>
>>>>>> In order to fix that, add the virtual rule nsdeps and only
>>>>>> do search and
>>>>>> replace if that rule has been explicitly requested.
>>>>>>
>>>>>> In order to make spatch happy in report mode, we also need a
>>>>>> dummy rule,
>>>>>> as otherwise it errors out with "No rules apply". Using a script:python
>>>>>> rule appears unrelated and odd, but this is the shortest I
>>>>>> could come up
>>>>>> with.
>>>>>>
>>>>>> Adjust scripts/nsdeps accordingly to set the nsdeps rule
>>>>>> when run trough
>>>>>> `make nsdeps`.
>>>>>>
>>>>>> Suggested-by: Julia Lawall <julia.lawall@inria.fr>
>>>>>> Fixes: c7c4e29fb5a4 ("scripts: add_namespace: Fix coccicheck failed")
>>>>>> Cc: YueHaibing <yuehaibing@huawei.com>
>>>>>> Cc: jeyu@kernel.org
>>>>>> Cc: cocci@systeme.lip6.fr
>>>>>> Cc: stable@vger.kernel.org
>>>>>> Signed-off-by: Matthias Maennich <maennich@google.com>
>>>>>
>>>>> Acked-by: Julia Lawall <julia.lawall@inria.fr>
>>>>>
>>>>> Shuah reported the problem to me, so you could add
>>>>>
>>>>> Reported-by: Shuah Khan <skhan@linuxfoundation.org>
>>>>>
>>>>
>>>> Very cool. No errors with this patch. Thanks for fixing it
>>>> quickly.
>>>
>>> I am happy I could fix that and thanks for confirming. I assume your
>>> Tested-by could be added?
>>
>> Yes
>>
>> Tested-by: Shuah Khan <skhan@linuxfoundation.org>
>>>
>>> Is somebody willing to take this patch through their tree?
>>>
>>
>> My guess is that these go through kbuild git??
>
> If you want to take this, that's fine with me. But as I had the
> original file come through my tree, I can take it too. It's up to you,
> either is ok with me.
>
Great. Please take this through your tree.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [Cocci] [PATCH] scripts: add dummy report mode to add_namespace.cocci
@ 2020-06-22 16:14 ` Shuah Khan
0 siblings, 0 replies; 22+ messages in thread
From: Shuah Khan @ 2020-06-22 16:14 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Matthias Maennich, skhan, YueHaibing, linux-kernel, stable, jeyu,
kernel-team, cocci
On 6/22/20 9:06 AM, Greg Kroah-Hartman wrote:
> On Mon, Jun 22, 2020 at 08:46:18AM -0600, Shuah Khan wrote:
>> On 6/22/20 2:03 AM, Matthias Maennich wrote:
>>> On Thu, Jun 04, 2020 at 02:39:18PM -0600, Shuah Khan wrote:
>>>> On 6/4/20 1:31 PM, Julia Lawall wrote:
>>>>>
>>>>>
>>>>> On Thu, 4 Jun 2020, Matthias Maennich wrote:
>>>>>
>>>>>> When running `make coccicheck` in report mode using the
>>>>>> add_namespace.cocci file, it will fail for files that contain
>>>>>> MODULE_LICENSE. Those match the replacement precondition, but spatch
>>>>>> errors out as virtual.ns is not set.
>>>>>>
>>>>>> In order to fix that, add the virtual rule nsdeps and only
>>>>>> do search and
>>>>>> replace if that rule has been explicitly requested.
>>>>>>
>>>>>> In order to make spatch happy in report mode, we also need a
>>>>>> dummy rule,
>>>>>> as otherwise it errors out with "No rules apply". Using a script:python
>>>>>> rule appears unrelated and odd, but this is the shortest I
>>>>>> could come up
>>>>>> with.
>>>>>>
>>>>>> Adjust scripts/nsdeps accordingly to set the nsdeps rule
>>>>>> when run trough
>>>>>> `make nsdeps`.
>>>>>>
>>>>>> Suggested-by: Julia Lawall <julia.lawall@inria.fr>
>>>>>> Fixes: c7c4e29fb5a4 ("scripts: add_namespace: Fix coccicheck failed")
>>>>>> Cc: YueHaibing <yuehaibing@huawei.com>
>>>>>> Cc: jeyu@kernel.org
>>>>>> Cc: cocci@systeme.lip6.fr
>>>>>> Cc: stable@vger.kernel.org
>>>>>> Signed-off-by: Matthias Maennich <maennich@google.com>
>>>>>
>>>>> Acked-by: Julia Lawall <julia.lawall@inria.fr>
>>>>>
>>>>> Shuah reported the problem to me, so you could add
>>>>>
>>>>> Reported-by: Shuah Khan <skhan@linuxfoundation.org>
>>>>>
>>>>
>>>> Very cool. No errors with this patch. Thanks for fixing it
>>>> quickly.
>>>
>>> I am happy I could fix that and thanks for confirming. I assume your
>>> Tested-by could be added?
>>
>> Yes
>>
>> Tested-by: Shuah Khan <skhan@linuxfoundation.org>
>>>
>>> Is somebody willing to take this patch through their tree?
>>>
>>
>> My guess is that these go through kbuild git??
>
> If you want to take this, that's fine with me. But as I had the
> original file come through my tree, I can take it too. It's up to you,
> either is ok with me.
>
Great. Please take this through your tree.
thanks,
-- Shuah
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH] scripts: add dummy report mode to add_namespace.cocci
2020-06-22 16:14 ` [Cocci] " Shuah Khan
@ 2020-08-06 19:48 ` Shuah Khan
-1 siblings, 0 replies; 22+ messages in thread
From: Shuah Khan @ 2020-08-06 19:48 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Matthias Maennich, Julia Lawall, linux-kernel, kernel-team,
YueHaibing, jeyu, cocci, stable, skhan
On 6/22/20 10:14 AM, Shuah Khan wrote:
> On 6/22/20 9:06 AM, Greg Kroah-Hartman wrote:
>> On Mon, Jun 22, 2020 at 08:46:18AM -0600, Shuah Khan wrote:
>>> On 6/22/20 2:03 AM, Matthias Maennich wrote:
>>>> On Thu, Jun 04, 2020 at 02:39:18PM -0600, Shuah Khan wrote:
>>>>> On 6/4/20 1:31 PM, Julia Lawall wrote:
>>>>>>
>>>>>>
>>>>>> On Thu, 4 Jun 2020, Matthias Maennich wrote:
>>>>>>
>>>>>>> When running `make coccicheck` in report mode using the
>>>>>>> add_namespace.cocci file, it will fail for files that contain
>>>>>>> MODULE_LICENSE. Those match the replacement precondition, but spatch
>>>>>>> errors out as virtual.ns is not set.
>>>>>>>
>>>>>>> In order to fix that, add the virtual rule nsdeps and only
>>>>>>> do search and
>>>>>>> replace if that rule has been explicitly requested.
>>>>>>>
>>>>>>> In order to make spatch happy in report mode, we also need a
>>>>>>> dummy rule,
>>>>>>> as otherwise it errors out with "No rules apply". Using a
>>>>>>> script:python
>>>>>>> rule appears unrelated and odd, but this is the shortest I
>>>>>>> could come up
>>>>>>> with.
>>>>>>>
>>>>>>> Adjust scripts/nsdeps accordingly to set the nsdeps rule
>>>>>>> when run trough
>>>>>>> `make nsdeps`.
>>>>>>>
>>>>>>> Suggested-by: Julia Lawall <julia.lawall@inria.fr>
>>>>>>> Fixes: c7c4e29fb5a4 ("scripts: add_namespace: Fix coccicheck
>>>>>>> failed")
>>>>>>> Cc: YueHaibing <yuehaibing@huawei.com>
>>>>>>> Cc: jeyu@kernel.org
>>>>>>> Cc: cocci@systeme.lip6.fr
>>>>>>> Cc: stable@vger.kernel.org
>>>>>>> Signed-off-by: Matthias Maennich <maennich@google.com>
>>>>>>
>>>>>> Acked-by: Julia Lawall <julia.lawall@inria.fr>
>>>>>>
>>>>>> Shuah reported the problem to me, so you could add
>>>>>>
>>>>>> Reported-by: Shuah Khan <skhan@linuxfoundation.org>
>>>>>>
>>>>>
>>>>> Very cool. No errors with this patch. Thanks for fixing it
>>>>> quickly.
>>>>
>>>> I am happy I could fix that and thanks for confirming. I assume your
>>>> Tested-by could be added?
>>>
>>> Yes
>>>
>>> Tested-by: Shuah Khan <skhan@linuxfoundation.org>
>>>>
>>>> Is somebody willing to take this patch through their tree?
>>>>
>>>
>>> My guess is that these go through kbuild git??
>>
>> If you want to take this, that's fine with me. But as I had the
>> original file come through my tree, I can take it too. It's up to you,
>> either is ok with me.
>>
>
> Great. Please take this through your tree.
>
Greg! Looks like this one didn't make it in. Can you pick this up?
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [Cocci] [PATCH] scripts: add dummy report mode to add_namespace.cocci
@ 2020-08-06 19:48 ` Shuah Khan
0 siblings, 0 replies; 22+ messages in thread
From: Shuah Khan @ 2020-08-06 19:48 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Matthias Maennich, skhan, YueHaibing, linux-kernel, stable, jeyu,
kernel-team, cocci
On 6/22/20 10:14 AM, Shuah Khan wrote:
> On 6/22/20 9:06 AM, Greg Kroah-Hartman wrote:
>> On Mon, Jun 22, 2020 at 08:46:18AM -0600, Shuah Khan wrote:
>>> On 6/22/20 2:03 AM, Matthias Maennich wrote:
>>>> On Thu, Jun 04, 2020 at 02:39:18PM -0600, Shuah Khan wrote:
>>>>> On 6/4/20 1:31 PM, Julia Lawall wrote:
>>>>>>
>>>>>>
>>>>>> On Thu, 4 Jun 2020, Matthias Maennich wrote:
>>>>>>
>>>>>>> When running `make coccicheck` in report mode using the
>>>>>>> add_namespace.cocci file, it will fail for files that contain
>>>>>>> MODULE_LICENSE. Those match the replacement precondition, but spatch
>>>>>>> errors out as virtual.ns is not set.
>>>>>>>
>>>>>>> In order to fix that, add the virtual rule nsdeps and only
>>>>>>> do search and
>>>>>>> replace if that rule has been explicitly requested.
>>>>>>>
>>>>>>> In order to make spatch happy in report mode, we also need a
>>>>>>> dummy rule,
>>>>>>> as otherwise it errors out with "No rules apply". Using a
>>>>>>> script:python
>>>>>>> rule appears unrelated and odd, but this is the shortest I
>>>>>>> could come up
>>>>>>> with.
>>>>>>>
>>>>>>> Adjust scripts/nsdeps accordingly to set the nsdeps rule
>>>>>>> when run trough
>>>>>>> `make nsdeps`.
>>>>>>>
>>>>>>> Suggested-by: Julia Lawall <julia.lawall@inria.fr>
>>>>>>> Fixes: c7c4e29fb5a4 ("scripts: add_namespace: Fix coccicheck
>>>>>>> failed")
>>>>>>> Cc: YueHaibing <yuehaibing@huawei.com>
>>>>>>> Cc: jeyu@kernel.org
>>>>>>> Cc: cocci@systeme.lip6.fr
>>>>>>> Cc: stable@vger.kernel.org
>>>>>>> Signed-off-by: Matthias Maennich <maennich@google.com>
>>>>>>
>>>>>> Acked-by: Julia Lawall <julia.lawall@inria.fr>
>>>>>>
>>>>>> Shuah reported the problem to me, so you could add
>>>>>>
>>>>>> Reported-by: Shuah Khan <skhan@linuxfoundation.org>
>>>>>>
>>>>>
>>>>> Very cool. No errors with this patch. Thanks for fixing it
>>>>> quickly.
>>>>
>>>> I am happy I could fix that and thanks for confirming. I assume your
>>>> Tested-by could be added?
>>>
>>> Yes
>>>
>>> Tested-by: Shuah Khan <skhan@linuxfoundation.org>
>>>>
>>>> Is somebody willing to take this patch through their tree?
>>>>
>>>
>>> My guess is that these go through kbuild git??
>>
>> If you want to take this, that's fine with me. But as I had the
>> original file come through my tree, I can take it too. It's up to you,
>> either is ok with me.
>>
>
> Great. Please take this through your tree.
>
Greg! Looks like this one didn't make it in. Can you pick this up?
thanks,
-- Shuah
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH] scripts: add dummy report mode to add_namespace.cocci
2020-08-06 19:48 ` [Cocci] " Shuah Khan
@ 2020-08-06 19:57 ` Greg Kroah-Hartman
-1 siblings, 0 replies; 22+ messages in thread
From: Greg Kroah-Hartman @ 2020-08-06 19:57 UTC (permalink / raw)
To: Shuah Khan
Cc: Matthias Maennich, Julia Lawall, linux-kernel, kernel-team,
YueHaibing, jeyu, cocci, stable
On Thu, Aug 06, 2020 at 01:48:26PM -0600, Shuah Khan wrote:
> On 6/22/20 10:14 AM, Shuah Khan wrote:
> > On 6/22/20 9:06 AM, Greg Kroah-Hartman wrote:
> > > On Mon, Jun 22, 2020 at 08:46:18AM -0600, Shuah Khan wrote:
> > > > On 6/22/20 2:03 AM, Matthias Maennich wrote:
> > > > > On Thu, Jun 04, 2020 at 02:39:18PM -0600, Shuah Khan wrote:
> > > > > > On 6/4/20 1:31 PM, Julia Lawall wrote:
> > > > > > >
> > > > > > >
> > > > > > > On Thu, 4 Jun 2020, Matthias Maennich wrote:
> > > > > > >
> > > > > > > > When running `make coccicheck` in report mode using the
> > > > > > > > add_namespace.cocci file, it will fail for files that contain
> > > > > > > > MODULE_LICENSE. Those match the replacement precondition, but spatch
> > > > > > > > errors out as virtual.ns is not set.
> > > > > > > >
> > > > > > > > In order to fix that, add the virtual rule nsdeps and only
> > > > > > > > do search and
> > > > > > > > replace if that rule has been explicitly requested.
> > > > > > > >
> > > > > > > > In order to make spatch happy in report mode, we also need a
> > > > > > > > dummy rule,
> > > > > > > > as otherwise it errors out with "No rules
> > > > > > > > apply". Using a script:python
> > > > > > > > rule appears unrelated and odd, but this is the shortest I
> > > > > > > > could come up
> > > > > > > > with.
> > > > > > > >
> > > > > > > > Adjust scripts/nsdeps accordingly to set the nsdeps rule
> > > > > > > > when run trough
> > > > > > > > `make nsdeps`.
> > > > > > > >
> > > > > > > > Suggested-by: Julia Lawall <julia.lawall@inria.fr>
> > > > > > > > Fixes: c7c4e29fb5a4 ("scripts: add_namespace:
> > > > > > > > Fix coccicheck failed")
> > > > > > > > Cc: YueHaibing <yuehaibing@huawei.com>
> > > > > > > > Cc: jeyu@kernel.org
> > > > > > > > Cc: cocci@systeme.lip6.fr
> > > > > > > > Cc: stable@vger.kernel.org
> > > > > > > > Signed-off-by: Matthias Maennich <maennich@google.com>
> > > > > > >
> > > > > > > Acked-by: Julia Lawall <julia.lawall@inria.fr>
> > > > > > >
> > > > > > > Shuah reported the problem to me, so you could add
> > > > > > >
> > > > > > > Reported-by: Shuah Khan <skhan@linuxfoundation.org>
> > > > > > >
> > > > > >
> > > > > > Very cool. No errors with this patch. Thanks for fixing it
> > > > > > quickly.
> > > > >
> > > > > I am happy I could fix that and thanks for confirming. I assume your
> > > > > Tested-by could be added?
> > > >
> > > > Yes
> > > >
> > > > Tested-by: Shuah Khan <skhan@linuxfoundation.org>
> > > > >
> > > > > Is somebody willing to take this patch through their tree?
> > > > >
> > > >
> > > > My guess is that these go through kbuild git??
> > >
> > > If you want to take this, that's fine with me. But as I had the
> > > original file come through my tree, I can take it too. It's up to you,
> > > either is ok with me.
> > >
> >
> > Great. Please take this through your tree.
> >
>
> Greg! Looks like this one didn't make it in. Can you pick this up?
I think this is 55c7549819e4 ("scripts: add dummy report mode to
add_namespace.cocci") in Linus's tree right now, right?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [Cocci] [PATCH] scripts: add dummy report mode to add_namespace.cocci
@ 2020-08-06 19:57 ` Greg Kroah-Hartman
0 siblings, 0 replies; 22+ messages in thread
From: Greg Kroah-Hartman @ 2020-08-06 19:57 UTC (permalink / raw)
To: Shuah Khan
Cc: Matthias Maennich, YueHaibing, linux-kernel, stable, jeyu,
kernel-team, cocci
On Thu, Aug 06, 2020 at 01:48:26PM -0600, Shuah Khan wrote:
> On 6/22/20 10:14 AM, Shuah Khan wrote:
> > On 6/22/20 9:06 AM, Greg Kroah-Hartman wrote:
> > > On Mon, Jun 22, 2020 at 08:46:18AM -0600, Shuah Khan wrote:
> > > > On 6/22/20 2:03 AM, Matthias Maennich wrote:
> > > > > On Thu, Jun 04, 2020 at 02:39:18PM -0600, Shuah Khan wrote:
> > > > > > On 6/4/20 1:31 PM, Julia Lawall wrote:
> > > > > > >
> > > > > > >
> > > > > > > On Thu, 4 Jun 2020, Matthias Maennich wrote:
> > > > > > >
> > > > > > > > When running `make coccicheck` in report mode using the
> > > > > > > > add_namespace.cocci file, it will fail for files that contain
> > > > > > > > MODULE_LICENSE. Those match the replacement precondition, but spatch
> > > > > > > > errors out as virtual.ns is not set.
> > > > > > > >
> > > > > > > > In order to fix that, add the virtual rule nsdeps and only
> > > > > > > > do search and
> > > > > > > > replace if that rule has been explicitly requested.
> > > > > > > >
> > > > > > > > In order to make spatch happy in report mode, we also need a
> > > > > > > > dummy rule,
> > > > > > > > as otherwise it errors out with "No rules
> > > > > > > > apply". Using a script:python
> > > > > > > > rule appears unrelated and odd, but this is the shortest I
> > > > > > > > could come up
> > > > > > > > with.
> > > > > > > >
> > > > > > > > Adjust scripts/nsdeps accordingly to set the nsdeps rule
> > > > > > > > when run trough
> > > > > > > > `make nsdeps`.
> > > > > > > >
> > > > > > > > Suggested-by: Julia Lawall <julia.lawall@inria.fr>
> > > > > > > > Fixes: c7c4e29fb5a4 ("scripts: add_namespace:
> > > > > > > > Fix coccicheck failed")
> > > > > > > > Cc: YueHaibing <yuehaibing@huawei.com>
> > > > > > > > Cc: jeyu@kernel.org
> > > > > > > > Cc: cocci@systeme.lip6.fr
> > > > > > > > Cc: stable@vger.kernel.org
> > > > > > > > Signed-off-by: Matthias Maennich <maennich@google.com>
> > > > > > >
> > > > > > > Acked-by: Julia Lawall <julia.lawall@inria.fr>
> > > > > > >
> > > > > > > Shuah reported the problem to me, so you could add
> > > > > > >
> > > > > > > Reported-by: Shuah Khan <skhan@linuxfoundation.org>
> > > > > > >
> > > > > >
> > > > > > Very cool. No errors with this patch. Thanks for fixing it
> > > > > > quickly.
> > > > >
> > > > > I am happy I could fix that and thanks for confirming. I assume your
> > > > > Tested-by could be added?
> > > >
> > > > Yes
> > > >
> > > > Tested-by: Shuah Khan <skhan@linuxfoundation.org>
> > > > >
> > > > > Is somebody willing to take this patch through their tree?
> > > > >
> > > >
> > > > My guess is that these go through kbuild git??
> > >
> > > If you want to take this, that's fine with me. But as I had the
> > > original file come through my tree, I can take it too. It's up to you,
> > > either is ok with me.
> > >
> >
> > Great. Please take this through your tree.
> >
>
> Greg! Looks like this one didn't make it in. Can you pick this up?
I think this is 55c7549819e4 ("scripts: add dummy report mode to
add_namespace.cocci") in Linus's tree right now, right?
thanks,
greg k-h
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH] scripts: add dummy report mode to add_namespace.cocci
2020-08-06 19:57 ` [Cocci] " Greg Kroah-Hartman
@ 2020-08-06 20:02 ` Shuah Khan
-1 siblings, 0 replies; 22+ messages in thread
From: Shuah Khan @ 2020-08-06 20:02 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Matthias Maennich, Julia Lawall, linux-kernel, kernel-team,
YueHaibing, jeyu, cocci, stable, Shuah Khan
On 8/6/20 1:57 PM, Greg Kroah-Hartman wrote:
> On Thu, Aug 06, 2020 at 01:48:26PM -0600, Shuah Khan wrote:
>> On 6/22/20 10:14 AM, Shuah Khan wrote:
>>> On 6/22/20 9:06 AM, Greg Kroah-Hartman wrote:
>>>> On Mon, Jun 22, 2020 at 08:46:18AM -0600, Shuah Khan wrote:
>>>>> On 6/22/20 2:03 AM, Matthias Maennich wrote:
>>>>>> On Thu, Jun 04, 2020 at 02:39:18PM -0600, Shuah Khan wrote:
>>>>>>> On 6/4/20 1:31 PM, Julia Lawall wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>> On Thu, 4 Jun 2020, Matthias Maennich wrote:
>>>>>>>>
>>>>>>>>> When running `make coccicheck` in report mode using the
>>>>>>>>> add_namespace.cocci file, it will fail for files that contain
>>>>>>>>> MODULE_LICENSE. Those match the replacement precondition, but spatch
>>>>>>>>> errors out as virtual.ns is not set.
>>>>>>>>>
>>>>>>>>> In order to fix that, add the virtual rule nsdeps and only
>>>>>>>>> do search and
>>>>>>>>> replace if that rule has been explicitly requested.
>>>>>>>>>
>>>>>>>>> In order to make spatch happy in report mode, we also need a
>>>>>>>>> dummy rule,
>>>>>>>>> as otherwise it errors out with "No rules
>>>>>>>>> apply". Using a script:python
>>>>>>>>> rule appears unrelated and odd, but this is the shortest I
>>>>>>>>> could come up
>>>>>>>>> with.
>>>>>>>>>
>>>>>>>>> Adjust scripts/nsdeps accordingly to set the nsdeps rule
>>>>>>>>> when run trough
>>>>>>>>> `make nsdeps`.
>>>>>>>>>
>>>>>>>>> Suggested-by: Julia Lawall <julia.lawall@inria.fr>
>>>>>>>>> Fixes: c7c4e29fb5a4 ("scripts: add_namespace:
>>>>>>>>> Fix coccicheck failed")
>>>>>>>>> Cc: YueHaibing <yuehaibing@huawei.com>
>>>>>>>>> Cc: jeyu@kernel.org
>>>>>>>>> Cc: cocci@systeme.lip6.fr
>>>>>>>>> Cc: stable@vger.kernel.org
>>>>>>>>> Signed-off-by: Matthias Maennich <maennich@google.com>
>>>>>>>>
>>>>>>>> Acked-by: Julia Lawall <julia.lawall@inria.fr>
>>>>>>>>
>>>>>>>> Shuah reported the problem to me, so you could add
>>>>>>>>
>>>>>>>> Reported-by: Shuah Khan <skhan@linuxfoundation.org>
>>>>>>>>
>>>>>>>
>>>>>>> Very cool. No errors with this patch. Thanks for fixing it
>>>>>>> quickly.
>>>>>>
>>>>>> I am happy I could fix that and thanks for confirming. I assume your
>>>>>> Tested-by could be added?
>>>>>
>>>>> Yes
>>>>>
>>>>> Tested-by: Shuah Khan <skhan@linuxfoundation.org>
>>>>>>
>>>>>> Is somebody willing to take this patch through their tree?
>>>>>>
>>>>>
>>>>> My guess is that these go through kbuild git??
>>>>
>>>> If you want to take this, that's fine with me. But as I had the
>>>> original file come through my tree, I can take it too. It's up to you,
>>>> either is ok with me.
>>>>
>>>
>>> Great. Please take this through your tree.
>>>
>>
>> Greg! Looks like this one didn't make it in. Can you pick this up?
>
> I think this is 55c7549819e4 ("scripts: add dummy report mode to
> add_namespace.cocci") in Linus's tree right now, right?
>
Yes. It is in Linux 5.9. I was looking in the wrong place on
Linux 5.8. :(
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [Cocci] [PATCH] scripts: add dummy report mode to add_namespace.cocci
@ 2020-08-06 20:02 ` Shuah Khan
0 siblings, 0 replies; 22+ messages in thread
From: Shuah Khan @ 2020-08-06 20:02 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Matthias Maennich, Shuah Khan, YueHaibing, linux-kernel, stable,
jeyu, kernel-team, cocci
On 8/6/20 1:57 PM, Greg Kroah-Hartman wrote:
> On Thu, Aug 06, 2020 at 01:48:26PM -0600, Shuah Khan wrote:
>> On 6/22/20 10:14 AM, Shuah Khan wrote:
>>> On 6/22/20 9:06 AM, Greg Kroah-Hartman wrote:
>>>> On Mon, Jun 22, 2020 at 08:46:18AM -0600, Shuah Khan wrote:
>>>>> On 6/22/20 2:03 AM, Matthias Maennich wrote:
>>>>>> On Thu, Jun 04, 2020 at 02:39:18PM -0600, Shuah Khan wrote:
>>>>>>> On 6/4/20 1:31 PM, Julia Lawall wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>> On Thu, 4 Jun 2020, Matthias Maennich wrote:
>>>>>>>>
>>>>>>>>> When running `make coccicheck` in report mode using the
>>>>>>>>> add_namespace.cocci file, it will fail for files that contain
>>>>>>>>> MODULE_LICENSE. Those match the replacement precondition, but spatch
>>>>>>>>> errors out as virtual.ns is not set.
>>>>>>>>>
>>>>>>>>> In order to fix that, add the virtual rule nsdeps and only
>>>>>>>>> do search and
>>>>>>>>> replace if that rule has been explicitly requested.
>>>>>>>>>
>>>>>>>>> In order to make spatch happy in report mode, we also need a
>>>>>>>>> dummy rule,
>>>>>>>>> as otherwise it errors out with "No rules
>>>>>>>>> apply". Using a script:python
>>>>>>>>> rule appears unrelated and odd, but this is the shortest I
>>>>>>>>> could come up
>>>>>>>>> with.
>>>>>>>>>
>>>>>>>>> Adjust scripts/nsdeps accordingly to set the nsdeps rule
>>>>>>>>> when run trough
>>>>>>>>> `make nsdeps`.
>>>>>>>>>
>>>>>>>>> Suggested-by: Julia Lawall <julia.lawall@inria.fr>
>>>>>>>>> Fixes: c7c4e29fb5a4 ("scripts: add_namespace:
>>>>>>>>> Fix coccicheck failed")
>>>>>>>>> Cc: YueHaibing <yuehaibing@huawei.com>
>>>>>>>>> Cc: jeyu@kernel.org
>>>>>>>>> Cc: cocci@systeme.lip6.fr
>>>>>>>>> Cc: stable@vger.kernel.org
>>>>>>>>> Signed-off-by: Matthias Maennich <maennich@google.com>
>>>>>>>>
>>>>>>>> Acked-by: Julia Lawall <julia.lawall@inria.fr>
>>>>>>>>
>>>>>>>> Shuah reported the problem to me, so you could add
>>>>>>>>
>>>>>>>> Reported-by: Shuah Khan <skhan@linuxfoundation.org>
>>>>>>>>
>>>>>>>
>>>>>>> Very cool. No errors with this patch. Thanks for fixing it
>>>>>>> quickly.
>>>>>>
>>>>>> I am happy I could fix that and thanks for confirming. I assume your
>>>>>> Tested-by could be added?
>>>>>
>>>>> Yes
>>>>>
>>>>> Tested-by: Shuah Khan <skhan@linuxfoundation.org>
>>>>>>
>>>>>> Is somebody willing to take this patch through their tree?
>>>>>>
>>>>>
>>>>> My guess is that these go through kbuild git??
>>>>
>>>> If you want to take this, that's fine with me. But as I had the
>>>> original file come through my tree, I can take it too. It's up to you,
>>>> either is ok with me.
>>>>
>>>
>>> Great. Please take this through your tree.
>>>
>>
>> Greg! Looks like this one didn't make it in. Can you pick this up?
>
> I think this is 55c7549819e4 ("scripts: add dummy report mode to
> add_namespace.cocci") in Linus's tree right now, right?
>
Yes. It is in Linux 5.9. I was looking in the wrong place on
Linux 5.8. :(
thanks,
-- Shuah
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
^ permalink raw reply [flat|nested] 22+ messages in thread