From: BALATON Zoltan <balaton@eik.bme.hu>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: David Gibson <david@gibson.dropbear.id.au>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
Greg Kurz <groug@kaod.org>
Subject: Re: [PATCH] mv64361: Remove extra break from a switch case
Date: Mon, 12 Jul 2021 16:38:43 +0200 (CEST) [thread overview]
Message-ID: <f0ea5e8c-f575-1f8-6914-de69a0c4b04b@eik.bme.hu> (raw)
In-Reply-To: <5a2131d6-4b85-839d-8cd3-18cdcea15925@amsat.org>
[-- Attachment #1: Type: text/plain, Size: 1292 bytes --]
On Mon, 12 Jul 2021, Philippe Mathieu-Daudé wrote:
> On 7/12/21 3:11 PM, BALATON Zoltan wrote:
>> The switch case of writing PCI 1 IO base address had an extra break
>> statement that made part of the code unreachable. This did not cause a
>> problem as guests ususally leave this register at its default value.
>>
>> Reported-by: Coverity (CID 1458135)
>
> Fixes: dcdf98a9015 ("Add emulation of Marvell MV64361 PPC system
> controller")
> ?
Yeah, why not. Feel free to add the Fixes tag when merging, although
that's the only commit this file had so far so linking to it does not seem
to add much more info.
Regards,
BALATON Zoltan
>> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
>> ---
>> hw/pci-host/mv64361.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/hw/pci-host/mv64361.c b/hw/pci-host/mv64361.c
>> index 20510d8680..92b0f5d047 100644
>> --- a/hw/pci-host/mv64361.c
>> +++ b/hw/pci-host/mv64361.c
>> @@ -687,7 +687,6 @@ static void mv64361_write(void *opaque, hwaddr addr, uint64_t val,
>> case MV64340_PCI_1_IO_BASE_ADDR:
>> s->pci[1].io_base = val & 0x30fffffULL;
>> warn_swap_bit(val);
>> - break;
>> if (!(s->cpu_conf & BIT(27))) {
>> s->pci[1].remap[4] = (val & 0xffffULL) << 16;
>> }
>>
>
>
next prev parent reply other threads:[~2021-07-12 14:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 13:11 [PATCH] mv64361: Remove extra break from a switch case BALATON Zoltan
2021-07-12 14:17 ` Philippe Mathieu-Daudé
2021-07-12 14:38 ` BALATON Zoltan [this message]
2021-07-13 0:12 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0ea5e8c-f575-1f8-6914-de69a0c4b04b@eik.bme.hu \
--to=balaton@eik.bme.hu \
--cc=david@gibson.dropbear.id.au \
--cc=f4bug@amsat.org \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.