From: Anton Ivanov <anton.ivanov@cambridgegreys.com>
To: Randy Dunlap <rdunlap@infradead.org>, David Gow <davidgow@google.com>
Cc: Masahiro Yamada <masahiroy@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
Nick Desaulniers <ndesaulniers@google.com>,
linux-kbuild@vger.kernel.org, Jeff Dike <jdike@addtoit.com>,
Richard Weinberger <richard@nod.at>,
linux-um <linux-um@lists.infradead.org>,
x86@kernel.org
Subject: Re: [PATCH] um: Add missing "FORCE" target when using if_changed
Date: Sat, 9 Oct 2021 06:36:36 +0100 [thread overview]
Message-ID: <f0ead035-f05b-73fb-1fd4-48c1eff8bc92@cambridgegreys.com> (raw)
In-Reply-To: <05939461-793d-2266-8752-1b593bab8eec@infradead.org>
On 09/10/2021 01:01, Randy Dunlap wrote:
> On 10/8/21 4:23 PM, David Gow wrote:
>> On Sat, Oct 9, 2021 at 5:51 AM Randy Dunlap <rdunlap@infradead.org>
>> wrote:
>>>
>>> 'make ARCH=um' says:
>>>
>>> ../arch/x86/um/Makefile:44: FORCE prerequisite is missing
>>>
>>> and adding "FORCE" there makes it be quiet, so do it. :)
>>>
>>> Fixes: e1f86d7b4b2a ("kbuild: warn if FORCE is missing for
>>> if_changed(_dep,_rule) and filechk")
>>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>>> Cc: Masahiro Yamada <masahiroy@kernel.org>
>>> Cc: Michal Marek <michal.lkml@markovi.net>
>>> Cc: Nick Desaulniers <ndesaulniers@google.com>
>>> Cc: linux-kbuild@vger.kernel.org
>>> Cc: Jeff Dike <jdike@addtoit.com>
>>> Cc: Richard Weinberger <richard@nod.at>
>>> Cc: Anton Ivanov <anton.ivanov@cambridgegreys.com>
>>> Cc: linux-um@lists.infradead.org
>>> Cc: x86@kernel.org
>>> ---
>>
>> FYI, this looks identical to "uml: x86: add FORCE to user_constants.h":
>> http://lists.infradead.org/pipermail/linux-um/2021-September/001791.html
>
> Oh, thanks for that.
>
> Maintainers?...
>
The patch by Johannes is not in the pending list in patchwork, so it
looks like Richard has processed it and it will be in the next pull request.
Brgds,
--
Anton R. Ivanov
Cambridgegreys Limited. Registered in England. Company Number 10273661
https://www.cambridgegreys.com/
WARNING: multiple messages have this Message-ID (diff)
From: Anton Ivanov <anton.ivanov@cambridgegreys.com>
To: Randy Dunlap <rdunlap@infradead.org>, David Gow <davidgow@google.com>
Cc: Masahiro Yamada <masahiroy@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
Nick Desaulniers <ndesaulniers@google.com>,
linux-kbuild@vger.kernel.org, Jeff Dike <jdike@addtoit.com>,
Richard Weinberger <richard@nod.at>,
linux-um <linux-um@lists.infradead.org>,
x86@kernel.org
Subject: Re: [PATCH] um: Add missing "FORCE" target when using if_changed
Date: Sat, 9 Oct 2021 06:36:36 +0100 [thread overview]
Message-ID: <f0ead035-f05b-73fb-1fd4-48c1eff8bc92@cambridgegreys.com> (raw)
In-Reply-To: <05939461-793d-2266-8752-1b593bab8eec@infradead.org>
On 09/10/2021 01:01, Randy Dunlap wrote:
> On 10/8/21 4:23 PM, David Gow wrote:
>> On Sat, Oct 9, 2021 at 5:51 AM Randy Dunlap <rdunlap@infradead.org>
>> wrote:
>>>
>>> 'make ARCH=um' says:
>>>
>>> ../arch/x86/um/Makefile:44: FORCE prerequisite is missing
>>>
>>> and adding "FORCE" there makes it be quiet, so do it. :)
>>>
>>> Fixes: e1f86d7b4b2a ("kbuild: warn if FORCE is missing for
>>> if_changed(_dep,_rule) and filechk")
>>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>>> Cc: Masahiro Yamada <masahiroy@kernel.org>
>>> Cc: Michal Marek <michal.lkml@markovi.net>
>>> Cc: Nick Desaulniers <ndesaulniers@google.com>
>>> Cc: linux-kbuild@vger.kernel.org
>>> Cc: Jeff Dike <jdike@addtoit.com>
>>> Cc: Richard Weinberger <richard@nod.at>
>>> Cc: Anton Ivanov <anton.ivanov@cambridgegreys.com>
>>> Cc: linux-um@lists.infradead.org
>>> Cc: x86@kernel.org
>>> ---
>>
>> FYI, this looks identical to "uml: x86: add FORCE to user_constants.h":
>> http://lists.infradead.org/pipermail/linux-um/2021-September/001791.html
>
> Oh, thanks for that.
>
> Maintainers?...
>
The patch by Johannes is not in the pending list in patchwork, so it
looks like Richard has processed it and it will be in the next pull request.
Brgds,
--
Anton R. Ivanov
Cambridgegreys Limited. Registered in England. Company Number 10273661
https://www.cambridgegreys.com/
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
next prev parent reply other threads:[~2021-10-09 5:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-08 21:51 [PATCH] um: Add missing "FORCE" target when using if_changed Randy Dunlap
2021-10-08 21:51 ` Randy Dunlap
2021-10-08 23:23 ` David Gow
2021-10-08 23:23 ` David Gow
2021-10-09 0:01 ` Randy Dunlap
2021-10-09 0:01 ` Randy Dunlap
2021-10-09 5:36 ` Anton Ivanov [this message]
2021-10-09 5:36 ` Anton Ivanov
2021-10-09 13:06 ` Johannes Berg
2021-10-09 13:06 ` Johannes Berg
2021-10-09 20:20 ` Richard Weinberger
2021-10-09 20:20 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0ead035-f05b-73fb-1fd4-48c1eff8bc92@cambridgegreys.com \
--to=anton.ivanov@cambridgegreys.com \
--cc=davidgow@google.com \
--cc=jdike@addtoit.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=ndesaulniers@google.com \
--cc=rdunlap@infradead.org \
--cc=richard@nod.at \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.