* [PATCH 2/2] net: Replace dev_kfree_skb_any by dev_consume_skb_any
@ 2019-02-14 6:42 Huang Zijiang
2019-02-14 9:13 ` Sergei Shtylyov
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Huang Zijiang @ 2019-02-14 6:42 UTC (permalink / raw)
To: linux-net-drivers
Cc: ecree, bkenward, davem, netdev, linux-kernel, wang.yi59, Huang Zijiang
The skb should be freed by dev_consume_skb_any() efx_tx_tso_fallback()
when skb is still used. The skb is be replaced by segments, so the
original skb should be consumed(not drop).
Signed-off-by: Huang Zijiang <huang.zijiang@zte.com.cn>
---
drivers/net/ethernet/sfc/tx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/sfc/tx.c b/drivers/net/ethernet/sfc/tx.c
index c3ad564..ed551f0 100644
--- a/drivers/net/ethernet/sfc/tx.c
+++ b/drivers/net/ethernet/sfc/tx.c
@@ -471,7 +471,7 @@ static int efx_tx_tso_fallback(struct efx_tx_queue *tx_queue,
if (IS_ERR(segments))
return PTR_ERR(segments);
- dev_kfree_skb_any(skb);
+ dev_consume_skb_any(skb);
skb = segments;
while (skb) {
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] net: Replace dev_kfree_skb_any by dev_consume_skb_any
2019-02-14 6:42 [PATCH 2/2] net: Replace dev_kfree_skb_any by dev_consume_skb_any Huang Zijiang
@ 2019-02-14 9:13 ` Sergei Shtylyov
2019-02-14 9:34 ` Bert Kenward
2019-02-14 17:28 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2019-02-14 9:13 UTC (permalink / raw)
To: Huang Zijiang, linux-net-drivers
Cc: ecree, bkenward, davem, netdev, linux-kernel, wang.yi59
Hello!
On 14.02.2019 9:42, Huang Zijiang wrote:
> The skb should be freed by dev_consume_skb_any() efx_tx_tso_fallback()
^ in?
> when skb is still used. The skb is be replaced by segments, so the
^^ will?
> original skb should be consumed(not drop).
>
> Signed-off-by: Huang Zijiang <huang.zijiang@zte.com.cn>
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] net: Replace dev_kfree_skb_any by dev_consume_skb_any
2019-02-14 6:42 [PATCH 2/2] net: Replace dev_kfree_skb_any by dev_consume_skb_any Huang Zijiang
2019-02-14 9:13 ` Sergei Shtylyov
@ 2019-02-14 9:34 ` Bert Kenward
2019-02-14 17:28 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Bert Kenward @ 2019-02-14 9:34 UTC (permalink / raw)
To: Huang Zijiang, linux-net-drivers
Cc: ecree, davem, netdev, linux-kernel, wang.yi59
On 14/02/2019 06:42, Huang Zijiang wrote:
> The skb should be freed by dev_consume_skb_any() efx_tx_tso_fallback()
> when skb is still used. The skb is be replaced by segments, so the
> original skb should be consumed(not drop).
>
> Signed-off-by: Huang Zijiang <huang.zijiang@zte.com.cn>
Sergei's commit message fixups look good, but apart from that:
Acked-by: Bert Kenward <bkenward@solarflare.com>
> ---
> drivers/net/ethernet/sfc/tx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/sfc/tx.c b/drivers/net/ethernet/sfc/tx.c
> index c3ad564..ed551f0 100644
> --- a/drivers/net/ethernet/sfc/tx.c
> +++ b/drivers/net/ethernet/sfc/tx.c
> @@ -471,7 +471,7 @@ static int efx_tx_tso_fallback(struct efx_tx_queue *tx_queue,
> if (IS_ERR(segments))
> return PTR_ERR(segments);
>
> - dev_kfree_skb_any(skb);
> + dev_consume_skb_any(skb);
> skb = segments;
>
> while (skb) {
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] net: Replace dev_kfree_skb_any by dev_consume_skb_any
2019-02-14 6:42 [PATCH 2/2] net: Replace dev_kfree_skb_any by dev_consume_skb_any Huang Zijiang
2019-02-14 9:13 ` Sergei Shtylyov
2019-02-14 9:34 ` Bert Kenward
@ 2019-02-14 17:28 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2019-02-14 17:28 UTC (permalink / raw)
To: huang.zijiang
Cc: linux-net-drivers, ecree, bkenward, netdev, linux-kernel, wang.yi59
From: Huang Zijiang <huang.zijiang@zte.com.cn>
Date: Thu, 14 Feb 2019 14:42:13 +0800
> The skb should be freed by dev_consume_skb_any() efx_tx_tso_fallback()
> when skb is still used. The skb is be replaced by segments, so the
> original skb should be consumed(not drop).
>
> Signed-off-by: Huang Zijiang <huang.zijiang@zte.com.cn>
Applied with Sergei's suggested commit message fixups.
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-02-14 17:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-14 6:42 [PATCH 2/2] net: Replace dev_kfree_skb_any by dev_consume_skb_any Huang Zijiang
2019-02-14 9:13 ` Sergei Shtylyov
2019-02-14 9:34 ` Bert Kenward
2019-02-14 17:28 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.