All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Straube <straube.linux@gmail.com>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
	gregkh@linuxfoundation.org
Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
	martin@kaiser.cx, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/4] staging: r8188eu: remove unused fields from struct hal_data_8188e
Date: Wed, 15 Sep 2021 17:49:38 +0200	[thread overview]
Message-ID: <f0fcfced-3d32-f302-10f2-a1eeca57039e@gmail.com> (raw)
In-Reply-To: <2416232.Kz4EfdPaPr@localhost.localdomain>

On 9/15/21 15:34, Fabio M. De Francesco wrote:
> On Wednesday, September 15, 2021 11:01:52 AM CEST Michael Straube wrote:
>> This series removes some unused fields from struct hal_data_8188eu.
>>
>> Tested on x86_64 with Inter-Tech DMG-02.
>>
>> v1 -> v2
>> Fixed a typo in the subject line of patch 3/4.
>>
>> Michael Straube (4):
>>    staging: r8188eu: remove unused macros from rtl8188e_hal.h
>>    staging: r8188eu: remove write-only fields from struct hal_data_8188e
>>    staging: r8188eu: remove unused enums from rtl8188e_hal.h
>>    staging: r8188eu: remove unused field from struct hal_data_8188e
>>
>>   .../staging/r8188eu/hal/rtl8188e_hal_init.c   |  5 -----
>>   .../staging/r8188eu/include/rtl8188e_hal.h    | 22 -------------------
>>   2 files changed, 27 deletions(-)
>>
>> -- 
>> 2.33.0
> 
> Hi Michael,
> 
> Due to your removals, this driver is now about a third lighter. After fixing
> that little issue that Philip noticed, this series looks as good as any of
> yours. So...
> 
> Acked-by:  Fabio M. De Francesco <fmdefrancesco@gmail.com>

Thank you Fabio.

Well others have contributed to rip out unused code too. ;)
It's nice to see so many people care about this driver. Seems there is a
little chance to get it out of staging some day... though there is still
a lot of work/cleanup to do.

Regards,
Michael

      reply	other threads:[~2021-09-15 15:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-15  9:01 [PATCH v2 0/4] staging: r8188eu: remove unused fields from struct hal_data_8188e Michael Straube
2021-09-15  9:01 ` [PATCH v2 1/4] staging: r8188eu: remove unused macros from rtl8188e_hal.h Michael Straube
2021-09-15  9:01 ` [PATCH v2 2/4] staging: r8188eu: remove write-only fields from struct hal_data_8188e Michael Straube
2021-09-15  9:01 ` [PATCH v2 3/4] staging: r8188eu: remove unused enums from rtl8188e_hal.h Michael Straube
2021-09-15  9:01 ` [PATCH v2 4/4] staging: r8188eu: remove unused field from struct hal_data_8188e Michael Straube
2021-09-15 13:34 ` [PATCH v2 0/4] staging: r8188eu: remove unused fields " Fabio M. De Francesco
2021-09-15 15:49   ` Michael Straube [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f0fcfced-3d32-f302-10f2-a1eeca57039e@gmail.com \
    --to=straube.linux@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=fmdefrancesco@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=martin@kaiser.cx \
    --cc=phil@philpotter.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.