* [PATCH] pci: dwc: dra7xx: Add shutdown handler to cleanly turn off clocks
@ 2017-09-06 10:39 ` Keerthy
0 siblings, 0 replies; 8+ messages in thread
From: Keerthy @ 2017-09-06 10:39 UTC (permalink / raw)
To: kishon, bhelgaas; +Cc: t-kristo, linux-kernel, linux-omap, linux-pci, j-keerthy
Add shutdown handler to cleanly turn off clocks.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
drivers/pci/dwc/pci-dra7xx.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
index d4e98f3..66d1cfe 100644
--- a/drivers/pci/dwc/pci-dra7xx.c
+++ b/drivers/pci/dwc/pci-dra7xx.c
@@ -874,6 +874,19 @@ static int dra7xx_pcie_suspend_noirq(struct device *dev)
return 0;
}
+void dra7xx_pcie_shutdown(struct platform_device *pdev)
+{
+ struct dra7xx_pcie *dra7xx = dev_get_drvdata(&pdev->dev);
+ int ret;
+
+ ret = pm_runtime_put_sync(&pdev->dev);
+ if (ret < 0)
+ dev_dbg(&pdev->dev, "pm_runtime_put_sync failed\n");
+
+ pm_runtime_disable(&pdev->dev);
+ dra7xx_pcie_disable_phy(dra7xx);
+}
+
static int dra7xx_pcie_resume_noirq(struct device *dev)
{
struct dra7xx_pcie *dra7xx = dev_get_drvdata(dev);
@@ -902,5 +915,6 @@ static int dra7xx_pcie_resume_noirq(struct device *dev)
.suppress_bind_attrs = true,
.pm = &dra7xx_pcie_pm_ops,
},
+ .shutdown = dra7xx_pcie_shutdown,
};
builtin_platform_driver_probe(dra7xx_pcie_driver, dra7xx_pcie_probe);
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] pci: dwc: dra7xx: Add shutdown handler to cleanly turn off clocks
@ 2017-09-06 10:39 ` Keerthy
0 siblings, 0 replies; 8+ messages in thread
From: Keerthy @ 2017-09-06 10:39 UTC (permalink / raw)
To: kishon, bhelgaas; +Cc: t-kristo, linux-kernel, linux-omap, linux-pci, j-keerthy
Add shutdown handler to cleanly turn off clocks.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
drivers/pci/dwc/pci-dra7xx.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
index d4e98f3..66d1cfe 100644
--- a/drivers/pci/dwc/pci-dra7xx.c
+++ b/drivers/pci/dwc/pci-dra7xx.c
@@ -874,6 +874,19 @@ static int dra7xx_pcie_suspend_noirq(struct device *dev)
return 0;
}
+void dra7xx_pcie_shutdown(struct platform_device *pdev)
+{
+ struct dra7xx_pcie *dra7xx = dev_get_drvdata(&pdev->dev);
+ int ret;
+
+ ret = pm_runtime_put_sync(&pdev->dev);
+ if (ret < 0)
+ dev_dbg(&pdev->dev, "pm_runtime_put_sync failed\n");
+
+ pm_runtime_disable(&pdev->dev);
+ dra7xx_pcie_disable_phy(dra7xx);
+}
+
static int dra7xx_pcie_resume_noirq(struct device *dev)
{
struct dra7xx_pcie *dra7xx = dev_get_drvdata(dev);
@@ -902,5 +915,6 @@ static int dra7xx_pcie_resume_noirq(struct device *dev)
.suppress_bind_attrs = true,
.pm = &dra7xx_pcie_pm_ops,
},
+ .shutdown = dra7xx_pcie_shutdown,
};
builtin_platform_driver_probe(dra7xx_pcie_driver, dra7xx_pcie_probe);
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] pci: dwc: dra7xx: Add shutdown handler to cleanly turn off clocks
2017-09-06 10:39 ` Keerthy
@ 2017-09-06 10:53 ` Kishon Vijay Abraham I
-1 siblings, 0 replies; 8+ messages in thread
From: Kishon Vijay Abraham I @ 2017-09-06 10:53 UTC (permalink / raw)
To: Keerthy, bhelgaas; +Cc: t-kristo, linux-kernel, linux-omap, linux-pci
Keerthy,
On Wednesday 06 September 2017 04:09 PM, Keerthy wrote:
> Add shutdown handler to cleanly turn off clocks.
one minor comment below.. with that fixed you can add my
Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> drivers/pci/dwc/pci-dra7xx.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
> index d4e98f3..66d1cfe 100644
> --- a/drivers/pci/dwc/pci-dra7xx.c
> +++ b/drivers/pci/dwc/pci-dra7xx.c
> @@ -874,6 +874,19 @@ static int dra7xx_pcie_suspend_noirq(struct device *dev)
> return 0;
> }
>
> +void dra7xx_pcie_shutdown(struct platform_device *pdev)
> +{
> + struct dra7xx_pcie *dra7xx = dev_get_drvdata(&pdev->dev);
Use struct device *dev = &pdev->dev, instead of de-referencing device pointer
multiple times.
Thanks
Kishon
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] pci: dwc: dra7xx: Add shutdown handler to cleanly turn off clocks
@ 2017-09-06 10:53 ` Kishon Vijay Abraham I
0 siblings, 0 replies; 8+ messages in thread
From: Kishon Vijay Abraham I @ 2017-09-06 10:53 UTC (permalink / raw)
To: Keerthy, bhelgaas; +Cc: t-kristo, linux-kernel, linux-omap, linux-pci
Keerthy,
On Wednesday 06 September 2017 04:09 PM, Keerthy wrote:
> Add shutdown handler to cleanly turn off clocks.
one minor comment below.. with that fixed you can add my
Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> drivers/pci/dwc/pci-dra7xx.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
> index d4e98f3..66d1cfe 100644
> --- a/drivers/pci/dwc/pci-dra7xx.c
> +++ b/drivers/pci/dwc/pci-dra7xx.c
> @@ -874,6 +874,19 @@ static int dra7xx_pcie_suspend_noirq(struct device *dev)
> return 0;
> }
>
> +void dra7xx_pcie_shutdown(struct platform_device *pdev)
> +{
> + struct dra7xx_pcie *dra7xx = dev_get_drvdata(&pdev->dev);
Use struct device *dev = &pdev->dev, instead of de-referencing device pointer
multiple times.
Thanks
Kishon
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] pci: dwc: dra7xx: Add shutdown handler to cleanly turn off clocks
2017-09-06 10:53 ` Kishon Vijay Abraham I
@ 2017-09-06 10:56 ` Kishon Vijay Abraham I
-1 siblings, 0 replies; 8+ messages in thread
From: Kishon Vijay Abraham I @ 2017-09-06 10:56 UTC (permalink / raw)
To: Keerthy, bhelgaas; +Cc: t-kristo, linux-kernel, linux-omap, linux-pci
On Wednesday 06 September 2017 04:23 PM, Kishon Vijay Abraham I wrote:
> Keerthy,
>
> On Wednesday 06 September 2017 04:09 PM, Keerthy wrote:
>> Add shutdown handler to cleanly turn off clocks.
>
> one minor comment below.. with that fixed you can add my
>
> Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
>>
>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>> ---
>> drivers/pci/dwc/pci-dra7xx.c | 14 ++++++++++++++
>> 1 file changed, 14 insertions(+)
>>
>> diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
>> index d4e98f3..66d1cfe 100644
>> --- a/drivers/pci/dwc/pci-dra7xx.c
>> +++ b/drivers/pci/dwc/pci-dra7xx.c
>> @@ -874,6 +874,19 @@ static int dra7xx_pcie_suspend_noirq(struct device *dev)
>> return 0;
>> }
>>
>> +void dra7xx_pcie_shutdown(struct platform_device *pdev)
>> +{
>> + struct dra7xx_pcie *dra7xx = dev_get_drvdata(&pdev->dev);
>
> Use struct device *dev = &pdev->dev, instead of de-referencing device pointer
> multiple times.
You might also have to dra7xx_pcie_stop_link() before disabling the clocks.
Thanks
Kishon
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] pci: dwc: dra7xx: Add shutdown handler to cleanly turn off clocks
@ 2017-09-06 10:56 ` Kishon Vijay Abraham I
0 siblings, 0 replies; 8+ messages in thread
From: Kishon Vijay Abraham I @ 2017-09-06 10:56 UTC (permalink / raw)
To: Keerthy, bhelgaas; +Cc: t-kristo, linux-kernel, linux-omap, linux-pci
On Wednesday 06 September 2017 04:23 PM, Kishon Vijay Abraham I wrote:
> Keerthy,
>
> On Wednesday 06 September 2017 04:09 PM, Keerthy wrote:
>> Add shutdown handler to cleanly turn off clocks.
>
> one minor comment below.. with that fixed you can add my
>
> Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
>>
>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>> ---
>> drivers/pci/dwc/pci-dra7xx.c | 14 ++++++++++++++
>> 1 file changed, 14 insertions(+)
>>
>> diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
>> index d4e98f3..66d1cfe 100644
>> --- a/drivers/pci/dwc/pci-dra7xx.c
>> +++ b/drivers/pci/dwc/pci-dra7xx.c
>> @@ -874,6 +874,19 @@ static int dra7xx_pcie_suspend_noirq(struct device *dev)
>> return 0;
>> }
>>
>> +void dra7xx_pcie_shutdown(struct platform_device *pdev)
>> +{
>> + struct dra7xx_pcie *dra7xx = dev_get_drvdata(&pdev->dev);
>
> Use struct device *dev = &pdev->dev, instead of de-referencing device pointer
> multiple times.
You might also have to dra7xx_pcie_stop_link() before disabling the clocks.
Thanks
Kishon
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] pci: dwc: dra7xx: Add shutdown handler to cleanly turn off clocks
2017-09-06 10:56 ` Kishon Vijay Abraham I
@ 2017-09-06 12:59 ` Keerthy
-1 siblings, 0 replies; 8+ messages in thread
From: Keerthy @ 2017-09-06 12:59 UTC (permalink / raw)
To: Kishon Vijay Abraham I, bhelgaas
Cc: t-kristo, linux-kernel, linux-omap, linux-pci
On Wednesday 06 September 2017 04:26 PM, Kishon Vijay Abraham I wrote:
>
>
> On Wednesday 06 September 2017 04:23 PM, Kishon Vijay Abraham I wrote:
>> Keerthy,
>>
>> On Wednesday 06 September 2017 04:09 PM, Keerthy wrote:
>>> Add shutdown handler to cleanly turn off clocks.
>>
>> one minor comment below.. with that fixed you can add my
>>
>> Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
>>>
>>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>>> ---
>>> drivers/pci/dwc/pci-dra7xx.c | 14 ++++++++++++++
>>> 1 file changed, 14 insertions(+)
>>>
>>> diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
>>> index d4e98f3..66d1cfe 100644
>>> --- a/drivers/pci/dwc/pci-dra7xx.c
>>> +++ b/drivers/pci/dwc/pci-dra7xx.c
>>> @@ -874,6 +874,19 @@ static int dra7xx_pcie_suspend_noirq(struct device *dev)
>>> return 0;
>>> }
>>>
>>> +void dra7xx_pcie_shutdown(struct platform_device *pdev)
>>> +{
>>> + struct dra7xx_pcie *dra7xx = dev_get_drvdata(&pdev->dev);
>>
>> Use struct device *dev = &pdev->dev, instead of de-referencing device pointer
>> multiple times.
>
> You might also have to dra7xx_pcie_stop_link() before disabling the clocks.
Thanks for the quick review. I will incorporate the above comments and
post v2.
Regards,
Keerthy
>
> Thanks
> Kishon
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] pci: dwc: dra7xx: Add shutdown handler to cleanly turn off clocks
@ 2017-09-06 12:59 ` Keerthy
0 siblings, 0 replies; 8+ messages in thread
From: Keerthy @ 2017-09-06 12:59 UTC (permalink / raw)
To: Kishon Vijay Abraham I, bhelgaas
Cc: t-kristo, linux-kernel, linux-omap, linux-pci
On Wednesday 06 September 2017 04:26 PM, Kishon Vijay Abraham I wrote:
>
>
> On Wednesday 06 September 2017 04:23 PM, Kishon Vijay Abraham I wrote:
>> Keerthy,
>>
>> On Wednesday 06 September 2017 04:09 PM, Keerthy wrote:
>>> Add shutdown handler to cleanly turn off clocks.
>>
>> one minor comment below.. with that fixed you can add my
>>
>> Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
>>>
>>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>>> ---
>>> drivers/pci/dwc/pci-dra7xx.c | 14 ++++++++++++++
>>> 1 file changed, 14 insertions(+)
>>>
>>> diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
>>> index d4e98f3..66d1cfe 100644
>>> --- a/drivers/pci/dwc/pci-dra7xx.c
>>> +++ b/drivers/pci/dwc/pci-dra7xx.c
>>> @@ -874,6 +874,19 @@ static int dra7xx_pcie_suspend_noirq(struct device *dev)
>>> return 0;
>>> }
>>>
>>> +void dra7xx_pcie_shutdown(struct platform_device *pdev)
>>> +{
>>> + struct dra7xx_pcie *dra7xx = dev_get_drvdata(&pdev->dev);
>>
>> Use struct device *dev = &pdev->dev, instead of de-referencing device pointer
>> multiple times.
>
> You might also have to dra7xx_pcie_stop_link() before disabling the clocks.
Thanks for the quick review. I will incorporate the above comments and
post v2.
Regards,
Keerthy
>
> Thanks
> Kishon
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-09-06 12:59 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-06 10:39 [PATCH] pci: dwc: dra7xx: Add shutdown handler to cleanly turn off clocks Keerthy
2017-09-06 10:39 ` Keerthy
2017-09-06 10:53 ` Kishon Vijay Abraham I
2017-09-06 10:53 ` Kishon Vijay Abraham I
2017-09-06 10:56 ` Kishon Vijay Abraham I
2017-09-06 10:56 ` Kishon Vijay Abraham I
2017-09-06 12:59 ` Keerthy
2017-09-06 12:59 ` Keerthy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.