[PATCH mptcp-net] Squash-to: "selftests: mptcp: more stable diag tests"

[PATCH mptcp-net] Squash-to: "selftests: mptcp: more stable diag tests"

[Paolo Abeni]

The "....chk remote_key" testcase is failing quite often in debug
build. I guess the mptcp_connect completes before the script execute
this latter test, so I'm adding another large wait. It should not
impact the test run-time, as the mptcp_connect processes are terminated
just after running the check.

Signed-off-by: Paolo Abeni <pabeni@redhat.com>
---
this is wild guess, mostly to trigger/inspect the test results
---
 tools/testing/selftests/net/mptcp/diag.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tools/testing/selftests/net/mptcp/diag.sh b/tools/testing/selftests/net/mptcp/diag.sh
index ee2f238255ec..515859a5168b 100755
--- a/tools/testing/selftests/net/mptcp/diag.sh
+++ b/tools/testing/selftests/net/mptcp/diag.sh
@@ -179,7 +179,7 @@ ip -n $ns link set dev lo up
 echo "a" | \
 	timeout ${timeout_test} \
 		ip netns exec $ns \
-			./mptcp_connect -p 10000 -l -t ${timeout_poll} \
+			./mptcp_connect -p 10000 -l -t ${timeout_poll} -w 20 \
 				0.0.0.0 >/dev/null &
 wait_local_port_listen $ns 10000
 chk_msk_nr 0 "no msk on netns creation"
@@ -188,7 +188,7 @@ chk_msk_listen 10000
 echo "b" | \
 	timeout ${timeout_test} \
 		ip netns exec $ns \
-			./mptcp_connect -p 10000 -r 0 -t ${timeout_poll} \
+			./mptcp_connect -p 10000 -r 0 -t ${timeout_poll} -w 20 \
 				127.0.0.1 >/dev/null &
 wait_connected $ns 10000
 chk_msk_nr 2 "after MPC handshake "
@@ -200,13 +200,13 @@ flush_pids
 echo "a" | \
 	timeout ${timeout_test} \
 		ip netns exec $ns \
-			./mptcp_connect -p 10001 -l -s TCP -t ${timeout_poll} \
+			./mptcp_connect -p 10001 -l -s TCP -t ${timeout_poll} -w 20 \
 				0.0.0.0 >/dev/null &
 wait_local_port_listen $ns 10001
 echo "b" | \
 	timeout ${timeout_test} \
 		ip netns exec $ns \
-			./mptcp_connect -p 10001 -r 0 -t ${timeout_poll} \
+			./mptcp_connect -p 10001 -r 0 -t ${timeout_poll} -w 20 \
 				127.0.0.1 >/dev/null &
 wait_connected $ns 10001
 chk_msk_fallback_nr 1 "check fallback"
-- 
2.35.3

Re: Squash-to: "selftests: mptcp: more stable diag tests": Tests Results

[MPTCP CI]

Hi Paolo,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal:
  - Success! ✅:
  - Task: https://cirrus-ci.com/task/6497233930551296
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/6497233930551296/summary/summary.txt

- KVM Validation: debug:
  - Unstable: 2 failed test(s): selftest_mptcp_connect selftest_mptcp_join 🔴:
  - Task: https://cirrus-ci.com/task/5273199779774464
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/5273199779774464/summary/summary.txt

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/9c6d0fe8af73


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-debug

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (Tessares)

Re: [PATCH mptcp-net] Squash-to: "selftests: mptcp: more stable diag tests"

[Mat Martineau]

On Wed, 22 Jun 2022, Paolo Abeni wrote:

> The "....chk remote_key" testcase is failing quite often in debug
> build. I guess the mptcp_connect completes before the script execute
> this latter test, so I'm adding another large wait. It should not
> impact the test run-time, as the mptcp_connect processes are terminated
> just after running the check.
>
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> ---
> this is wild guess, mostly to trigger/inspect the test results

Looks good to squash - CI looks ok too.

- Mat


> ---
> tools/testing/selftests/net/mptcp/diag.sh | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tools/testing/selftests/net/mptcp/diag.sh b/tools/testing/selftests/net/mptcp/diag.sh
> index ee2f238255ec..515859a5168b 100755
> --- a/tools/testing/selftests/net/mptcp/diag.sh
> +++ b/tools/testing/selftests/net/mptcp/diag.sh
> @@ -179,7 +179,7 @@ ip -n $ns link set dev lo up
> echo "a" | \
> 	timeout ${timeout_test} \
> 		ip netns exec $ns \
> -			./mptcp_connect -p 10000 -l -t ${timeout_poll} \
> +			./mptcp_connect -p 10000 -l -t ${timeout_poll} -w 20 \
> 				0.0.0.0 >/dev/null &
> wait_local_port_listen $ns 10000
> chk_msk_nr 0 "no msk on netns creation"
> @@ -188,7 +188,7 @@ chk_msk_listen 10000
> echo "b" | \
> 	timeout ${timeout_test} \
> 		ip netns exec $ns \
> -			./mptcp_connect -p 10000 -r 0 -t ${timeout_poll} \
> +			./mptcp_connect -p 10000 -r 0 -t ${timeout_poll} -w 20 \
> 				127.0.0.1 >/dev/null &
> wait_connected $ns 10000
> chk_msk_nr 2 "after MPC handshake "
> @@ -200,13 +200,13 @@ flush_pids
> echo "a" | \
> 	timeout ${timeout_test} \
> 		ip netns exec $ns \
> -			./mptcp_connect -p 10001 -l -s TCP -t ${timeout_poll} \
> +			./mptcp_connect -p 10001 -l -s TCP -t ${timeout_poll} -w 20 \
> 				0.0.0.0 >/dev/null &
> wait_local_port_listen $ns 10001
> echo "b" | \
> 	timeout ${timeout_test} \
> 		ip netns exec $ns \
> -			./mptcp_connect -p 10001 -r 0 -t ${timeout_poll} \
> +			./mptcp_connect -p 10001 -r 0 -t ${timeout_poll} -w 20 \
> 				127.0.0.1 >/dev/null &
> wait_connected $ns 10001
> chk_msk_fallback_nr 1 "check fallback"
> -- 
> 2.35.3
>
>
>

--
Mat Martineau
Intel

Re: [PATCH mptcp-net] Squash-to: "selftests: mptcp: more stable diag tests"

[Matthieu Baerts]

Hi Paolo, Mat,

On 22/06/2022 11:47, Paolo Abeni wrote:
> The "....chk remote_key" testcase is failing quite often in debug
> build. I guess the mptcp_connect completes before the script execute
> this latter test, so I'm adding another large wait. It should not
> impact the test run-time, as the mptcp_connect processes are terminated
> just after running the check.

Thank you for the patch and the review!

New patches for t/upstream-net:
- c15701ca49c2: "squashed" in "selftests: mptcp: more stable diag tests"
- Results: 7db03aa2d67f..66322cb76048 (export-net)

New patches for t/upstream:
- c15701ca49c2: "squashed" in "selftests: mptcp: more stable diag tests"
- Results: cbb1cc653035..23a79309dbdb (export)


Builds and tests are now in progress:

https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export-net/20220622T211409
https://github.com/multipath-tcp/mptcp_net-next/actions/workflows/build-validation.yml?query=branch:export-net

https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20220622T211409
https://github.com/multipath-tcp/mptcp_net-next/actions/workflows/build-validation.yml?query=branch:export


Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net