* [PATCH] drm/amd/scheduler:fix duplicate operation in entity fini
@ 2017-10-23 6:00 Monk Liu
[not found] ` <1508738432-27426-1-git-send-email-Monk.Liu-5C7GfCeVMHo@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Monk Liu @ 2017-10-23 6:00 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Monk Liu
no need to manually cleanup job and fence after sched_fence_finish(),
they are auto handled by the callback
Change-Id: I9da26064c9e73c178949663bed1e490539e95e41
Signed-off-by: Monk Liu <Monk.Liu@amd.com>
---
drivers/gpu/drm/amd/scheduler/gpu_scheduler.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/scheduler/gpu_scheduler.c b/drivers/gpu/drm/amd/scheduler/gpu_scheduler.c
index 39b6205..f9f3daa 100644
--- a/drivers/gpu/drm/amd/scheduler/gpu_scheduler.c
+++ b/drivers/gpu/drm/amd/scheduler/gpu_scheduler.c
@@ -230,11 +230,10 @@ void amd_sched_entity_fini(struct amd_gpu_scheduler *sched,
kthread_unpark(sched->thread);
while (kfifo_out(&entity->job_queue, &job, sizeof(job))) {
struct amd_sched_fence *s_fence = job->s_fence;
+
amd_sched_fence_scheduled(s_fence);
dma_fence_set_error(&s_fence->finished, -ESRCH);
amd_sched_fence_finished(s_fence);
- dma_fence_put(&s_fence->finished);
- sched->ops->free_job(job);
}
}
--
2.7.4
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/amd/scheduler:fix duplicate operation in entity fini
[not found] ` <1508738432-27426-1-git-send-email-Monk.Liu-5C7GfCeVMHo@public.gmane.org>
@ 2017-10-23 7:12 ` Christian König
0 siblings, 0 replies; 2+ messages in thread
From: Christian König @ 2017-10-23 7:12 UTC (permalink / raw)
To: Monk Liu, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Am 23.10.2017 um 08:00 schrieb Monk Liu:
> no need to manually cleanup job and fence after sched_fence_finish(),
> they are auto handled by the callback
>
> Change-Id: I9da26064c9e73c178949663bed1e490539e95e41
> Signed-off-by: Monk Liu <Monk.Liu@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/scheduler/gpu_scheduler.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/scheduler/gpu_scheduler.c b/drivers/gpu/drm/amd/scheduler/gpu_scheduler.c
> index 39b6205..f9f3daa 100644
> --- a/drivers/gpu/drm/amd/scheduler/gpu_scheduler.c
> +++ b/drivers/gpu/drm/amd/scheduler/gpu_scheduler.c
> @@ -230,11 +230,10 @@ void amd_sched_entity_fini(struct amd_gpu_scheduler *sched,
> kthread_unpark(sched->thread);
> while (kfifo_out(&entity->job_queue, &job, sizeof(job))) {
> struct amd_sched_fence *s_fence = job->s_fence;
> +
> amd_sched_fence_scheduled(s_fence);
> dma_fence_set_error(&s_fence->finished, -ESRCH);
> amd_sched_fence_finished(s_fence);
> - dma_fence_put(&s_fence->finished);
> - sched->ops->free_job(job);
> }
>
> }
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-23 7:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-23 6:00 [PATCH] drm/amd/scheduler:fix duplicate operation in entity fini Monk Liu
[not found] ` <1508738432-27426-1-git-send-email-Monk.Liu-5C7GfCeVMHo@public.gmane.org>
2017-10-23 7:12 ` Christian König
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.