Re: [OE-core] [PATCH 1/3] scripts/contrib: Add override conversion script

Re: [OE-core] [PATCH 1/3] scripts/contrib: Add override conversion script

[Richard Purdie]

On Wed, 2021-07-28 at 15:15 +0100, Richard Purdie via lists.openembedded.org wrote:
> This adds a script I've developed to migrate metadata to use the new override
> syntax. It is a bit rough but since its for a single use with validation, it
> doesn't need to be perfect. It is run simply as:
> 
> scripts/contrib/convert-overrides.py <directory>
> 
> It is setup and has been tested to work with OE-Core, Bitbake, yocto-docs,
> meta-yocto, meta-gplv2 and meta-mingw. For OE-Core, it converts around 10,100
> lines with about 34 manual fixes needed.
> 
> For other layers it would need updating for override names and exclusions for
> functions/variable names with "append", "prepend" or "remove" in them.
> 
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
>  scripts/contrib/convert-overrides.py | 146 +++++++++++++++++++++++++++
>  1 file changed, 146 insertions(+)
>  create mode 100755 scripts/contrib/convert-overrides.py

Since people are starting to use this, it is easier if it is in OE-Core and
we can then make changes as normal to it with patches.

I've therefore merged an updated version which has taken some of the review
feedback on board and improved it, along with feedback from some real world
use.

Cheers,

Richard

Re: [OE-core] [PATCH 1/3] scripts/contrib: Add override conversion script

[Robert Berger]

Hi,

Not sure this is the right list and mail I am replying to ;)

I was wondering what's happening with backwards compatibility.

It looks like it will not be possible to have a layer with new syntax 
fixes which will also work for some older versions (hardknott and older).

Regards,

Robert

> 
> 
> 

Re: [OE-core] [PATCH 1/3] scripts/contrib: Add override conversion script

[Richard Purdie]

On Sat, 2021-07-31 at 15:55 +0300, Robert Berger wrote:
> Not sure this is the right list and mail I am replying to ;)
> 
> I was wondering what's happening with backwards compatibility.
> 
> It looks like it will not be possible to have a layer with new syntax 
> fixes which will also work for some older versions (hardknott and older).

That isn't correct. There are patches backported to the bitbake 1.50, 1.48 
and 1.46 branches which mean the older bitbake will accept the new syntax.

This means that converted layers will work with older releases, as long
as someone has updated to the new version of bitbake for that stable series
(and the later worked with that release in the first place!).

Cheers,

Richard

Re: [OE-core] [PATCH 1/3] scripts/contrib: Add override conversion script

[Robert Berger]

Hi Richard,

On 31/07/2021 16:14, Richard Purdie wrote:
> 
> That isn't correct. There are patches backported to the bitbake 1.50, 1.48
> and 1.46 branches which mean the older bitbake will accept the new syntax.
> 
> This means that converted layers will work with older releases, as long
> as someone has updated to the new version of bitbake for that stable series
> (and the later worked with that release in the first place!).

Makes sense. Thanks for the clarification.

> 
> Cheers,
> 
> Richard
> 

Regards,

Robert

Re: [OE-core] [PATCH 1/3] scripts/contrib: Add override conversion script

[Michael Opdenacker]

On 7/28/21 4:15 PM, Richard Purdie wrote:
> This adds a script I've developed to migrate metadata to use the new override
> syntax. It is a bit rough but since its for a single use with validation, it
> doesn't need to be perfect. It is run simply as:
>
> scripts/contrib/convert-overrides.py <directory>
>
> It is setup and has been tested to work with OE-Core, Bitbake, yocto-docs,
> meta-yocto, meta-gplv2 and meta-mingw. For OE-Core, it converts around 10,100
> lines with about 34 manual fixes needed.
>
> For other layers it would need updating for override names and exclusions for
> functions/variable names with "append", "prepend" or "remove" in them.
>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
>  scripts/contrib/convert-overrides.py | 146 +++++++++++++++++++++++++++
>  1 file changed, 146 insertions(+)
>  create mode 100755 scripts/contrib/convert-overrides.py
>
> diff --git a/scripts/contrib/convert-overrides.py b/scripts/contrib/convert-overrides.py


Tested-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
Working fine on documentation sources, though I'll exclude the changes
to migration guides from past versions.
Thanks!

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com