* [PATCH] x86/msr: Fix XEN_MSR_PAT to build with older binutils
@ 2020-04-29 21:39 Andrew Cooper
2020-04-30 6:50 ` Jan Beulich
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Cooper @ 2020-04-29 21:39 UTC (permalink / raw)
To: Xen-devel; +Cc: Andrew Cooper, Wei Liu, Jan Beulich, Roger Pau Monné
Older binutils complains with:
trampoline.S:95: Error: junk `ul&0xffffffff' after expression
Use an assembly-safe constant.
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Wei Liu <wl@xen.org>
CC: Roger Pau Monné <roger.pau@citrix.com>
---
xen/include/asm-x86/processor.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/include/asm-x86/processor.h b/xen/include/asm-x86/processor.h
index ea6e5497f4..8f6f5a97dd 100644
--- a/xen/include/asm-x86/processor.h
+++ b/xen/include/asm-x86/processor.h
@@ -99,7 +99,7 @@
* Host IA32_CR_PAT value to cover all memory types. This is not the default
* MSR_PAT value, and is an ABI with PV guests.
*/
-#define XEN_MSR_PAT 0x050100070406ul
+#define XEN_MSR_PAT _AC(0x050100070406, ULL)
#ifndef __ASSEMBLY__
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] x86/msr: Fix XEN_MSR_PAT to build with older binutils
2020-04-29 21:39 [PATCH] x86/msr: Fix XEN_MSR_PAT to build with older binutils Andrew Cooper
@ 2020-04-30 6:50 ` Jan Beulich
0 siblings, 0 replies; 2+ messages in thread
From: Jan Beulich @ 2020-04-30 6:50 UTC (permalink / raw)
To: Andrew Cooper, Xen-devel; +Cc: Wei Liu, Roger Pau Monné
On 29.04.2020 23:39, Andrew Cooper wrote:
> Older binutils complains with:
> trampoline.S:95: Error: junk `ul&0xffffffff' after expression
>
> Use an assembly-safe constant.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-30 6:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-29 21:39 [PATCH] x86/msr: Fix XEN_MSR_PAT to build with older binutils Andrew Cooper
2020-04-30 6:50 ` Jan Beulich
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.